[MDL-32861] Course file upload limit is ignored when maxbytes is set to server limit - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.1.6, 2.2.3, 2.3
Fix Version/s: 2.1.7, 2.2.4
Component/s: Administration, Filepicker
Labels:
- patch
- triaged

Affected Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
https://github.com/mackensen/moodle
Testing Instructions:

Hide

1. Set the server maximum uploaded file size to some numeric value (A).
2. Set the course maximum uploaded file size to some numeric value less than A (B).
3. Attempt to upload a file with size C, where C is larger than B but smaller than A. Verify that it fails.
4. Attempt to upload a file with size D, where D is smaller than A and B. Verify that it succeeds.
5. Set the server maximum uploaded file size to "Server limit."
6. Repeat steps 2 through 4.

Show
1. Set the server maximum uploaded file size to some numeric value (A). 2. Set the course maximum uploaded file size to some numeric value less than A (B). 3. Attempt to upload a file with size C, where C is larger than B but smaller than A. Verify that it fails. 4. Attempt to upload a file with size D, where D is smaller than A and B. Verify that it succeeds. 5. Set the server maximum uploaded file size to "Server limit." 6. Repeat steps 2 through 4.

Description

We've noticed an inconsistency with how Server and Course file upload limits interact when one is less than the other. If Server limit (maxbytes) is set to 10MB, and the Course limit to 5MB, then a 7MB file is rejected (and the message clearly mentions a form restriction and not any server limitation).

However, let's say that maxbytes is set to "Server limit" (0), and the Course limit is still 5MB. A 7MB file will upload without any problems, ignoring the course limit.

Observed in 2.2.1 and current master (2.3).

Attachments

Issue Links

has been marked as being related by

MDL-37122 Activities include course limit for files even when it exceedes the site limit

Closed

will be (partly) resolved by

MDL-31901 Changing interface of file picker/manager/browser, use renderers

Closed

Activity

People

Assignee:: Charles Fulton

Reporter:: Charles Fulton

Peer reviewer:: Ankit Agarwal

Integrator:: Aparup Banerjee

Tester:: Rajesh Taneja

Participants:: Ankit Agarwal, Aparup Banerjee, Charles Fulton, Dan Poltawski, Eloy Lafuente (stronk7), Marina Glancy, Rajesh Taneja

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 09/May/12 4:58 PM

Updated:: 12/Dec/12 10:22 PM

Resolved:: 20/May/12 2:58 AM

Fix Release Date:: 9/Jul/12