Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32869

Ugly filter plugin table in formal_white needs rows resize

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.3
    • Component/s: Themes
    • Labels:
      None
    • Testing Instructions:
      Hide

      Go to Settings -> Site administration -> Plugins -> Filters -> Manage filters in formal_white.
      you are supposed to see a table very tall rows as in the second attached picture.
      Apply the patch.
      The table should have acceptable tall rows now.

      Show
      Go to Settings -> Site administration -> Plugins -> Filters -> Manage filters in formal_white. you are supposed to see a table very tall rows as in the second attached picture. Apply the patch. The table should have acceptable tall rows now.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32869_master

      Description

      Take a tranquilizer.
      Go to Settings -> Site administration -> Plugins -> Filters -> Manage filters in formal_white.
      I strongly feel that table's rows need resizing.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            andreabix Andrea Bicciolo added a comment -

            The update to theme formal_white looks fine to me.

            Show
            andreabix Andrea Bicciolo added a comment - The update to theme formal_white looks fine to me.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks, i've integrated this now.

            Show
            poltawski Dan Poltawski added a comment - Thanks, i've integrated this now.
            Hide
            abgreeve Adrian Greeve added a comment -

            I followed the instructions and looked at the issue before and after the patch. I also tried it out in a few browsers to see if there was any difference there. Everything looks good.
            Thanks.

            Show
            abgreeve Adrian Greeve added a comment - I followed the instructions and looked at the issue before and after the patch. I also tried it out in a few browsers to see if there was any difference there. Everything looks good. Thanks.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            U P S T R E A M I Z E D !

            Many thanks for the hard work, closing this as fixed.

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12