Moodle

Ill formed breadcrumb on "This user's role assignments" page

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.2.2
  • Fix Version/s: 2.1.7, 2.2.4
  • Component/s: Navigation
  • Labels:
  • Testing Instructions:
    Hide
    1. Log in as an admin
    2. Browse to Settings > My profile settings > Roles > This users role assignments and check the navbar makes sense.
    3. Browse to a course
    4. Browse to Settings > My profile settings > Roles > This users role assignments (will have a URL relative to the course now) and check the navbar makes sense.
    5. In the course participants list click to view a users course profile.
    6. Browse to Settings > Profile settings for USERS_FULL_NAME_HERE > Roles > This users role assignments and check the navbar makes sense.
    7. In the URL change course=X to course=1 (the id of the front page) and check the navbar makes sense.
    Show
    Log in as an admin Browse to Settings > My profile settings > Roles > This users role assignments and check the navbar makes sense. Browse to a course Browse to Settings > My profile settings > Roles > This users role assignments (will have a URL relative to the course now) and check the navbar makes sense. In the course participants list click to view a users course profile. Browse to Settings > Profile settings for USERS_FULL_NAME_HERE > Roles > This users role assignments and check the navbar makes sense. In the URL change course=X to course=1 (the id of the front page) and check the navbar makes sense.
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_22_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    wip-MDL-32872-m23
  • Pull Master Diff URL:

Description

Breadcrumb of the page "This user's role assignments" is ill formed.

Text "This user's role assignments" appears twice and the last one is not a link. Earlier one is a link and will take you to the current page.

To replicate:

  1. Go to some course.
  2. In settings block go to: My profile settings -> Roles -> This user's role assignments
  3. See the breadcrumb

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sam Hemelryk added a comment -

Thanks for the report!
I've created a patch for this now and am putting it straight up for integration (simple changes here).

Show
Sam Hemelryk added a comment - Thanks for the report! I've created a patch for this now and am putting it straight up for integration (simple changes here).
Hide
Permalink
Sam Hemelryk added a comment -

Up for integration now

Show
Sam Hemelryk added a comment - Up for integration now
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Juho Viitasalo added a comment -

Thanks for working on this!

Show
Juho Viitasalo added a comment - Thanks for working on this!
Hide
Permalink
Dan Poltawski added a comment -

Thanks Sam, integrated this now

Show
Dan Poltawski added a comment - Thanks Sam, integrated this now
Hide
Permalink
Frédéric Massart added a comment -

Test successful on 2.1, 2.2 and master

Show
Frédéric Massart added a comment - Test successful on 2.1, 2.2 and master
Hide
Permalink
Juho Viitasalo added a comment -

I noticed same kind of problem on wiki pages (edit, comment...) are these related?

Show
Juho Viitasalo added a comment - I noticed same kind of problem on wiki pages (edit, comment...) are these related?
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

U P S T R E A M I Z E D !

Many thanks for the hard work, closing this as fixed.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: