Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32873

Separate out course ajax enabled checking to separate function

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      Open a course page with a number of course modules present

      • Ensure that all of the AJAX resource buttons still work
        • right/left
        • show/hide
        • group mode toggle (on activities)
        • delete
        • drag/drop
      • Ensure that the AJAX section buttons work as inticipated
        • show/hide
        • drag/drop

      Then:

      • disable ajax support by turning off the 'enableajax' setting
        • confirm that we're back to the non-ajax versions

      For bonus points:

      • (re-enable the sitewide enableajax setting)
      • open your current theme's config.php and add:

        $THEME->enablecourseajax = false;

        • confirm that we're back to the non-ajax versions of all icons
        • remove the theme config line
      • open your current format's lib.php and find the callback_$name_ajax_support function and change the capable line:

        $ajaxsupport->capable = false;

        • confirm that we're back to the non-ajax versions of all icons
        • change things back to normal
      Show
      Open a course page with a number of course modules present Ensure that all of the AJAX resource buttons still work right/left show/hide group mode toggle (on activities) delete drag/drop Ensure that the AJAX section buttons work as inticipated show/hide drag/drop Then: disable ajax support by turning off the 'enableajax' setting confirm that we're back to the non-ajax versions For bonus points: (re-enable the sitewide enableajax setting) open your current theme's config.php and add: $THEME->enablecourseajax = false; confirm that we're back to the non-ajax versions of all icons remove the theme config line open your current format's lib.php and find the callback_$name_ajax_support function and change the capable line: $ajaxsupport->capable = false; confirm that we're back to the non-ajax versions of all icons change things back to normal
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32873-master-1

      Description

      For MDL-31215 and others we sometimes need to check whether AJAX should be enabled so it would be beneficial to split this into a separate function.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12