Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32875

When the section is highlighted, background update on section move fails.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Course, JavaScript
    • Labels:

      Description

      That is why we need functional tests.

      It appeared that if we have a highlighted section, the moves that affect the highlighted section location fails on the background. See AJAX response for details.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              kabalin Ruslan Kabalin added a comment -

              Making it major and added instructions. Patch is coming.

              Show
              kabalin Ruslan Kabalin added a comment - Making it major and added instructions. Patch is coming.
              Hide
              kabalin Ruslan Kabalin added a comment -

              Andrew, can you please review this.

              Show
              kabalin Ruslan Kabalin added a comment - Andrew, can you please review this.
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Looks good to me.
              Submit for peer review when ready.

              Show
              dobedobedoh Andrew Nicols added a comment - Looks good to me. Submit for peer review when ready.
              Hide
              kabalin Ruslan Kabalin added a comment -

              Ready for integration

              Show
              kabalin Ruslan Kabalin added a comment - Ready for integration
              Hide
              poltawski Dan Poltawski added a comment -

              Perhaps you can help with the functional tests which are being written by writing some tests and adding the qa_test_required label.

              Show
              poltawski Dan Poltawski added a comment - Perhaps you can help with the functional tests which are being written by writing some tests and adding the qa_test_required label.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              poltawski Dan Poltawski added a comment -

              Adding the QA test required label so Tim can check if we coverage for this, if not hopefully Ruslan can help with doing that.

              Show
              poltawski Dan Poltawski added a comment - Adding the QA test required label so Tim can check if we coverage for this, if not hopefully Ruslan can help with doing that.
              Hide
              poltawski Dan Poltawski added a comment -

              Integrated, thanks

              Show
              poltawski Dan Poltawski added a comment - Integrated, thanks
              Hide
              ankit_frenz Ankit Agarwal added a comment -

              working as expected
              Passing.
              Thanks

              Show
              ankit_frenz Ankit Agarwal added a comment - working as expected Passing. Thanks
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              U P S T R E A M I Z E D !

              Many thanks for the hard work, closing this as fixed.

              Ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao
              Hide
              kabalin Ruslan Kabalin added a comment -

              Thanks Eloy!

              Show
              kabalin Ruslan Kabalin added a comment - Thanks Eloy!
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Removing qa_test_required as it's well covered by acceptance test now.

              Show
              rajeshtaneja Rajesh Taneja added a comment - Removing qa_test_required as it's well covered by acceptance test now.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12