Moodle
  1. Moodle
  2. MDL-32875

When the section is highlighted, background update on section move fails.

    Details

    • Rank:
      39942

      Description

      That is why we need functional tests.

      It appeared that if we have a highlighted section, the moves that affect the highlighted section location fails on the background. See AJAX response for details.

        Issue Links

          Activity

          Hide
          Ruslan Kabalin added a comment -

          Making it major and added instructions. Patch is coming.

          Show
          Ruslan Kabalin added a comment - Making it major and added instructions. Patch is coming.
          Hide
          Ruslan Kabalin added a comment -

          Andrew, can you please review this.

          Show
          Ruslan Kabalin added a comment - Andrew, can you please review this.
          Hide
          Andrew Nicols added a comment -

          Looks good to me.
          Submit for peer review when ready.

          Show
          Andrew Nicols added a comment - Looks good to me. Submit for peer review when ready.
          Hide
          Ruslan Kabalin added a comment -

          Ready for integration

          Show
          Ruslan Kabalin added a comment - Ready for integration
          Hide
          Dan Poltawski added a comment -

          Perhaps you can help with the functional tests which are being written by writing some tests and adding the qa_test_required label.

          Show
          Dan Poltawski added a comment - Perhaps you can help with the functional tests which are being written by writing some tests and adding the qa_test_required label.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Poltawski added a comment -

          Adding the QA test required label so Tim can check if we coverage for this, if not hopefully Ruslan can help with doing that.

          Show
          Dan Poltawski added a comment - Adding the QA test required label so Tim can check if we coverage for this, if not hopefully Ruslan can help with doing that.
          Hide
          Dan Poltawski added a comment -

          Integrated, thanks

          Show
          Dan Poltawski added a comment - Integrated, thanks
          Hide
          Ankit Agarwal added a comment -

          working as expected
          Passing.
          Thanks

          Show
          Ankit Agarwal added a comment - working as expected Passing. Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          U P S T R E A M I Z E D !

          Many thanks for the hard work, closing this as fixed.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao
          Hide
          Ruslan Kabalin added a comment -

          Thanks Eloy!

          Show
          Ruslan Kabalin added a comment - Thanks Eloy!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: