Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.3
-
Fix Version/s: 2.3
-
Component/s: AJAX and JavaScript, Course
-
Labels:
-
Testing Instructions:
- Open the course page
- Make any section highlighted
- Move the highlighted section
- Refresh the page, the highlighted section should remain where it was dropped
-
Affected Branches:MOODLE_23_STABLE
-
Fixed Branches:MOODLE_23_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-32875-master-1 -
Pull Master Diff URL:
-
Rank:39942
Description
That is why we need functional tests.
It appeared that if we have a highlighted section, the moves that affect the highlighted section location fails on the background. See AJAX response for details.
Issue Links
- required writing of QA test
-
MDLQA-2396
CLONE - A highlighted section with no activities or resources can be moved using drag and drop in IE8.
- Passed
-
MDLQA-2397
CLONE - A highlighted section with no activities or resources can be moved using drag and drop in IE9.
- Passed
-
MDLQA-2398
CLONE - A highlighted section with no activities or resources can be moved using drag and drop in Firefox.
- Passed
-
MDLQA-2399
CLONE - A highlighted section with no activities or resources can be moved using drag and drop in Google Chrome.
- Passed
-
MDLQA-2400
CLONE - A highlighted section with no activities or resources can be moved using drag and drop in Safari.
- Passed
-
MDLQA-2401
CLONE - A highlighted section with no activities or resources can be moved using drag and drop in Opera.
- Passed
-
MDLQA-2402
CLONE - A highlighted section with a folder resource can be moved using drag and drop in IE8.
- Passed
-
MDLQA-2403
CLONE - A highlighted section with a folder resource can be moved using drag and drop in IE9.
- Passed
-
MDLQA-2404
CLONE - A highlighted section with a folder resource can be moved using drag and drop in Firefox.
- Passed
-
MDLQA-2405
CLONE - A highlighted section with a folder resource can be moved using drag and drop in Google Chrome.
- Passed
-
MDLQA-2406
CLONE - A highlighted section with a folder resource can be moved using drag and drop in Safari.
- Passed
-
MDLQA-2407
CLONE - A highlighted section with a folder resource can be moved using drag and drop in Opera.
- Passed
-
MDLQA-2408
CLONE - A highlighted section with multiple resources and activities can be moved using drag and drop in IE8.
- Passed
-
MDLQA-2410
CLONE - A highlighted section with multiple resources and activities can be moved using drag and drop in IE9.
- Passed
-
MDLQA-2411
CLONE - A highlighted section with multiple resources and activities can be moved using drag and drop in Firefox.
- Passed
-
MDLQA-2412
CLONE - A highlighted section with multiple resources and activities can be moved using drag and drop in Google Chrome.
- Passed
-
MDLQA-2413
CLONE - A highlighted section with multiple resources and activities can be moved using drag and drop in Safari.
- Passed
-
MDLQA-2414
CLONE - A highlighted section with multiple resources and activities can be moved using drag and drop in Opera.
- Passed
- will help resolve
-
MDL-32742
Course highlight/visibility issues with drag-drop
-
- Closed
-
Activity
Andrew, can you please review this.
Looks good to me.
Submit for peer review when ready.
Ready for integration
Perhaps you can help with the functional tests which are being written by writing some tests and adding the qa_test_required label.
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao 
Adding the QA test required label so Tim can check if we coverage for this, if not hopefully Ruslan can help with doing that.
Integrated, thanks
working as expected
Passing.
Thanks
U P S T R E A M I Z E D !
Many thanks for the hard work, closing this as fixed.
Ciao
Thanks Eloy!
Making it major and added instructions. Patch is coming.