Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28447 Improve page layout - add a block and turn editing on
  3. MDL-32879

Change default region from side-post to side-pre in some CORE themes

          Details

          • Type: Sub-task
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.3
          • Fix Version/s: 2.3
          • Component/s: Themes
          • Labels:
          • Testing Instructions:
            Hide

            The themes affected are Afterburner, Anomaly, Base, Boxxie, Canvas. Formal White, FormFactor, Leatherbound, Splash and Standard Old.

            1. As Administrator enable 'Allow theme change by URL' in Theme settings.
            2. Go to a page where there are blocks on both sides of the page and turn editing ON
            3. Add &theme=themename (where themename represents one of the affected themes listed above).
            4. Test each theme in turn to see that the ADD BLOCK appears on the LEFT, and not the right as was previously the case.
            Show
            The themes affected are Afterburner, Anomaly, Base, Boxxie, Canvas. Formal White, FormFactor, Leatherbound, Splash and Standard Old. As Administrator enable 'Allow theme change by URL' in Theme settings. Go to a page where there are blocks on both sides of the page and turn editing ON Add &theme=themename (where themename represents one of the affected themes listed above). Test each theme in turn to see that the ADD BLOCK appears on the LEFT, and not the right as was previously the case.
          • Affected Branches:
            MOODLE_23_STABLE
          • Fixed Branches:
            MOODLE_23_STABLE
          • Pull from Repository:
          • Pull Master Branch:
          • Pull Master Diff URL:

            Description

            If the default region in $THEME->layouts in a theme's config.php is changed from side-post to side-pre the ADD BLOCK appears on the left thus giving more room especially when EDITING.

            The changes only affect those themes that use three columns in the standard style [LEFT | MIDDLE | RIGHT]

              Gliffy Diagrams

                Attachments

                  Issue Links

                  has a non-specific relationship to

                  Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-33921 Add CSS to fix blocks-moving when pagelayout is side-pre-only

                  • Minor - Minor loss of function where workaround is possible
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    lazydaisy Mary Evans added a comment -

                    Themes that use the blog style layout (side-post-only) will not be affected by this change.

                    Show
                    lazydaisy Mary Evans added a comment - Themes that use the blog style layout (side-post-only) will not be affected by this change.
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

                    TIA and ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
                    Hide
                    Permalink
                    dougiamas Martin Dougiamas added a comment -

                    +1 from me, sounds like a sensible change.

                    Show
                    dougiamas Martin Dougiamas added a comment - +1 from me, sounds like a sensible change.
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Thanks Mary, this has been integrated now.
                    I did revert your changes on arialist which only has the post-region as well as one other area where there was no pre-region.

                    Cheers
                    Sam

                    Show
                    samhemelryk Sam Hemelryk added a comment - Thanks Mary, this has been integrated now. I did revert your changes on arialist which only has the post-region as well as one other area where there was no pre-region. Cheers Sam
                    Hide
                    Permalink
                    rwijaya Rossiani Wijaya added a comment -

                    Thanks Mary.

                    This is looking great.

                    However I noticed the page header is displaying blank with afterburner theme. Issue has been created to address this (MDL-33380).

                    Test passed.

                    Show
                    rwijaya Rossiani Wijaya added a comment - Thanks Mary. This is looking great. However I noticed the page header is displaying blank with afterburner theme. Issue has been created to address this ( MDL-33380 ). Test passed.
                    Hide
                    Permalink
                    lazydaisy Mary Evans added a comment -

                    It's working in my latest Moodle 2.3 ($version = 2012052200.00 so I am just wondering have you got some custom CSS in the Afterburner settings page you forgot about?

                    Show
                    lazydaisy Mary Evans added a comment - It's working in my latest Moodle 2.3 ($version = 2012052200.00 so I am just wondering have you got some custom CSS in the Afterburner settings page you forgot about?
                    Hide
                    Permalink
                    lazydaisy Mary Evans added a comment -

                    @Martin

                    Thanks for the vote of confidence with this, it is a simple solution and one which I use all the time.

                    I'm very pleased it's found its way into Moodle CORE.

                    Cheers
                    Mary

                    Show
                    lazydaisy Mary Evans added a comment - @Martin Thanks for the vote of confidence with this, it is a simple solution and one which I use all the time. I'm very pleased it's found its way into Moodle CORE. Cheers Mary
                    Hide
                    Permalink
                    rwijaya Rossiani Wijaya added a comment -

                    Hi Mary,

                    I made some comments on MDL-33380.

                    Show
                    rwijaya Rossiani Wijaya added a comment - Hi Mary, I made some comments on MDL-33380 .
                    Hide
                    Permalink
                    poltawski Dan Poltawski added a comment -

                    Congratulations!

                    Your work has made into the latest Moodle release!

                    You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

                    Show
                    poltawski Dan Poltawski added a comment - Congratulations! Your work has made into the latest Moodle release! You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!
                    Hide
                    Permalink
                    lazydaisy Mary Evans added a comment -

                    I think I missed off some CSS to take account of when you are in side-pre-only situation and want to move blocks to side-post. You can't!

                    I'll create a new sub-task and link this to it.

                    Show
                    lazydaisy Mary Evans added a comment - I think I missed off some CSS to take account of when you are in side-pre-only situation and want to move blocks to side-post. You can't! I'll create a new sub-task and link this to it.

                      People

                      • Votes:
                        1 Vote for this issue
                        Watchers:
                        4 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          25/Jun/12