Moodle
  1. Moodle
  2. MDL-32899

Assignment upgrade tool fails on onlinetext assignments with feedback but no submission.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Navigate to Site admin > Plugins > Activity modules > Manage activities
      3. Unhide the Assignment 2.2 module
      4. Log into a course
      5. Make sure there is at least one student in the course.
      6. Create an instance of an old onlinetext assignment (Assignment 2.2).
      7. Grade the assignment for the student and provide a feedback comment (even though they have not submitted anything).
      8. Go to the assignment upgrade tool and upgrade the assignment.

      Expected result: The upgrade should complete with no errors reported.

      Show
      Log in as admin Navigate to Site admin > Plugins > Activity modules > Manage activities Unhide the Assignment 2.2 module Log into a course Make sure there is at least one student in the course. Create an instance of an old onlinetext assignment (Assignment 2.2). Grade the assignment for the student and provide a feedback comment (even though they have not submitted anything). Go to the assignment upgrade tool and upgrade the assignment. Expected result: The upgrade should complete with no errors reported.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
    • Rank:
      39975

      Description

      If an (Assignment 2.2) onlinetext assignment contains a submission with feedback but no submission, the assignment upgrade tool will report an error when it attempts to upgrade this assignment.

        Activity

        Hide
        Dan Poltawski added a comment -

        Hi Damyon,

        Looks good and i've integrated it thanks!

        There was some trailing whitespace in the patch which I fixed up - if you could watch out for that it'd be helpful for us as we need to remove any trailing whitespace errors.

        cheers,
        dan

        Show
        Dan Poltawski added a comment - Hi Damyon, Looks good and i've integrated it thanks! There was some trailing whitespace in the patch which I fixed up - if you could watch out for that it'd be helpful for us as we need to remove any trailing whitespace errors. cheers, dan
        Hide
        Damyon Wiese added a comment -

        Sorry - I did this from a different dev machine.

        Regards, Damyon

        Show
        Damyon Wiese added a comment - Sorry - I did this from a different dev machine. Regards, Damyon
        Hide
        Aparup Banerjee added a comment -

        is it right that after running the test the assignment grading summary says submitted = 1 when before the upgrade there were no submissions?
        and going into grading it says under status='submitted for grading \n graded'. just wondering if that mapping is correct?

        Show
        Aparup Banerjee added a comment - is it right that after running the test the assignment grading summary says submitted = 1 when before the upgrade there were no submissions? and going into grading it says under status='submitted for grading \n graded'. just wondering if that mapping is correct?
        Hide
        Aparup Banerjee added a comment -

        ah the same behaviour is there in the old assignment so passing this as the test ran fine

        ps: behaviour is slightly weird though - saying 'View 1 submitted assignments' or submitted = 1 when really non were submitted but only graded or given feedback.

        Show
        Aparup Banerjee added a comment - ah the same behaviour is there in the old assignment so passing this as the test ran fine ps: behaviour is slightly weird though - saying 'View 1 submitted assignments' or submitted = 1 when really non were submitted but only graded or given feedback.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome?

        Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome? Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U Closing, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: