Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32903

The use of $settings in add_admin_assign_plugin_settings is weird

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Assignment
    • Labels:

      Description

      As far I can tell $settings is not being [used] as its not being passed by reference (which is a good thing IMO)

      So the whole $tempsettings thing around the loop isn't required?

        Attachments

          Activity

            People

            Assignee:
            damyon Damyon Wiese
            Reporter:
            poltawski Dan Poltawski
            Peer reviewer:
            Dan Poltawski Dan Poltawski
            Integrator:
            Sam Hemelryk Sam Hemelryk
            Tester:
            Andrew Davis Andrew Davis
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              25/Jun/12