Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32904

Coding error in set_config

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create an instance of mod_assign in a course.
      2. On the module settings screen, enable file submissions and set the maximum number of files to 3.
      3. Edit the settings again and check that the maximum number of files submissions is still set to 3.
      Show
      Create an instance of mod_assign in a course. On the module settings screen, enable file submissions and set the maximum number of files to 3. Edit the settings again and check that the maximum number of files submissions is still set to 3.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:

      Description

      update_record third param is a bool, so there is a bug here:

          public final function set_config($name, $value) {
              global $DB;
       
              $current = $DB->get_record('assign_plugin_config', array('assignment'=>$this->assignment->get_instance()->id, 'subtype'=>$this->get_subtype(), 'plugin'=>$this->get_type(), 'name'=>$name), '*', IGNORE_MISSING);
       
              if ($current) {
                  $current->value = $value;
                  return $DB->update_record('assign_plugin_config', $current, array('id'=>$current->id));

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Jun/12