Loading...

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://github.com/netspotau/moodle-mod_assign.git
Pull Main Branch:
~~MDL-32909~~
Pull Main Diff URL:
https://github.com/netspotau/moodle-mod_assign/commit/b11808c7d60443d155ae066f4da82827f33a3ea1
Testing Instructions:
Hide

Create an instance of the new assignment module in a course with at least one student

Go to the grading report and override a students mark for the assignment

Edit the mark again and uncheck the overridden option

Mark should go back to the mark from the assignment (none in this case). Without this patch you will see the above error at this step.
Show
Create an instance of the new assignment module in a course with at least one student Go to the grading report and override a students mark for the assignment Edit the mark again and uncheck the overridden option Mark should go back to the mark from the assignment (none in this case). Without this patch you will see the above error at this step.

After overriding a grade, then unchecking the override option to restore the original grade, an error was displayed...

Can not find data record in database table course_modules.

More information about this error

Debug info: SELECT id,course FROM {course_modules} WHERE id = ?

[array (

0 => '',

)]

Stack trace:

    line 1316 of \lib\dml\moodle_database.php: dml_missing_record_exception thrown

    line 1292 of \lib\dml\moodle_database.php: call to moodle_database->get_record_select()

    line 6585 of \lib\accesslib.php: call to moodle_database->get_record()

    line 757 of \mod\assign\lib.php: call to context_module::instance()

    line 776 of \mod\assign\lib.php: call to assign_get_user_grades()

    line 1190 of \lib\gradelib.php: call to assign_update_grades()

    line 1447 of \lib\grade\grade_item.php: call to grade_update_mod_grades()

    line 319 of \lib\grade\grade_grade.php: call to grade_item->refresh_grades()

    line 215 of \grade\edit\tree\grade.php: call to grade_grade->set_overridden()

This did not happen when I did the same think with the older assignment module.

Replication steps:

Create an assignment
Go to the assignment grading page and grade some students (no need for submissions)
Go to the Grading report (Course admin -> Grades)
Turn editing on
Click the edit icon (in Standard theme this is a hand holding a pencil)
Check the overridden checkbox setting, alter the grade and save
Click the edit icon again
Uncheck the overridden checkbox and save

Expected result: the user should be returned to the Grader report and the original grade should be shown

Actual result: an error is shown

Testing discovered

MDL-18095 Cannot clear override flag on grades with feedback

Participants:: Andrew Davis, Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Michael de Raadt