Moodle

Can't add LTI tool providers from admin screen

Details

  • Testing Instructions:
    Hide
    1. Go to Administration > Plugins > Activity Modules > External Tool
    2. Click "Add external tool configuration"
    3. Enter required fields (any values)
    4. Click save

    Expected result: After saving, it should take you to the tool listing page (step 1), and the new tool provider should be listed

    Show
    Go to Administration > Plugins > Activity Modules > External Tool Click "Add external tool configuration" Enter required fields (any values) Click save Expected result: After saving, it should take you to the tool listing page (step 1), and the new tool provider should be listed
  • Affected Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

When looking into another issue I noticed that I couldn't add new LTI tool providers from the admin interface on the 2.3 weekly dev release (e16e2300c575464a873029b9cb3375fd5e1cc2a2).

Issue Links

has a non-specific relationship to

Improvement - An enhancement to an existing Moodle feature. MDL-30686 $FULLME should not be used for current page

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chris Scribner added a comment -

Fix is here: https://github.com/scriby/moodle/tree/MDL-32921

Show
Chris Scribner added a comment - Fix is here: https://github.com/scriby/moodle/tree/MDL-32921
Hide
Permalink
Chris Scribner added a comment -

Testing instructions:

Wrong (current) behavior:

1. Go to Administration > Plugins > Activity Modules > External Tool
2. Click "Add external tool configuration"
3. Enter required fields (any values)
4. Click save
5. It takes you to the wrong screen, and if you go back to the tool listing page (step 1), no tool provider was created

Correct behavior:

1-4: Same
5: After saving, it should take you to the tool listing page (step 1), and the new tool provider should be listed

Show
Chris Scribner added a comment - Testing instructions: Wrong (current) behavior: 1. Go to Administration > Plugins > Activity Modules > External Tool 2. Click "Add external tool configuration" 3. Enter required fields (any values) 4. Click save 5. It takes you to the wrong screen, and if you go back to the tool listing page (step 1), no tool provider was created Correct behavior: 1-4: Same 5: After saving, it should take you to the tool listing page (step 1), and the new tool provider should be listed
Hide
Permalink
Michael de Raadt added a comment -

Thanks for working on this, Chris.

Hopefully we can peer review this soon.

Show
Michael de Raadt added a comment - Thanks for working on this, Chris. Hopefully we can peer review this soon.
Hide
Permalink
Dan Poltawski added a comment -

Another one uncovered by MDL-30686

Show
Dan Poltawski added a comment - Another one uncovered by MDL-30686
Hide
Permalink
Dan Poltawski added a comment -

Looks good, submitting for integration

Show
Dan Poltawski added a comment - Looks good, submitting for integration
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Aparup Banerjee added a comment -

Thanks thats been integrated into master and also cherry-picked into MOODLE_22_STABLE.

ps: i've added a commit that saves on one moodle_url object creation.

Show
Aparup Banerjee added a comment - Thanks thats been integrated into master and also cherry-picked into MOODLE_22_STABLE. ps: i've added a commit that saves on one moodle_url object creation.
Hide
Permalink
Andrew Davis added a comment -

Works as described. Passing.

Show
Andrew Davis added a comment - Works as described. Passing.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

U P S T R E A M I Z E D !

Many thanks for the hard work, closing this as fixed.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: