Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Unit tests
    • Labels:
    • Rank:
      40003

      Description

      $tables = $DB->get_tables(false); is slow in some cases, so test self::$lastdbwrites == $DB->perf_get_writes() first.

        Activity

        Hide
        Petr Škoda added a comment -

        +10, thanks!

        Show
        Petr Škoda added a comment - +10, thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Passing, all test executed and passed, both against local db (got 10secs improvement, not sure if due to this) and remote db (20secs improvement, mssql running on windows VM).

        Show
        Eloy Lafuente (stronk7) added a comment - Passing, all test executed and passed, both against local db (got 10secs improvement, not sure if due to this) and remote db (20secs improvement, mssql running on windows VM).
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome?

        Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome? Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U Closing, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: