Patch to change forum overview to use the authoritative source of forum post information (forum, forum_post and forum_discussion tables) rather than the log table. Fixes course overview block to return accurate results and can significantly improve performance.

Thanks for reporting that and providing a solution.

It would help if you could provide a set of testing instructions for your solution.

Added test instructions.

Thanks for the patch Tom. Updating pull branches. Thanks DanP for the comments

In general I think the approach seems to make sense. But you need to check if this change is cross-db compatible.

It looks to me like it might break need both the count and forumid in the group by statement to work on all dbs.

Thanks for the comments Dan. Query tested with mysql, postgres, oracle and mssql

Hi David,

It looks good for integration, the only comment is that it'd be much easier for us to integrate if could add more extensive testing instructions to cover a more detailed scenario to ensure we are not introducing regressions. (e.g. more users and discussions etc)

Thanks Dan, adding more instructions and submitting for integration

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Pull branches rebased against upstream. Thanks

Thanks David, this has been integrated now.

works fine David

asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ!

Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!