Moodle

Deprecated PARAM_NUMBER should be replaced with PARAM_FLOAT

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3
  • Fix Version/s: 2.4
  • Component/s: Libraries
  • Labels:
  • Testing Instructions:
    Hide

    Test 1:
    grep -Ri PARAM_NUMBER .
    and make sure it's not used in code. Only lib/moodlelib.php should have declaration

    Test 2:
    Review changes and try find any silly mistake.

    Show
    Test 1: grep -Ri PARAM_NUMBER . and make sure it's not used in code. Only lib/moodlelib.php should have declaration Test 2: Review changes and try find any silly mistake.
  • Affected Branches:
    MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_24_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    wip-mdl-32940
  • Pull Master Diff URL:

Description

PARAM_INTEGER was deprecated in 2.0, please replace it with PARAM_NUMBER and remove PARAM_FLOAT declaration.

Issue Links

has a non-specific relationship to

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-32942 Deprecated PARAM_ACTION and PARAM_FORMAT should be replaced with PARAM_ALPHANUMEXT

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-32945 Deprecated PARAM_MULTILANG should be replaced with PARAM_TEXT

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
has been marked as being related by

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-30651 Deprecated PARAM_INTEGER should be replaced with PARAM_INT

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda added a comment -

I think both PARAM_FLOAT and PARAM_NUMBER should be deprecated in favour of something else that deals with floating points and commas properly, but I am afraid this will have to wait till new forms library. There should nob be a need for floating point GET parameters...

Show
Petr Škoda added a comment - I think both PARAM_FLOAT and PARAM_NUMBER should be deprecated in favour of something else that deals with floating points and commas properly, but I am afraid this will have to wait till new forms library. There should nob be a need for floating point GET parameters...
Hide
Permalink
Rajesh Taneja added a comment -

Thanks Petr, for now I will just make it consistent in code to use PARAM_FLOAT and leave PARAM_NUMBER declaration. Probably, we can get rid of that with something else later.

Show
Rajesh Taneja added a comment - Thanks Petr, for now I will just make it consistent in code to use PARAM_FLOAT and leave PARAM_NUMBER declaration. Probably, we can get rid of that with something else later.
Hide
Permalink
Rajesh Taneja added a comment -

PARAM_FLOAT declaration is not removed for 3rd party compatibility.

Show
Rajesh Taneja added a comment - PARAM_FLOAT declaration is not removed for 3rd party compatibility.
Hide
Permalink
Sam Hemelryk added a comment -

Changes look good thanks Raj, put this up for integration when you are ready and rebased

Show
Sam Hemelryk added a comment - Changes look good thanks Raj, put this up for integration when you are ready and rebased
Hide
Permalink
Rajesh Taneja added a comment -

Thanks Sam and Petr.

Show
Rajesh Taneja added a comment - Thanks Sam and Petr.
Hide
Permalink
Dan Poltawski added a comment -

Delaying till the start of the 2.4 dev cycle. We don't want any more big changes for now.

Show
Dan Poltawski added a comment - Delaying till the start of the 2.4 dev cycle. We don't want any more big changes for now.
Hide
Permalink
Rajesh Taneja added a comment -

Branch re-based,
Pushing it for integration review.

Show
Rajesh Taneja added a comment - Branch re-based, Pushing it for integration review.
Hide
Permalink
Dan Poltawski added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Rajesh Taneja added a comment -

Brach re-based.

Show
Rajesh Taneja added a comment - Brach re-based.
Hide
Permalink
Dan Poltawski added a comment -

Just adding Tim here because this touches question component mostly.

Show
Dan Poltawski added a comment - Just adding Tim here because this touches question component mostly.
Hide
Permalink
Tim Hunt added a comment -

https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-32940#L17R278 is wrong. Should be PARAM_INT.

Otherwise fine.

By the way, http://tracker.moodle.org/browse/MDL-32940?focusedCommentId=156907&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-156907 is really needed for teachers editing numerical questions, but it is a separate issue.

Show
Tim Hunt added a comment - https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-32940#L17R278 is wrong. Should be PARAM_INT. Otherwise fine. By the way, http://tracker.moodle.org/browse/MDL-32940?focusedCommentId=156907&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-156907 is really needed for teachers editing numerical questions, but it is a separate issue.
Hide
Permalink
Rajesh Taneja added a comment -

Thanks for the inputs Tim,

Replaced FLOAT with INT at https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-32940#L17R278

Show
Rajesh Taneja added a comment - Thanks for the inputs Tim, Replaced FLOAT with INT at https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-32940#L17R278
Hide
Permalink
Dan Poltawski added a comment -

Thanks guys, i've integrated this now

Show
Dan Poltawski added a comment - Thanks guys, i've integrated this now
Hide
Permalink
Ankit Agarwal added a comment -

Hi Guys,
Looks good to me.
Passing!
Thanks

Show
Ankit Agarwal added a comment - Hi Guys, Looks good to me. Passing! Thanks
Hide
Permalink
Aparup Banerjee added a comment -

yay, it works!

This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

Thank you all for taking the time to get us here.

cheers!

Show
Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: