Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.4
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      Test 1:
      grep -Ri PARAM_NUMBER .
      and make sure it's not used in code. Only lib/moodlelib.php should have declaration

      Test 2:
      Review changes and try find any silly mistake.

      Show
      Test 1: grep -Ri PARAM_NUMBER . and make sure it's not used in code. Only lib/moodlelib.php should have declaration Test 2: Review changes and try find any silly mistake.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip-mdl-32940
    • Rank:
      40021

      Description

      PARAM_INTEGER was deprecated in 2.0, please replace it with PARAM_NUMBER and remove PARAM_FLOAT declaration.

        Issue Links

          Activity

          Hide
          Petr Škoda added a comment -

          I think both PARAM_FLOAT and PARAM_NUMBER should be deprecated in favour of something else that deals with floating points and commas properly, but I am afraid this will have to wait till new forms library. There should nob be a need for floating point GET parameters...

          Show
          Petr Škoda added a comment - I think both PARAM_FLOAT and PARAM_NUMBER should be deprecated in favour of something else that deals with floating points and commas properly, but I am afraid this will have to wait till new forms library. There should nob be a need for floating point GET parameters...
          Hide
          Rajesh Taneja added a comment -

          Thanks Petr, for now I will just make it consistent in code to use PARAM_FLOAT and leave PARAM_NUMBER declaration. Probably, we can get rid of that with something else later.

          Show
          Rajesh Taneja added a comment - Thanks Petr, for now I will just make it consistent in code to use PARAM_FLOAT and leave PARAM_NUMBER declaration. Probably, we can get rid of that with something else later.
          Hide
          Rajesh Taneja added a comment -

          PARAM_FLOAT declaration is not removed for 3rd party compatibility.

          Show
          Rajesh Taneja added a comment - PARAM_FLOAT declaration is not removed for 3rd party compatibility.
          Hide
          Sam Hemelryk added a comment -

          Changes look good thanks Raj, put this up for integration when you are ready and rebased

          Show
          Sam Hemelryk added a comment - Changes look good thanks Raj, put this up for integration when you are ready and rebased
          Hide
          Rajesh Taneja added a comment -

          Thanks Sam and Petr.

          Show
          Rajesh Taneja added a comment - Thanks Sam and Petr.
          Hide
          Dan Poltawski added a comment -

          Delaying till the start of the 2.4 dev cycle. We don't want any more big changes for now.

          Show
          Dan Poltawski added a comment - Delaying till the start of the 2.4 dev cycle. We don't want any more big changes for now.
          Hide
          Rajesh Taneja added a comment -

          Branch re-based,
          Pushing it for integration review.

          Show
          Rajesh Taneja added a comment - Branch re-based, Pushing it for integration review.
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Rajesh Taneja added a comment -

          Brach re-based.

          Show
          Rajesh Taneja added a comment - Brach re-based.
          Hide
          Dan Poltawski added a comment -

          Just adding Tim here because this touches question component mostly.

          Show
          Dan Poltawski added a comment - Just adding Tim here because this touches question component mostly.
          Hide
          Tim Hunt added a comment -
          Show
          Tim Hunt added a comment - https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-32940#L17R278 is wrong. Should be PARAM_INT. Otherwise fine. By the way, http://tracker.moodle.org/browse/MDL-32940?focusedCommentId=156907&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-156907 is really needed for teachers editing numerical questions, but it is a separate issue.
          Hide
          Rajesh Taneja added a comment -

          Thanks for the inputs Tim,

          Replaced FLOAT with INT at https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-32940#L17R278

          Show
          Rajesh Taneja added a comment - Thanks for the inputs Tim, Replaced FLOAT with INT at https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-32940#L17R278
          Hide
          Dan Poltawski added a comment -

          Thanks guys, i've integrated this now

          Show
          Dan Poltawski added a comment - Thanks guys, i've integrated this now
          Hide
          Ankit Agarwal added a comment -

          Hi Guys,
          Looks good to me.
          Passing!
          Thanks

          Show
          Ankit Agarwal added a comment - Hi Guys, Looks good to me. Passing! Thanks
          Hide
          Aparup Banerjee added a comment -

          yay, it works!

          This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

          Thank you all for taking the time to get us here.

          cheers!

          Show
          Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: