Not removed declaration for 3rd party compatibility reasons.

Hi Raj,

Changes look good thanks, feel free to put this up for integration when ready.

There are two thoughts I've had while looking at these changes.

1. We should consider moving the deprecated params to deprecatedlib.php and giving them all an @since version.
2. We should add a unit test to tests/moodlelib_test.php to test all deprecated PARAM_* are matching to the expected type (just to make sure no-one makes further changes and to be truely aware when removing them for good)

Cheers
Sam

Thanks Sam,

Is it fine to open a new bug to move deprecated params and add test case or shall I do it as part of this bug?

Probably best to handle it as a separate bug, and I'd both move the params and create test cases at the same time.
Before you do however check with Petr, just to be sure there is no good reason to keep them in the current location. I think moving them is a good idea that way when people locate them to check how they work they will find them in deprecated lib and be less tempted to use them.

Thanks Sam.

Delaying till the start of the 2.4 dev cycle. We don't want any more big changes for now.

Branch re-based
Pushing for integration review.

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Branch re-based.

Hi Raj, i've also noticed PARAM_MULTILANG and PARAM_CLEANFILE marked as deprecated. (seems since 2.0 , 2009-ish) i'm not sure if there are issues for these , but they could all be linked up somewhere.

Thanks Raj, thats integrated into master now.

ps: i can't see that any docs would require updating.

pps (Tester): a real tester would run through all the changed pages and verify that the params still work fine. That would be a large test though. your choice is : a developer's hat or a tester's hat? :-p

Developer's hat cause am a developer

Everything looks good to me.

Thanks

yay, it works!

This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

Thank you all for taking the time to get us here.

cheers!