Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.4
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      Test 1:
      grep -Ri PARAM_MULTILANG .
      and make sure it's not used in code. Only declaration should be there in lib/moodlelib.php and used in lib/tests/moodlelib_test.php

      Test 2:
      run
      phpunit moodlelib_testcase lib/tests/moodlelib_test.php

      Test 3:
      Review changes and try find any silly mistake.

      Show
      Test 1: grep -Ri PARAM_MULTILANG . and make sure it's not used in code. Only declaration should be there in lib/moodlelib.php and used in lib/tests/moodlelib_test.php Test 2: run phpunit moodlelib_testcase lib/tests/moodlelib_test.php Test 3: Review changes and try find any silly mistake.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip-mdl-32945
    • Rank:
      40057

      Description

      PARAM_MULTILANG was deprecated in 2.0, please replace it with PARAM_TEXT and remove PARAM_MULTILANG declaration.

        Issue Links

          Activity

          Hide
          Rajesh Taneja added a comment -

          Not removing declaration for 3rd party compatibility reasons.

          Show
          Rajesh Taneja added a comment - Not removing declaration for 3rd party compatibility reasons.
          Hide
          Sam Hemelryk added a comment -

          Changes look good thanks Raj, put this up for integration when you are ready.

          Show
          Sam Hemelryk added a comment - Changes look good thanks Raj, put this up for integration when you are ready.
          Hide
          Rajesh Taneja added a comment -

          Thanks Sam,

          Pushing it for integration.

          Show
          Rajesh Taneja added a comment - Thanks Sam, Pushing it for integration.
          Hide
          Dan Poltawski added a comment -

          Delaying till the start of the 2.4 dev cycle. We don't want any more big changes for now.

          Show
          Dan Poltawski added a comment - Delaying till the start of the 2.4 dev cycle. We don't want any more big changes for now.
          Hide
          Rajesh Taneja added a comment -

          Branches re-based,

          Pushing if back for integration review.

          Show
          Rajesh Taneja added a comment - Branches re-based, Pushing if back for integration review.
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Rajesh Taneja added a comment -

          Branch re-based.

          Show
          Rajesh Taneja added a comment - Branch re-based.
          Hide
          Dan Poltawski added a comment -

          Thanks Raj, i've integrated this now.

          Show
          Dan Poltawski added a comment - Thanks Raj, i've integrated this now.
          Hide
          Rossiani Wijaya added a comment -

          This looks great.

          Thanks Raj.

          Test passed.

          Show
          Rossiani Wijaya added a comment - This looks great. Thanks Raj. Test passed.
          Hide
          Aparup Banerjee added a comment -

          yay, it works!

          This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

          Thank you all for taking the time to get us here.

          cheers!

          Show
          Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: