Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.4
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      Test 1:
      grep -Ri PARAM_MULTILANG .
      and make sure it's not used in code. Only declaration should be there in lib/moodlelib.php and used in lib/tests/moodlelib_test.php

      Test 2:
      run
      phpunit moodlelib_testcase lib/tests/moodlelib_test.php

      Test 3:
      Review changes and try find any silly mistake.

      Show
      Test 1: grep -Ri PARAM_MULTILANG . and make sure it's not used in code. Only declaration should be there in lib/moodlelib.php and used in lib/tests/moodlelib_test.php Test 2: run phpunit moodlelib_testcase lib/tests/moodlelib_test.php Test 3: Review changes and try find any silly mistake.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip-mdl-32945

      Description

      PARAM_MULTILANG was deprecated in 2.0, please replace it with PARAM_TEXT and remove PARAM_MULTILANG declaration.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Not removing declaration for 3rd party compatibility reasons.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Not removing declaration for 3rd party compatibility reasons.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Changes look good thanks Raj, put this up for integration when you are ready.

            Show
            samhemelryk Sam Hemelryk added a comment - Changes look good thanks Raj, put this up for integration when you are ready.
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks Sam,

            Pushing it for integration.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks Sam, Pushing it for integration.
            Hide
            poltawski Dan Poltawski added a comment -

            Delaying till the start of the 2.4 dev cycle. We don't want any more big changes for now.

            Show
            poltawski Dan Poltawski added a comment - Delaying till the start of the 2.4 dev cycle. We don't want any more big changes for now.
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Branches re-based,

            Pushing if back for integration review.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Branches re-based, Pushing if back for integration review.
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Branch re-based.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Branch re-based.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks Raj, i've integrated this now.

            Show
            poltawski Dan Poltawski added a comment - Thanks Raj, i've integrated this now.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            This looks great.

            Thanks Raj.

            Test passed.

            Show
            rwijaya Rossiani Wijaya added a comment - This looks great. Thanks Raj. Test passed.
            Hide
            nebgor Aparup Banerjee added a comment -

            yay, it works!

            This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

            Thank you all for taking the time to get us here.

            cheers!

            Show
            nebgor Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/12