Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32946

Controls to edit blocks do not have accessible image alts

    XMLWordPrintable

    Details

    • Database:
      Any
    • Testing Instructions:
      Hide
      1. Turn editing on for blocks
      2. Create a HTML block with quotes and double quotes in the title
      3. Hover over the Dock icon on the block, ensure the block's name is mentioned in the tool tip
      4. Turn editing on for blocks
      5. Hover over the Dock icon on the HTML block, ensure the block's name is mentioned in the tool tip
      Show
      Turn editing on for blocks Create a HTML block with quotes and double quotes in the title Hover over the Dock icon on the block, ensure the block's name is mentioned in the tool tip Turn editing on for blocks Hover over the Dock icon on the HTML block, ensure the block's name is mentioned in the tool tip
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-32946-master

      Description

      Funcion edit_controls on blocklib.php prints control images that have the same alternative text to each block.

      Example:

      $controls[] = array('url' => $actionurl . '&bui_moveid=' . $block->instance->id,
                           'icon' => 't/move', 'caption' => get_string('move'));
      

      caption "get_string('move')" is the same to each block and is not accessible to be used.

      The solution is to add contextual information to each control this way screen readers can differentiate each control:

          get_string('moveblock','',$block->title)
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              phalacee Jason Fowler
              Reporter:
              pferre22 Pau Ferrer
              Peer reviewer:
              Andrew Davis Andrew Davis
              Integrator:
              Damyon Wiese Damyon Wiese
              Tester:
              Dan Poltawski Dan Poltawski
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13