Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide

      Follow part of the testing instructions from MDL-27322:

      Set debug level to developer.

      You'll need two students enrolled in a course and at least one gradable activity. The 2 (or more) students and the 1 (or more) activities must have an ID number set. You can set one on the activity settings and the user's profile.

      Go to the enrolment screen, edit one of the student's enrolments and suspend it. You want 1 suspended student and 1 active student.

      Grade the students on the activity.

      Perform exports in each format (txt, odf, xml and xls).

      No notices should appear either in the file or on the screen during the export process, and the export should contain the appropriate fields/values.

      Show
      Follow part of the testing instructions from MDL-27322 : Set debug level to developer. You'll need two students enrolled in a course and at least one gradable activity. The 2 (or more) students and the 1 (or more) activities must have an ID number set. You can set one on the activity settings and the user's profile. Go to the enrolment screen, edit one of the student's enrolments and suspend it. You want 1 suspended student and 1 active student. Grade the students on the activity. Perform exports in each format (txt, odf, xml and xls). No notices should appear either in the file or on the screen during the export process, and the export should contain the appropriate fields/values.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32978-master-integration

      Description

      In the gradebook.

      The 'Plain text file' export outputs the following notice:

      Strict Standards: Redefining already defined constructor for class grade_export_txt in /home/fred/www/repositories/testing_master/moodle/grade/export/txt/grade_export_txt.php on line 31

      All exports output the following notice:

      Strict Standards: Creating default object from empty value in /home/fred/www/repositories/testing_master/moodle/grade/lib.php on line 222

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            fred Frédéric Massart added a comment -

            Here is a patch that fixes it.

            Show
            fred Frédéric Massart added a comment - Here is a patch that fixes it.
            Hide
            andyjdavis Andrew Davis added a comment -

            Hello Frederic. Given that you've already provided a viable solution and written the testing instructions I'm putting you down as the assignee for this and demoting myself to peer reviewer. I'll do a little more testing of your solution then put it up for integration.

            Show
            andyjdavis Andrew Davis added a comment - Hello Frederic. Given that you've already provided a viable solution and written the testing instructions I'm putting you down as the assignee for this and demoting myself to peer reviewer. I'll do a little more testing of your solution then put it up for integration.
            Hide
            andyjdavis Andrew Davis added a comment -

            Putting this up for integration.

            Show
            andyjdavis Andrew Davis added a comment - Putting this up for integration.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks Fred & Andrew - i've integrated this now.

            Show
            poltawski Dan Poltawski added a comment - Thanks Fred & Andrew - i've integrated this now.
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks Fred,

            No notice/error appeared, while exporting gradebook.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks Fred, No notice/error appeared, while exporting gradebook.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            U P S T R E A M I Z E D !

            Many thanks for the hard work, closing this as fixed.

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12