Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32981

Private files link should go straight to the editing screen.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2.4, 2.3
    • Component/s: Filepicker
    • Labels:
    • Testing Instructions:
      Hide

      1. Login as admin
      2. Choose a random page, add a 'My private files' block
      3. Click on the button 'Manage my private files' in the block
      4. Make sure that

      • The navigation has selected 'Navigation > Home > My profile > My private files'
      • The cancel button brings you back to the page you were on
      • Uploading a file and clicking 'Save changes' brings you back to the page you were on
      • The file has been uploaded

      5. Now click on 'My private files' from the navigation
      6. Make sure that:

      • The navigation has selected 'Navigation > Home > My profile > My private files'
      • There is no cancel button (because no referer was passed to the form)
      • Uploading a file and clicking 'Save changes' brings you back to that same page
      • The file has been uploaded

      7. Create an assignment 'Upload a single file' activity
      8. Login as an enrolled student
      9. Upload a file to that assignment
      10. Make sure that

      • The cancel button is present and brings you back to the assignment page
      • The file is uploaded successfully

      NB: The cancel button appears when a referer has been passed, so that we can redirect the user to the correct page (upon cancel or submit). When no referer is passed, we don't need a cancel button as we will stay on the same page. That was the behaviour expected for the 'My private files' page.

      Show
      1. Login as admin 2. Choose a random page, add a 'My private files' block 3. Click on the button 'Manage my private files' in the block 4. Make sure that The navigation has selected 'Navigation > Home > My profile > My private files' The cancel button brings you back to the page you were on Uploading a file and clicking 'Save changes' brings you back to the page you were on The file has been uploaded 5. Now click on 'My private files' from the navigation 6. Make sure that: The navigation has selected 'Navigation > Home > My profile > My private files' There is no cancel button (because no referer was passed to the form) Uploading a file and clicking 'Save changes' brings you back to that same page The file has been uploaded 7. Create an assignment 'Upload a single file' activity 8. Login as an enrolled student 9. Upload a file to that assignment 10. Make sure that The cancel button is present and brings you back to the assignment page The file is uploaded successfully NB: The cancel button appears when a referer has been passed, so that we can redirect the user to the correct page (upon cancel or submit). When no referer is passed, we don't need a cancel button as we will stay on the same page. That was the behaviour expected for the 'My private files' page.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
      git@github.com:FMCorz/moodle.git
    • Pull Master Branch:
      MDL-32981-master

      Description

      Following up from MDL-23920 (1) the link in navigation to Private files should go straight to the "editing" screen with the filemanager. There is no point in forcing people to hit the "Manage files" button.

      After saving changes, we can still go to "view" screen I guess. I can't think of a better place to go - we can't stay in the editing screen.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12