Moodle

META: Files UI Stage 2 polishing in master

Details

Description

This META bug collects all the tasks for polishing the Files UI (including External files) after it landed in master from https://github.com/marinaglancy/moodle/tree/wip-files23

All of these will be marked MUST_FIX_FOR_2.3

Issue Links

has been marked as being related by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33032 META: Files UI Stage 1 integrate branch into core

  • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

New Feature - A new Moodle feature which has yet to be developed. MDL-30245 Core file hook to support extra metadata to be added with each file

  • Minor - Minor loss of function where workaround is possible
  • Reopened - This issue was once resolved, but the resolution was deemed incorrect. From here issues are either marked assigned or resolved.

Improvement - An enhancement to an existing Moodle feature. MDL-31907 META: File Usability 2.3

  • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
will help resolve

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-32117 Adding Equella repository to moodle core

  • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
Progress
Resolved Sub-Tasks

Sub-Tasks

1.
 New large file icons are not showing up filemanager or filepicker Sub-task Closed Closed Marina Glancy
 
2.
 Remove CSS arrow animation and replace with a simple subtle animated gif Sub-task Closed Closed Barbara Ramiro
 
3.
 Creating a folder needs more cues in buttons Sub-task Closed Closed Marina Glancy
 
4.
 Mouseover folder breadcrumbs in File Manager form element doesn't render hand cursor Sub-task Closed Closed Marina Glancy
 
5.
 Dragging a file into filemanager does not set Author field to current user Sub-task Closed Closed Marina Glancy
 
6.
 In Opera the arrow animation in the file manager area is broken and in the wrong place Sub-task Closed Closed Barbara Ramiro
 
7.
 Drag/dropping a file with the same name should allow you to replace a file in filemanager Sub-task Closed Closed Davo Smith
 
8.
 Filemanager: Changing sortorder will lose image thumbnails (the icons become generic again) Sub-task Closed Closed Marina Glancy
 
9.
 Some extensions display the wrong icons in file manager Sub-task Closed Closed Marina Glancy
 
10.
 Need transaction support for some files operations Sub-task Closed Closed Dongsheng Cai
 
11.
 Investigate oddness of class cache_file Sub-task Closed Closed Dan Poltawski
 
12.
 stored_file::$repository is public Sub-task Closed Closed Dongsheng Cai
 
13.
 Filemanager: The icons in the tool bar are not well spaced Sub-task Closed Closed Barbara Ramiro
 
14.
 Move submit buttons more towards the center of the page (not hard left) Sub-task Closed Closed Adrian Greeve
 
15.
 Rename submit button to "Save changes" in Folder resource Sub-task Closed Closed Frédéric Massart
 
16.
 Clicking navigation for any repo causes a sesskey error Sub-task Closed Closed Dongsheng Cai
 
17.
 16px icons need some custom love to make them fit better with others Sub-task Closed Closed Barbara Ramiro
 
18.
 HTML editor needs to be taught about web images! Sub-task Closed Closed Marina Glancy
 
19.
 Missing mimetype groupings Sub-task Closed Closed Marina Glancy
 
20.
 Notes from Sam H's review of mimetype changes Sub-task Closed Closed Marina Glancy
 
21.
 Adding two files from different sources to a filearea can get them confused Sub-task Closed Closed Dongsheng Cai
 
22.
 With 24px icons, the icon and text in table and tree views doesn't line up well Sub-task Closed Closed Barbara Ramiro
 
23.
 Filepicker window header looks horrible in IE9 Sub-task Closed Closed Barbara Ramiro
 
24.
 Files API now breaking on oracle Sub-task Closed Closed Dan Poltawski
 
25.
 Filemanager: The "drop" icon should be clickable (equivalent to clicking 'Add...') Sub-task Closed Closed Dan Poltawski
 
26.
 Restore causing notices related to external content Sub-task Closed Closed Dongsheng Cai
 
27.
 Filemanager: Broken upload for user picture on edit profile page Sub-task Closed Closed Barbara Ramiro
 
28.
 Filemanager: string needs fixing "No files attached - drag and drop files here to upload them" Sub-task Closed Closed Frédéric Massart
 
29.
 Update repositories API documentation with new features Sub-task Closed Closed Marina Glancy
 
30.
 Filepicker repositories look different in IE Sub-task Closed Closed Barbara Ramiro
 
31.
 Image previews get lost in tree view, some folder icons are missing Sub-task Closed Closed Marina Glancy
 
32.
 When in "edit" filemanager for standard folder activity, should not see "Set main file" button. Sub-task Closed Closed Ankit Agarwal
 
33.
 File upload UI does not load on Group Edit Settings page Sub-task Closed Closed Frédéric Massart
 
34.
 Filepicker form element should not allow inserting references Sub-task Closed Closed Marina Glancy
 
35.
 We might need a hash field for files_reference.reference Sub-task Closed Closed David Mudrak
 
36.
 File Manager drag and drop arrow out of alignment in some places Sub-task Closed Closed Marina Glancy
 
37.
 GIFT import file is not recognized when comments are used Sub-task Closed Closed Marina Glancy
 
38.
 Attempt Quiz or Re-attempt Quiz button triggers fatal error Sub-task Closed Closed Marina Glancy
 
39.
 when downloading file that is a reference it is saved under the original name Sub-task Closed Closed Frédéric Massart
 
40.
 Do not allow user to create a link to a course file Sub-task Closed Closed Marina Glancy
 
41.
 Tiff thumbnails result in broken images Sub-task Closed Closed David Mudrak
 
42.
 Polish icons for filetypes Sub-task Closed Closed Barbara Ramiro
 
43.
 Improve the alert code in dndupload.js to use yui instead Sub-task Closed Closed Marina Glancy
 
44.
 Newly copied files should take on the userid of the current user, and dates reset Sub-task Closed Closed Marina Glancy
 
45.
 Show reference/source icons in filepicker Sub-task Closed Closed Marina Glancy
 
46.
 Display reference/source icons in list and table view in filemanager Sub-task Closed Closed Barbara Ramiro
 
47.
 Enable references in Server files repository Sub-task Closed Closed Marina Glancy
 
48.
 Filepicker/filemanager: Add a small delay to the start of AJAX loading animations when navigating folders Sub-task Closed Closed Sam Hemelryk
 
49.
 Replace filepicker form element with filemanager in Edit user profile form Sub-task Closed Closed Rajesh Taneja
 
50.
 filetype cannot be accepted Sub-task Closed Closed Marina Glancy
 
51.
 Inserting a file by reference bypasses the file size limit check Sub-task Closed Closed Marina Glancy
 
52.
 Consistency in allowing references in filemanagers across site Sub-task Closed Closed Marina Glancy
 
53.
 It must not possible to create an alias to another alias Sub-task Closed Closed Marina Glancy
 
54.
 The search box text should be selected automatically Sub-task Closed Closed Rajesh Taneja
 
55.
 files->source field is not consistently set Sub-task Closed Closed Dongsheng Cai
 
56.
 Do not use cookies in filepicker and filemanager Sub-task Closed Closed Dan Poltawski
 
57.
 Couple small touches for filepicker/filemanager design Sub-task Closed Closed Barbara Ramiro
 
58.
 Correctly process situation when file reference source is missing Sub-task Closed Closed Marina Glancy
 
59.
 File picker doesn't display some recently uploaded files as a student. Sub-task Closed Closed Adrian Greeve
 
60.
 "set as main file" option can be used when not allowed Sub-task Closed Closed Frédéric Massart
 
61.
 No unzip option in file picker Sub-task Closed Closed Marina Glancy
 
62.
 mod/folder/view.php needs to show icons and look nice Sub-task Closed Closed Marina Glancy
 
63.
 Folder edit page looks real cramped on some themes Sub-task Closed Closed Martin Dougiamas
 

Issues in Epic

MDL-33741 Teacher can't access course files in hidden categories using the Filepicker with the server files repository Bug Open Marina Glancy
Actions
MDL-33012 Clicking a file in filemanager to see file info should highlight the file Improvement Open Unassigned
Actions
MDL-33124 The filemangager doesn't update after a file is not dropped on window Bug Open Unassigned
Actions
MDL-33303 Wishlist: Filemanager width should match tinymce editor width Improvement Reopened Sam Hemelryk
Actions
MDL-33644 File reference: when a referenced image from filesystem repo is updated, the thumbnail is not Bug Open Unassigned
Actions
MDL-33840 Filepicker should be resizeable and the proportions saved as a user preference Improvement Open Barbara Ramiro
Actions

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dongsheng Cai added a comment - - edited

Marina, can you integrate this: 423dd5b it fixed the mimetype detection issue we discussed this morning, it turned out we should use get_content_file_location, it tried to update file_record, it's dangerous, see this issue: MDL-33127

Show
Dongsheng Cai added a comment - - edited Marina, can you integrate this: 423dd5b it fixed the mimetype detection issue we discussed this morning, it turned out we should use get_content_file_location, it tried to update file_record, it's dangerous, see this issue: MDL-33127
Hide
Permalink
Dongsheng Cai added a comment -

Also, are we going to integrate Mark's patch (MDL-30245), it added ability to create copyright form in filepicker.

Show
Dongsheng Cai added a comment - Also, are we going to integrate Mark's patch ( MDL-30245 ), it added ability to create copyright form in filepicker.
Hide
Permalink
Marina Glancy added a comment -

Dongsheng, the 423dd5b was already picked in wip-files23, so it was integrated.
MDL-30245 did not pass my code review

Show
Marina Glancy added a comment - Dongsheng, the 423dd5b was already picked in wip-files23, so it was integrated. MDL-30245 did not pass my code review
Hide
Permalink
Marina Glancy added a comment -

I created a branch wip-files23-fixes but it will be probably not needed after wip-files23 is integrated

Show
Marina Glancy added a comment - I created a branch wip-files23-fixes but it will be probably not needed after wip-files23 is integrated
Hide
Permalink
Dongsheng Cai added a comment -

MDL-33149, I changed stored_file::repository to private

Show
Dongsheng Cai added a comment - MDL-33149 , I changed stored_ file::repository to private
Hide
Permalink
Dan Poltawski added a comment -

Please, send fixes for integration one by one, we will then try and get them integrated quickly

Show
Dan Poltawski added a comment - Please, send fixes for integration one by one, we will then try and get them integrated quickly
Hide
Permalink
Dongsheng Cai added a comment -

Dan

How to do that? I only leave comment in my issue not here?

Show
Dongsheng Cai added a comment - Dan How to do that? I only leave comment in my issue not here?
Hide
Permalink
Dan Poltawski added a comment -

Create a branch for each fix and submit for integration

Show
Dan Poltawski added a comment - Create a branch for each fix and submit for integration
Hide
Permalink
Dongsheng Cai added a comment -

Linked MDL-32117 EQUELLA repository to this issue, EQUELLA is the only embedded repository we supported at the moment.

Show
Dongsheng Cai added a comment - Linked MDL-32117 EQUELLA repository to this issue, EQUELLA is the only embedded repository we supported at the moment.
Hide
Permalink
Dan Poltawski added a comment -

Removing the MUSTFIXFOR2.3 fix version since we have narrowed down the ones which need to be fixed in subtasks.

Show
Dan Poltawski added a comment - Removing the MUSTFIXFOR2.3 fix version since we have narrowed down the ones which need to be fixed in subtasks.
Hide
Permalink
Dan Poltawski added a comment -

Can this meta issue be closed and open issues converted into real issues?

Show
Dan Poltawski added a comment - Can this meta issue be closed and open issues converted into real issues?
Hide
Permalink
Michael de Raadt added a comment -

I've converted this issue into an Epic and the remaining open issues into stand-alone issues so we can work on them in upcoming sprints.

Show
Michael de Raadt added a comment - I've converted this issue into an Epic and the remaining open issues into stand-alone issues so we can work on them in upcoming sprints.
Hide
Permalink
Marina Glancy added a comment -

closing because all subtasks are closed.

Show
Marina Glancy added a comment - closing because all subtasks are closed.

People

Vote (0)
Watch (12)

Dates

  • Created:
    Updated:
    Resolved: