[MDL-32999] META: Files UI Stage 2 polishing in master - Moodle Tracker

Details

Type: Epic
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 2.3
Fix Version/s: FRONTEND, BACKEND
Component/s: Filepicker, Files API, Repositories
Labels:
- triaged

Affected Branches:
MOODLE_23_STABLE
Epic Name:
Filepicker UI Polishing
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Master Branch:
wip-files23-fixes
Pull Master Diff URL:
https://github.com/marinaglancy/moodle/compare/wip-files23...wip-files23-fixes

Rank:
40174

Description

This META bug collects all the tasks for polishing the Files UI (including External files) after it landed in master from https://github.com/marinaglancy/moodle/tree/wip-files23

All of these will be marked MUST_FIX_FOR_2.3

Issue Links

has been marked as being related by

MDL-33032 META: Files UI Stage 1 integrate branch into core

Closed

MDL-30245 Core file hook to support extra metadata to be added with each file

Reopened

MDL-31907 META: File Usability 2.3

Closed

will help resolve

MDL-32117 Adding Equella repository to moodle core

Closed

Options
- Show All
- Show Open

Progress

Sub-Tasks

1.	New large file icons are not showing up filemanager or filepicker	Closed	Marina Glancy
2.	Remove CSS arrow animation and replace with a simple subtle animated gif	Closed	Barbara Ramiro
3.	Creating a folder needs more cues in buttons	Closed	Marina Glancy
4.	Mouseover folder breadcrumbs in File Manager form element doesn't render hand cursor	Closed	Marina Glancy
5.	Dragging a file into filemanager does not set Author field to current user	Closed	Marina Glancy
6.	In Opera the arrow animation in the file manager area is broken and in the wrong place	Closed	Barbara Ramiro
7.	Drag/dropping a file with the same name should allow you to replace a file in filemanager	Closed	Davo Smith
8.	Filemanager: Changing sortorder will lose image thumbnails (the icons become generic again)	Closed	Marina Glancy
9.	Some extensions display the wrong icons in file manager	Closed	Marina Glancy
10.	Need transaction support for some files operations	Closed	Dongsheng Cai
11.	Investigate oddness of class cache_file	Closed	Dan Poltawski
12.	stored_file::$repository is public	Closed	Dongsheng Cai
13.	Filemanager: The icons in the tool bar are not well spaced	Closed	Barbara Ramiro
14.	Move submit buttons more towards the center of the page (not hard left)	Closed	Adrian Greeve
15.	Rename submit button to "Save changes" in Folder resource	Closed	Frédéric Massart
16.	Clicking navigation for any repo causes a sesskey error	Closed	Dongsheng Cai
17.	16px icons need some custom love to make them fit better with others	Closed	Barbara Ramiro
18.	HTML editor needs to be taught about web images!	Closed	Marina Glancy
19.	Missing mimetype groupings	Closed	Marina Glancy
20.	Notes from Sam H's review of mimetype changes	Closed	Marina Glancy
21.	Adding two files from different sources to a filearea can get them confused	Closed	Dongsheng Cai
22.	With 24px icons, the icon and text in table and tree views doesn't line up well	Closed	Barbara Ramiro
23.	Filepicker window header looks horrible in IE9	Closed	Barbara Ramiro
24.	Files API now breaking on oracle	Closed	Dan Poltawski
25.	Filemanager: The "drop" icon should be clickable (equivalent to clicking 'Add...')	Closed	Dan Poltawski
26.	Restore causing notices related to external content	Closed	Dongsheng Cai
27.	Filemanager: Broken upload for user picture on edit profile page	Closed	Barbara Ramiro
28.	Filemanager: string needs fixing "No files attached - drag and drop files here to upload them"	Closed	Frédéric Massart
29.	Update repositories API documentation with new features	Closed	Marina Glancy
30.	Filepicker repositories look different in IE	Closed	Barbara Ramiro
31.	Image previews get lost in tree view, some folder icons are missing	Closed	Marina Glancy
32.	When in "edit" filemanager for standard folder activity, should not see "Set main file" button.	Closed	Ankit Agarwal
33.	File upload UI does not load on Group Edit Settings page	Closed	Frédéric Massart
34.	Filepicker form element should not allow inserting references	Closed	Marina Glancy
35.	We might need a hash field for files_reference.reference	Closed	David Mudrak
36.	File Manager drag and drop arrow out of alignment in some places	Closed	Marina Glancy
37.	GIFT import file is not recognized when comments are used	Closed	Marina Glancy
38.	Attempt Quiz or Re-attempt Quiz button triggers fatal error	Closed	Marina Glancy
39.	when downloading file that is a reference it is saved under the original name	Closed	Frédéric Massart
40.	Do not allow user to create a link to a course file	Closed	Marina Glancy
41.	Tiff thumbnails result in broken images	Closed	David Mudrak
42.	Polish icons for filetypes	Closed	Barbara Ramiro
43.	Improve the alert code in dndupload.js to use yui instead	Closed	Marina Glancy
44.	Newly copied files should take on the userid of the current user, and dates reset	Closed	Marina Glancy
45.	Show reference/source icons in filepicker	Closed	Marina Glancy
46.	Display reference/source icons in list and table view in filemanager	Closed	Barbara Ramiro
47.	Enable references in Server files repository	Closed	Marina Glancy
48.	Filepicker/filemanager: Add a small delay to the start of AJAX loading animations when navigating folders	Closed	Sam Hemelryk
49.	Replace filepicker form element with filemanager in Edit user profile form	Closed	Rajesh Taneja
50.	filetype cannot be accepted	Closed	Marina Glancy
51.	Inserting a file by reference bypasses the file size limit check	Closed	Marina Glancy
52.	Consistency in allowing references in filemanagers across site	Closed	Marina Glancy
53.	It must not possible to create an alias to another alias	Closed	Marina Glancy
54.	The search box text should be selected automatically	Closed	Rajesh Taneja
55.	files->source field is not consistently set	Closed	Dongsheng Cai
56.	Do not use cookies in filepicker and filemanager	Closed	Dan Poltawski
57.	Couple small touches for filepicker/filemanager design	Closed	Barbara Ramiro
58.	Correctly process situation when file reference source is missing	Closed	Marina Glancy
59.	File picker doesn't display some recently uploaded files as a student.	Closed	Adrian Greeve
60.	"set as main file" option can be used when not allowed	Closed	Frédéric Massart
61.	No unzip option in file picker	Closed	Marina Glancy
62.	mod/folder/view.php needs to show icons and look nice	Closed	Marina Glancy
63.	Folder edit page looks real cramped on some themes	Closed	Martin Dougiamas

Issues in Epic

MDL-33741	Teacher can't access course files in hidden categories using the Filepicker with the server files repository	Open	Marina Glancy	Actions
MDL-33012	Clicking a file in filemanager to see file info should highlight the file	Open	Unassigned	Actions
MDL-33124	The filemangager doesn't update after a file is not dropped on window	Open	Unassigned	Actions
MDL-33303	Wishlist: Filemanager width should match tinymce editor width	Reopened	Sam Hemelryk	Actions
MDL-33644	File reference: when a referenced image from filesystem repo is updated, the thumbnail is not	Open	Unassigned	Actions
MDL-33840	Filepicker should be resizeable and the proportions saved as a user preference	Open	Barbara Ramiro	Actions

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Dongsheng Cai added a comment - 21/May/12 4:24 PM - edited

Marina, can you integrate this: 423dd5b it fixed the mimetype detection issue we discussed this morning, it turned out we should use get_content_file_location, it tried to update file_record, it's dangerous, see this issue: ~~MDL-33127~~

Show

Dongsheng Cai added a comment - 21/May/12 4:24 PM - edited Marina, can you integrate this: 423dd5b it fixed the mimetype detection issue we discussed this morning, it turned out we should use get_content_file_location, it tried to update file_record, it's dangerous, see this issue: MDL-33127

Hide

Permalink

Dongsheng Cai added a comment - 21/May/12 4:30 PM

Also, are we going to integrate Mark's patch (MDL-30245), it added ability to create copyright form in filepicker.

Show

Dongsheng Cai added a comment - 21/May/12 4:30 PM Also, are we going to integrate Mark's patch ( MDL-30245 ), it added ability to create copyright form in filepicker.

Hide

Permalink

Marina Glancy added a comment - 22/May/12 10:06 AM

Dongsheng, the 423dd5b was already picked in wip-files23, so it was integrated.
MDL-30245 did not pass my code review

Show

Marina Glancy added a comment - 22/May/12 10:06 AM Dongsheng, the 423dd5b was already picked in wip-files23, so it was integrated. MDL-30245 did not pass my code review

Hide

Permalink

Marina Glancy added a comment - 22/May/12 10:10 AM

I created a branch wip-files23-fixes but it will be probably not needed after wip-files23 is integrated

Show

Marina Glancy added a comment - 22/May/12 10:10 AM I created a branch wip-files23-fixes but it will be probably not needed after wip-files23 is integrated

Hide

Permalink

Dongsheng Cai added a comment - 22/May/12 10:56 AM

~~MDL-33149~~, I changed stored_file::repository to private

Show

Dongsheng Cai added a comment - 22/May/12 10:56 AM MDL-33149 , I changed stored_ file::repository to private

Hide

Permalink

Dan Poltawski added a comment - 22/May/12 11:05 AM

Please, send fixes for integration one by one, we will then try and get them integrated quickly

Show

Dan Poltawski added a comment - 22/May/12 11:05 AM Please, send fixes for integration one by one, we will then try and get them integrated quickly

Hide

Permalink

Dongsheng Cai added a comment - 22/May/12 11:13 AM

Dan

How to do that? I only leave comment in my issue not here?

Show

Dongsheng Cai added a comment - 22/May/12 11:13 AM Dan How to do that? I only leave comment in my issue not here?

Hide

Permalink

Dan Poltawski added a comment - 22/May/12 11:25 AM

Create a branch for each fix and submit for integration

Show

Dan Poltawski added a comment - 22/May/12 11:25 AM Create a branch for each fix and submit for integration

Hide

Permalink

Dongsheng Cai added a comment - 23/May/12 5:13 PM

Linked ~~MDL-32117~~ EQUELLA repository to this issue, EQUELLA is the only embedded repository we supported at the moment.

Show

Dongsheng Cai added a comment - 23/May/12 5:13 PM Linked MDL-32117 EQUELLA repository to this issue, EQUELLA is the only embedded repository we supported at the moment.

Hide

Permalink

Dan Poltawski added a comment - 20/Jun/12 3:00 PM

Removing the MUSTFIXFOR2.3 fix version since we have narrowed down the ones which need to be fixed in subtasks.

Show

Dan Poltawski added a comment - 20/Jun/12 3:00 PM Removing the MUSTFIXFOR2.3 fix version since we have narrowed down the ones which need to be fixed in subtasks.

Hide

Permalink

Dan Poltawski added a comment - 27/Jun/12 4:23 PM

Can this meta issue be closed and open issues converted into real issues?

Show

Dan Poltawski added a comment - 27/Jun/12 4:23 PM Can this meta issue be closed and open issues converted into real issues?

Hide

Permalink

Michael de Raadt added a comment - 27/Jun/13 3:30 AM

I've converted this issue into an Epic and the remaining open issues into stand-alone issues so we can work on them in upcoming sprints.

Show

Michael de Raadt added a comment - 27/Jun/13 3:30 AM I've converted this issue into an Epic and the remaining open issues into stand-alone issues so we can work on them in upcoming sprints.

Hide

Permalink

Marina Glancy added a comment - 22/Nov/13 3:27 AM

closing because all subtasks are closed.

Show

Marina Glancy added a comment - 22/Nov/13 3:27 AM closing because all subtasks are closed.

People

Assignee:

Marina Glancy

Reporter:

Martin Dougiamas

Participants:

Dan Poltawski, Dongsheng Cai, Marina Glancy, Martin Dougiamas, Michael de Raadt

Votes:

0 Vote for this issue

Watchers:

12 Start watching this issue

Dates

Created:

15/May/12 3:42 PM

Updated:

22/Nov/13 3:27 AM

Resolved:

22/Nov/13 3:27 AM

Agile

View on Board