Moodle
  1. Moodle
  2. MDL-33013

Navigation block 'categories and courses' setting does not behave as expected

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.1, 2.3.4, 2.4.1, 2.5
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Blocks, Navigation
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as an admin
      2. Turn on editing
      3. Change the navigation block settings to generate only courses/categories.
      4. Browse to a course and check you only see the course + participants + reports in the nav.
      5. Browse to an activity and check you see the course, the section containing the activity and the activity itself. No other sections/activities.
      6. Edit your course settings to show single sections.
      7. Browse to a section and check you see it under the course in the navigation.
      Show
      Log in as an admin Turn on editing Change the navigation block settings to generate only courses/categories. Browse to a course and check you only see the course + participants + reports in the nav. Browse to an activity and check you see the course, the section containing the activity and the activity itself. No other sections/activities. Edit your course settings to show single sections. Browse to a section and check you see it under the course in the navigation.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull 2.4 Branch:
      wip-MDL-33013-m24
    • Pull Master Branch:
      wip-MDL-33013-m25
    • Rank:
      40188

      Description

      When the Navigation block is configured, there is a setting "Generate navigation for the following". If this is set to "Categories and courses", the behaviour is not what one might expect. When an activity is opened, the navigation block then shows all other activities in that section. Similarly, when a single section is displayed by clicking the "Show only topic n" button, all of the activities for that section are listed in the Navigation block.

      The same is not true, in either case, when the setting is changed to "Categories and courses and course structures".

      Steps to reproduce
      ==================
      1. As admin, edit configuration of Navigation block and set "Generate navigation for the following". to "Categories and courses".
      2. As student, visit the same course and click on any activity. Observe contents of Navigation block (A).
      3. As student, click the "Show only this topic" button for any section. Observe contents of Navigation block (B).

      Expected behaviour
      ==================

      A. Navigation block should only show entries for the course, the section for the current activity, and the activity itself.
      B. Navigation block should only the course.

      Actual behaviour
      ==================

      A. Navigation block shows entries for the course, the section for the current activity, and all other activities in that section.
      B. Navigation block shows the course, the current section, and all activities in that section.

        Activity

        Hide
        Andrea Gregory (Gordon) added a comment -

        Any joy with this one?

        I have found this to be happening on 2.2.4. It works fine for the front page and courses but if the block is on a 'Page' Module for instance, it has this behaviour... it is set to only show courses and categories but shows topics etc also.

        Thanks

        Andrea

        Show
        Andrea Gregory (Gordon) added a comment - Any joy with this one? I have found this to be happening on 2.2.4. It works fine for the front page and courses but if the block is on a 'Page' Module for instance, it has this behaviour... it is set to only show courses and categories but shows topics etc also. Thanks Andrea
        Hide
        Sam Hemelryk added a comment -

        Thanks for reporting this Steve.

        Show
        Sam Hemelryk added a comment - Thanks for reporting this Steve.
        Hide
        Sam Hemelryk added a comment -

        Putting a solution up for peer-review now.

        Show
        Sam Hemelryk added a comment - Putting a solution up for peer-review now.
        Hide
        Sam Hemelryk added a comment -

        Submitting straight for integration review in order to try and catch upcoming releases.

        Show
        Sam Hemelryk added a comment - Submitting straight for integration review in order to try and catch upcoming releases.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (23, 24 & master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks!
        Hide
        Ankit Agarwal added a comment -

        There is no "reports" option in master under course, works as described on 2.3 and 2.4. I assume that is expected looking at MDL-31983.

        Passing thanks.

        Show
        Ankit Agarwal added a comment - There is no "reports" option in master under course, works as described on 2.3 and 2.4. I assume that is expected looking at MDL-31983 . Passing thanks.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.

        Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).

        Thanks, closing as fixed!

        Show
        Eloy Lafuente (stronk7) added a comment - This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities. Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied). Thanks, closing as fixed!

          People

          • Votes:
            8 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: