Moodle
  1. Moodle
  2. MDL-33015

for now revert formslib action default back to current url derived from FULLME

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Forms Library
    • Labels:

      Description

      The problem is in admin pages that abuse ext page id of other forms such as /admin/repositoryinstances.php which has PAGE->url pointing to admin/repository.php - I guess it would not be practical to forbid this common (but still incorrect) practice right now.

      function admin_externalpage_setup($section, $extrabutton = '', array $extraurlparams = null, $actualurl = '', array $options = array()) {

      The proper solution is to properly specify $actualurl in admin/repositoryinstances.php...

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Marina Glancy added a comment -

            FYI: those commits are also picked in branch https://github.com/marinaglancy/moodle/tree/wip-files23 (MDL-31901, MDL-28666, etc)

            Show
            Marina Glancy added a comment - FYI: those commits are also picked in branch https://github.com/marinaglancy/moodle/tree/wip-files23 ( MDL-31901 , MDL-28666 , etc)
            Hide
            Dan Poltawski added a comment -

            I'm taking this issue - and holding it so I can work it out with the files ui branch landing.

            Show
            Dan Poltawski added a comment - I'm taking this issue - and holding it so I can work it out with the files ui branch landing.
            Hide
            Dan Poltawski added a comment -

            Taking this out of integration, to land along with wip-files branch to avoid collisons

            Show
            Dan Poltawski added a comment - Taking this out of integration, to land along with wip-files branch to avoid collisons
            Hide
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Dan Poltawski added a comment -

            This was integrated with the files-23 branch

            Show
            Dan Poltawski added a comment - This was integrated with the files-23 branch
            Hide
            Dan Poltawski added a comment -

            I'm passing this, althouhf found another major bug whilst testing..

            Thanks Petr

            Show
            Dan Poltawski added a comment - I'm passing this, althouhf found another major bug whilst testing.. Thanks Petr
            Hide
            Eloy Lafuente (stronk7) added a comment -

            This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

            Thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: