Moodle
  1. Moodle
  2. MDL-33025

Clicking in an AJAX title/name change text box sometimes results in a popup being displayed.

    Details

    • Testing Instructions:
      Hide

      Note This does not allow you to change the text of a label - these contain HTML so I'd say they're beyond scope

      With a course in editing mode

      • Ensure that the icon placeholder is added. It should appear to the left of the 'Move Left' or 'Move Right' icon.
      • Click on the icon - an editor form should replace the link asking for the new title and showing instructions
      • Type in a new title
      • Press Escape
      • Confirm that
        • the editor has been replaced with the link
        • the title has not changed
      • Click on the icon again
      • Type in a new title
      • Click elsewhere on the pgae
      • Confirm that
        • the editor has been replaced with the link
        • the title has not changed
      • Click on the icon again
      • Type in a new title
      • Press return
      • Confirm that
        • the editor has been replaced with the link
        • the title has been updated
      • Create a new URL resource which pops-up in a new window
      • Click on it's edit icon
      • Click within the text-box area
        • Confirm that the popup isn't opened
      • Save the title
        • Confirm that clicking the title now opens the URL in a popup
      Show
      Note This does not allow you to change the text of a label - these contain HTML so I'd say they're beyond scope With a course in editing mode Ensure that the icon placeholder is added. It should appear to the left of the 'Move Left' or 'Move Right' icon. Click on the icon - an editor form should replace the link asking for the new title and showing instructions Type in a new title Press Escape Confirm that the editor has been replaced with the link the title has not changed Click on the icon again Type in a new title Click elsewhere on the pgae Confirm that the editor has been replaced with the link the title has not changed Click on the icon again Type in a new title Press return Confirm that the editor has been replaced with the link the title has been updated Create a new URL resource which pops-up in a new window Click on it's edit icon Click within the text-box area Confirm that the popup isn't opened Save the title Confirm that clicking the title now opens the URL in a popup
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33025-master-1
    • Rank:
      40201

      Description

      If you have a resourse which is set to pop-up when clicked, and you use the AJAX title/name change ability, if you click on the text box to change the name / title, it will fire off the pop-up box.

        Issue Links

          Activity

          Hide
          Andrew Nicols added a comment -

          I've adjusted the code to replace the anchor with the edit form which means we no longer make changes to anchor properties (href) and ensures that the anchor onclick isn't triggered thus ensuring no popup.

          I've also added an additional keyup event handler bound to the escape key to cancel the editform. This doesn't adversely effect browsers where it already worked.

          Tested in:

          • IE9
          • Chrome Windows
          • Opera Windows
          • Chrome Linux
          • Chrome Mac
          • Safari Mac
          Show
          Andrew Nicols added a comment - I've adjusted the code to replace the anchor with the edit form which means we no longer make changes to anchor properties (href) and ensures that the anchor onclick isn't triggered thus ensuring no popup. I've also added an additional keyup event handler bound to the escape key to cancel the editform. This doesn't adversely effect browsers where it already worked. Tested in: IE9 Chrome Windows Opera Windows Chrome Linux Chrome Mac Safari Mac
          Hide
          Dan Poltawski added a comment -

          Thanks. i've integrated this

          Show
          Dan Poltawski added a comment - Thanks. i've integrated this
          Hide
          Andrew Davis added a comment -

          Seems to be working fine in master. Passing.

          Show
          Andrew Davis added a comment - Seems to be working fine in master. Passing.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          U P S T R E A M I Z E D !

          Many thanks for the hard work, closing this as fixed.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: