Moodle
  1. Moodle
  2. MDL-33045

Assign: grader email contains errors

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      Prerequisites:

      • A moodle with working outgoing email settings
      • Student/teacher accounts with valid email addresses OR $CFG->divertallemailsto = 'youremailaddress';
      1. As a teacher, create assignment, having enabled grader notifications.
      2. As a student, submit assignment for assessment.
      3. Check students email, they should recieve a submission reciept. The links in notification message should point to the existing location, also item path in the content should have all three elements, e.g. <course> -> Assignment -> <assignment name>
      4. Check teacher's email.The links in notification message should point to the existing location, also item path in the content should have all three elements, e.g. <course> -> Assignment -> <assignment name>.
      Show
      Prerequisites: A moodle with working outgoing email settings Student/teacher accounts with valid email addresses OR $CFG->divertallemailsto = 'youremailaddress'; As a teacher, create assignment, having enabled grader notifications. As a student, submit assignment for assessment. Check students email, they should recieve a submission reciept. The links in notification message should point to the existing location, also item path in the content should have all three elements, e.g. <course> -> Assignment -> <assignment name> Check teacher's email.The links in notification message should point to the existing location, also item path in the content should have all three elements, e.g. <course> -> Assignment -> <assignment name>.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33045-master-2

      Description

      1. $this->get_module_name() used in email content generation will never return anything
      2. $this->format_email_grader_html() contains reference to mod/assignment... links are broken

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Ruslan Kabalin added a comment -

            In fact, get_string is pretty cheap, for the case of simplicity may be we can get rid of get_module_name() and static properties altogether?

            Show
            Ruslan Kabalin added a comment - In fact, get_string is pretty cheap, for the case of simplicity may be we can get rid of get_module_name() and static properties altogether?
            Hide
            Michael de Raadt added a comment -

            Hi, Damyon.

            I thought you would be an appropriate peer reviewer for this issue. Please reassign if you can't do this.

            Show
            Michael de Raadt added a comment - Hi, Damyon. I thought you would be an appropriate peer reviewer for this issue. Please reassign if you can't do this.
            Hide
            Damyon Wiese added a comment -

            Hi Ruslan,

            The code looks fine - but unfortunately it conflicts with MDL-31414 as well so I'll mark it as dependant on that for now. Once that is integrated I'll need you to resolve the conflicts and resubmit this.

            Can you also add some quick testing instructions too?

            Thanks, Damyon

            Show
            Damyon Wiese added a comment - Hi Ruslan, The code looks fine - but unfortunately it conflicts with MDL-31414 as well so I'll mark it as dependant on that for now. Once that is integrated I'll need you to resolve the conflicts and resubmit this. Can you also add some quick testing instructions too? Thanks, Damyon
            Hide
            Damyon Wiese added a comment -

            Re: the static properties - they were requested (by Sam I think) when I submitted the mod_assign for review.

            Show
            Damyon Wiese added a comment - Re: the static properties - they were requested (by Sam I think) when I submitted the mod_assign for review.
            Hide
            Ruslan Kabalin added a comment -

            OK, I will keep an eye on MDL-31414 and resubmit this. Instruction is added.

            Show
            Ruslan Kabalin added a comment - OK, I will keep an eye on MDL-31414 and resubmit this. Instruction is added.
            Hide
            Dan Poltawski added a comment -

            MDL-31414 has been submitted if you can rebase on top of integration we can get this integrated asap

            Show
            Dan Poltawski added a comment - MDL-31414 has been submitted if you can rebase on top of integration we can get this integrated asap
            Hide
            Ruslan Kabalin added a comment -

            Ready for revision.

            Show
            Ruslan Kabalin added a comment - Ready for revision.
            Hide
            Dan Poltawski added a comment -

            I just encountered this myself, pulling into integration.

            Show
            Dan Poltawski added a comment - I just encountered this myself, pulling into integration.
            Hide
            Dan Poltawski added a comment -

            Thanks Ruslan/Damyon, i've intgerated this now.

            Show
            Dan Poltawski added a comment - Thanks Ruslan/Damyon, i've intgerated this now.
            Hide
            Dan Poltawski added a comment -

            Tested it while integrating.

            Show
            Dan Poltawski added a comment - Tested it while integrating.
            Hide
            Dan Poltawski added a comment -

            Congratulations!

            Your work has made into the latest Moodle release!

            You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

            Show
            Dan Poltawski added a comment - Congratulations! Your work has made into the latest Moodle release! You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: