Moodle
  1. Moodle
  2. MDL-33055

Formal White theme's standard theme layout is wrong in config.php

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.1.7, 2.2.4
    • Component/s: Themes
    • Labels:
    • Rank:
      40235

      Description

      In Formal White theme, under $THEME->LAYOUTS in config.php, the Standard theme layout is wrongly name 'general' whereas it should read 'standard'.

      You can check this against Base theme which reads:

      $THEME->layouts = array(
          // Standard layout with blocks, this is recommended for most pages with general information
          'standard' => array(
              'file' => 'general.php',
              'regions' => array('side-pre', 'side-post'),
              'defaultregion' => 'side-post',
          ),
      

      Whereas in Formal White it reads:

      $THEME->layouts = array(
          'general' => array(
              'file' => 'general.php',
              'regions' => array('side-pre', 'side-post'),
              'defaultregion' => 'side-post',
          ),
      

      Which is wrong. This can cause the header diplay to be lost in some pages.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          I've assinged this to this to Daniele as Formal White maintainer. I assume this is what you wanted, Mary.

          I'll leave you guys to work together on that.

          Thanks for your efforts.

          Show
          Michael de Raadt added a comment - I've assinged this to this to Daniele as Formal White maintainer. I assume this is what you wanted, Mary. I'll leave you guys to work together on that. Thanks for your efforts.
          Hide
          Daniele Cordella added a comment -

          Thank you very much!
          They were months I was looking for a strange weird issue that I was not able to understand.
          I strongly believe you found the solution.
          Let's go. I just modified my theme in my local installation. Now I test it within the next few days of use. Then, if all goes fine, I will post the related commit.
          Thanks again.

          Show
          Daniele Cordella added a comment - Thank you very much! They were months I was looking for a strange weird issue that I was not able to understand. I strongly believe you found the solution. Let's go. I just modified my theme in my local installation. Now I test it within the next few days of use. Then, if all goes fine, I will post the related commit. Thanks again.
          Hide
          Mary Evans added a comment - - edited

          @Michael

          That's exactly what I was going to do but forgot!

          @Daniele

          You are welcome, I was surprised to find it in your theme. I came across the problem last week when someone pointed it out in Aardvark Post-IT, and as Post-IT was built on Aardvark 2.1, and that theme was built on SimpleSpace the error has filtered through.

          In fact it is in SimpleSpace and also a couple of other themes John Stabinger added to the plugins database, so I better make John a watcher here so he is aware of the problem.

          Show
          Mary Evans added a comment - - edited @Michael That's exactly what I was going to do but forgot! @Daniele You are welcome, I was surprised to find it in your theme. I came across the problem last week when someone pointed it out in Aardvark Post-IT, and as Post-IT was built on Aardvark 2.1, and that theme was built on SimpleSpace the error has filtered through. In fact it is in SimpleSpace and also a couple of other themes John Stabinger added to the plugins database, so I better make John a watcher here so he is aware of the problem.
          Hide
          John Stabinger added a comment -

          I don't see it in any recent ones. Looks like just simplespace (which is very old) and maybe darkblue. Good find and I'll need to update those.

          Show
          John Stabinger added a comment - I don't see it in any recent ones. Looks like just simplespace (which is very old) and maybe darkblue. Good find and I'll need to update those.
          Hide
          Mary Evans added a comment - - edited

          @John
          I have added you as a watcher here to alert you to a recently discovered problem described in this tracker issue. It affects SimpleSpace and DarkB and also Accentuate, and can cause odd behaviour in a theme, especially when in calendar view.

          Cheers
          Mary

          Show
          Mary Evans added a comment - - edited @John I have added you as a watcher here to alert you to a recently discovered problem described in this tracker issue. It affects SimpleSpace and DarkB and also Accentuate, and can cause odd behaviour in a theme, especially when in calendar view. Cheers Mary
          Hide
          Mary Evans added a comment - - edited

          @Shaun

          I have just added you as a watcher in MDL-33055 as the problems described in this tracker issue relates to ALL your Moodle 2.x.x Aardvark themes.

          Cheers
          Mary

          Show
          Mary Evans added a comment - - edited @Shaun I have just added you as a watcher in MDL-33055 as the problems described in this tracker issue relates to ALL your Moodle 2.x.x Aardvark themes. Cheers Mary
          Hide
          Daniele Cordella added a comment -

          Mary, I made this change in my local instance of moodle head 3 days ago. I never had evidence of related problems. I deeply believe it is working fine.

          Show
          Daniele Cordella added a comment - Mary, I made this change in my local instance of moodle head 3 days ago. I never had evidence of related problems. I deeply believe it is working fine.
          Hide
          Mary Evans added a comment - - edited

          Daniele,
          I have changed this to TASK so the fix is just that, a task to edit the code in theme/formal_white/config.php

          As far as I am aware there is no such layout as GENERAL.

          No testing required.

          Thanks
          Mary

          Show
          Mary Evans added a comment - - edited Daniele, I have changed this to TASK so the fix is just that, a task to edit the code in theme/formal_white/config.php As far as I am aware there is no such layout as GENERAL. No testing required. Thanks Mary
          Hide
          Sam Hemelryk added a comment -

          Thanks Daniele, this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Daniele, this has been integrated now.
          Hide
          Sam Hemelryk added a comment -

          Tested during integration review

          Show
          Sam Hemelryk added a comment - Tested during integration review
          Hide
          Shaun Daubney added a comment -

          @Mary That will explain all these emails

          Show
          Shaun Daubney added a comment - @Mary That will explain all these emails
          Hide
          Shaun Daubney added a comment -

          Update mine on Github too. Will do a build at some point this week if I get chance.

          Show
          Shaun Daubney added a comment - Update mine on Github too. Will do a build at some point this week if I get chance.
          Hide
          Mary Evans added a comment -

          Great stuff Shaun,

          By the way, you might like to take a look at CONTRIB-3459 where I do my updates and amendments for Aardvark Post-IT. Have a word with Helen Foster who can set up a Project for Aardvark for you then you will (I think) be able to assign the CONTRIB to yourself then add your github link there.

          Thanks

          Mary

          Show
          Mary Evans added a comment - Great stuff Shaun, By the way, you might like to take a look at CONTRIB-3459 where I do my updates and amendments for Aardvark Post-IT. Have a word with Helen Foster who can set up a Project for Aardvark for you then you will (I think) be able to assign the CONTRIB to yourself then add your github link there. Thanks Mary
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

          Thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: