Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33074

Drag/Drop incorrectly displays the Change Group Mode for files

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Course, JavaScript
    • Labels:
      None

      Description

      If you drag/drop a file on a course, the Change Group Mode icon is shown, though not as a link. Upon refreshing the page, it disappears.

      Please note, I'm aware that the toolbox icons don't work with JS immediately and have submitted a fix in MDL-33073

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              dobedobedoh Andrew Nicols added a comment -

              Hi Davo,

              You're probably the best person to look into this.

              Show
              dobedobedoh Andrew Nicols added a comment - Hi Davo, You're probably the best person to look into this.
              Hide
              davosmith Davo Smith added a comment -

              The logic for the buttons made me scratch my head for a bit, but I think I understand it now and have got it fixed.

              Show
              davosmith Davo Smith added a comment - The logic for the buttons made me scratch my head for a bit, but I think I understand it now and have got it fixed.
              Hide
              ankit_frenz Ankit Agarwal added a comment -

              Changes looks good.
              tested the changes as well, works fine for me.
              Added the mdlqa tag as it was reported in one of failed QA as well.
              Sending this for integration.

              Thanks

              Show
              ankit_frenz Ankit Agarwal added a comment - Changes looks good. tested the changes as well, works fine for me. Added the mdlqa tag as it was reported in one of failed QA as well. Sending this for integration. Thanks
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks i've integrated this

              Show
              poltawski Dan Poltawski added a comment - Thanks i've integrated this
              Hide
              poltawski Dan Poltawski added a comment -

              Passing test as its to be testing in the QA test

              Show
              poltawski Dan Poltawski added a comment - Passing test as its to be testing in the QA test
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

              Thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12