Moodle
  1. Moodle
  2. MDL-33074

Drag/Drop incorrectly displays the Change Group Mode for files

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: AJAX and JavaScript, Course
    • Labels:
      None

      Description

      If you drag/drop a file on a course, the Change Group Mode icon is shown, though not as a link. Upon refreshing the page, it disappears.

      Please note, I'm aware that the toolbox icons don't work with JS immediately and have submitted a fix in MDL-33073

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Andrew Nicols added a comment -

            Hi Davo,

            You're probably the best person to look into this.

            Show
            Andrew Nicols added a comment - Hi Davo, You're probably the best person to look into this.
            Hide
            Davo Smith added a comment -

            The logic for the buttons made me scratch my head for a bit, but I think I understand it now and have got it fixed.

            Show
            Davo Smith added a comment - The logic for the buttons made me scratch my head for a bit, but I think I understand it now and have got it fixed.
            Hide
            Ankit Agarwal added a comment -

            Changes looks good.
            tested the changes as well, works fine for me.
            Added the mdlqa tag as it was reported in one of failed QA as well.
            Sending this for integration.

            Thanks

            Show
            Ankit Agarwal added a comment - Changes looks good. tested the changes as well, works fine for me. Added the mdlqa tag as it was reported in one of failed QA as well. Sending this for integration. Thanks
            Hide
            Dan Poltawski added a comment -

            Thanks i've integrated this

            Show
            Dan Poltawski added a comment - Thanks i've integrated this
            Hide
            Dan Poltawski added a comment -

            Passing test as its to be testing in the QA test

            Show
            Dan Poltawski added a comment - Passing test as its to be testing in the QA test
            Hide
            Eloy Lafuente (stronk7) added a comment -

            This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

            Thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: