[MDL-33080] Restoring IMS-CC files, imsmanifest.xml is not looked within root folder - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.2, 2.3
Fix Version/s: 2.2.4
Component/s: Backup: IMS-CC
Labels:
None

Affected Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_22_STABLE
Pull from Repository:
git://github.com/stronk7/moodle.git
Pull Master Branch:
~~MDL-33080~~
Pull Master Diff URL:
https://github.com/stronk7/moodle/compare/master...MDL-33080
Testing Instructions:

Hide

1) Restore the attached course (backup-~~MDL-33080~~.mbz) into new course.
2) Go to the restored course and backup it, ticking the "IMS Common Cartridge 1.1" checkbox.
3) TEST: The process ends and one ".imscc" file is available.
4) Restore that IMSCC package to new course.
5) TEST: The format is properly detected and conversion happen.
6) Continue with the restore process, ignoring any warning.
5) TEST: The process ends without any fatal error. Warnings and borked results at the end can be ignored to tests this. Other issues have been created for them.

Note: It's enough to test this under master only. For 22_STABLE the feature was hidden (via CFG setting) and no many changes are expected there.

Show
1) Restore the attached course (backup- MDL-33080 .mbz) into new course. 2) Go to the restored course and backup it, ticking the "IMS Common Cartridge 1.1" checkbox. 3) TEST: The process ends and one ".imscc" file is available. 4) Restore that IMSCC package to new course. 5) TEST: The format is properly detected and conversion happen. 6) Continue with the restore process, ignoring any warning. 5) TEST: The process ends without any fatal error. Warnings and borked results at the end can be ignored to tests this. Other issues have been created for them. Note: It's enough to test this under master only. For 22_STABLE the feature was hidden (via CFG setting) and no many changes are expected there.

Description

Hi,

I was enabling IMS-CC export @ ~~MDL-33079~~, and tried the obvious test:

1) Create one course with a few activities (one scorm and one ims-cp resources included).
2) Backup (export) it to IMS-CC format.
3) Restore (import) it, to get the course back and compare.

And 3 fails because cc112moodle::get_manifest() returns the scorm or ims-cp imsmanifest.xml files before looking for the root/imsmanifest.xml one (because of how DirectoryIterator returns the information).

So I've created one small patch to enforce looking to the root directory before searching recursively. For your consideration.

Ciao

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

backup-MDL-33080.mbz
365 kB
05/Jun/12 3:37 PM

Issue Links

Discovered while testing

MDL-33523 Some warnings and basic problems restoring one IMSCC file generated by Moodle export

Closed

has been marked as being related by

MDL-37573 Error restoring IMS CC moodle backup (on the same system)

Closed

MDL-33522 Improve imsmanifest.xml detection on IMS-CC restore converter

Closed

Testing discovered

MDL-33079 Enable IMS-CC export by default

Closed

Activity

People

Assignee:: Eloy Lafuente (stronk7)

Reporter:: Eloy Lafuente (stronk7)

Integrator:: Sam Hemelryk

Tester:: Dan Marsden

Participants:: Ankit Agarwal, Dan Marsden, Darko Miletic, Eloy Lafuente (stronk7), Sam Hemelryk

Component watchers:: Darko Miletic, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 1 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 18/May/12 3:55 PM

Updated:: 19/Jan/13 4:41 AM

Resolved:: 12/Jun/12 5:46 PM

Fix Release Date:: 9/Jul/12