Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33080

Restoring IMS-CC files, imsmanifest.xml is not looked within root folder

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2, 2.3
    • Fix Version/s: 2.2.4
    • Component/s: Backup: IMS-CC
    • Labels:
      None
    • Testing Instructions:
      Hide

      1) Restore the attached course (backup-MDL-33080.mbz) into new course.
      2) Go to the restored course and backup it, ticking the "IMS Common Cartridge 1.1" checkbox.
      3) TEST: The process ends and one ".imscc" file is available.
      4) Restore that IMSCC package to new course.
      5) TEST: The format is properly detected and conversion happen.
      6) Continue with the restore process, ignoring any warning.
      5) TEST: The process ends without any fatal error. Warnings and borked results at the end can be ignored to tests this. Other issues have been created for them.

      Note: It's enough to test this under master only. For 22_STABLE the feature was hidden (via CFG setting) and no many changes are expected there.

      Show
      1) Restore the attached course (backup- MDL-33080 .mbz) into new course. 2) Go to the restored course and backup it, ticking the "IMS Common Cartridge 1.1" checkbox. 3) TEST: The process ends and one ".imscc" file is available. 4) Restore that IMSCC package to new course. 5) TEST: The format is properly detected and conversion happen. 6) Continue with the restore process, ignoring any warning. 5) TEST: The process ends without any fatal error. Warnings and borked results at the end can be ignored to tests this. Other issues have been created for them. Note: It's enough to test this under master only. For 22_STABLE the feature was hidden (via CFG setting) and no many changes are expected there.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Hi,

      I was enabling IMS-CC export @ MDL-33079, and tried the obvious test:

      1) Create one course with a few activities (one scorm and one ims-cp resources included).
      2) Backup (export) it to IMS-CC format.
      3) Restore (import) it, to get the course back and compare.

      And 3 fails because cc112moodle::get_manifest() returns the scorm or ims-cp imsmanifest.xml files before looking for the root/imsmanifest.xml one (because of how DirectoryIterator returns the information).

      So I've created one small patch to enforce looking to the root directory before searching recursively. For your consideration.

      Ciao

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Jul/12