Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33087

Broken role override links on Capability overview page

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Visit any course, navigate to Users > Permissions
      3. Prohibit the capability moodle/block:view for the Student role
      4. In site administration, visit Users > Permissions > Capability overview
      5. Search for the capability from step 3
      6. Select All roles and press Get the overview
      7. Confirm the link Permissions in Course: X takes you to the roles override page for that course
      8. Confirm the link Permissions in Category: Y takes you to the roles override page for that category
      Show
      Log in as admin Visit any course, navigate to Users > Permissions Prohibit the capability moodle/block:view for the Student role In site administration, visit Users > Permissions > Capability overview Search for the capability from step 3 Select All roles and press Get the overview Confirm the link Permissions in Course: X takes you to the roles override page for that course Confirm the link Permissions in Category: Y takes you to the roles override page for that category
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
    • Pull 3.6 Diff URL:
    • Pull 3.7 Branch:
    • Pull 3.7 Diff URL:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      Clicking on role override links on capability overview page throw "A required parameter (roleid) was missing" error.
      Steps to reproduce:

      1. Log in as admin
      2. Select a course and change student permission.
        • navigate to Permissions (Settings -> Course administration -> Users -> Permissions)
        • Select "Student" for "Advanced role override"
        • Mark block:view as Prohibit
      3. Navigate to Capability overview (Settings -> Site administration -> Users -> permissions -> Capability overview)
      4. Select any capability (say block:view) and select "All" roles"
      5. Click "Get the overview"
      6. Click on "role override" links

      Expected:
      You should not see any error and system should let you change capabilities
      Current:
      Error appears.

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42100 Bad links in Capability overview report

          • Major - Major loss of function, incorrect output
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-51349 "A required parameter (roleid) was missing" when following a link from capability overview

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Sep/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 5 minutes
                  3h 5m