[MDL-33087] Broken role override links on Capability overview page - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.2.3, 3.5.5, 3.6.3, 3.7
Fix Version/s: 3.6.6, 3.7.2
Component/s: Administration, Course
Labels:
- ci
- triaged

Testing Instructions:
Hide

Log in as admin

Visit any course, navigate to Users > Permissions

Prohibit the capability moodle/block:view for the Student role

In site administration, visit Users > Permissions > Capability overview

Search for the capability from step 3

Select All roles and press Get the overview

Confirm the link Permissions in Course: X takes you to the roles override page for that course

Confirm the link Permissions in Category: Y takes you to the roles override page for that category
Show
Log in as admin Visit any course, navigate to Users > Permissions Prohibit the capability moodle/block:view for the Student role In site administration, visit Users > Permissions > Capability overview Search for the capability from step 3 Select All roles and press Get the overview Confirm the link Permissions in Course: X takes you to the roles override page for that course Confirm the link Permissions in Category: Y takes you to the roles override page for that category
Affected Branches:
MOODLE_22_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 3.7 Branch:
~~MDL-33087~~-37
Pull 3.7 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_37_STABLE...paulholden:MDL-33087-37
Pull Master Branch:
~~MDL-33087~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-33087

Description

Clicking on role override links on capability overview page throw "A required parameter (roleid) was missing" error.
Steps to reproduce:

Log in as admin
Select a course and change student permission.
- navigate to Permissions (Settings -> Course administration -> Users -> Permissions)
- Select "Student" for "Advanced role override"
- Mark block:view as Prohibit
Navigate to Capability overview (Settings -> Site administration -> Users -> permissions -> Capability overview)
Select any capability (say block:view) and select "All" roles"
Click "Get the overview"
Click on "role override" links

Expected:
You should not see any error and system should let you change capabilities
Current:
Error appears.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

MDL-33087.png
2.41 MB
14/Apr/18 6:52 AM
image-2019-09-04-09-21-29-971.png
251 kB
04/Sep/19 9:21 AM

Issue Links

has a non-specific relationship to

MDL-42100 Bad links in Capability overview report

Closed

is duplicated by

MDL-51349 "A required parameter (roleid) was missing" when following a link from capability overview

Closed

Activity

People

Assignee:: Paul Holden

Reporter:: Rajesh Taneja

Peer reviewer:: Amaia Anabitarte

Integrator:: Andrew Nicols

Tester:: Janelle Barcega

Participants:: Amaia Anabitarte, Andrew Nicols, CiBoT, Janelle Barcega, Jun Pataleta, Luca Bösch, Paul Holden, Rajesh Taneja

Component watchers:: Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón

Votes:: 1 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 18/May/12 11:50 PM

Updated:: 06/Sep/19 12:32 AM

Resolved:: 06/Sep/19 12:32 AM

Fix Release Date:: 9/Sep/19

Time Tracking

Estimated:

Remaining:

Logged:

3h 5m