[MDL-33087] Broken role override links on Capability overview page - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Log in as admin

Visit any course, navigate to Users > Permissions

Prohibit the capability moodle/block:view for the Student role

In site administration, visit Users > Permissions > Capability overview

Search for the capability from step 3

Select All roles and press Get the overview

Confirm the link Permissions in Course: X takes you to the roles override page for that course

Confirm the link Permissions in Category: Y takes you to the roles override page for that category
Show
Log in as admin Visit any course, navigate to Users > Permissions Prohibit the capability moodle/block:view for the Student role In site administration, visit Users > Permissions > Capability overview Search for the capability from step 3 Select All roles and press Get the overview Confirm the link Permissions in Course: X takes you to the roles override page for that course Confirm the link Permissions in Category: Y takes you to the roles override page for that category
Affected Branches:
MOODLE_22_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Master Branch:
~~MDL-33087~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-33087

Clicking on role override links on capability overview page throw "A required parameter (roleid) was missing" error.
Steps to reproduce:

Log in as admin
Select a course and change student permission.
- navigate to Permissions (Settings -> Course administration -> Users -> Permissions)
- Select "Student" for "Advanced role override"
- Mark block:view as Prohibit
Navigate to Capability overview (Settings -> Site administration -> Users -> permissions -> Capability overview)
Select any capability (say block:view) and select "All" roles"
Click "Get the overview"
Click on "role override" links

Expected:
You should not see any error and system should let you change capabilities
Current:
Error appears.

has a non-specific relationship to

MDL-42100 Bad links in Capability overview report

is duplicated by

MDL-51349 "A required parameter (roleid) was missing" when following a link from capability overview

Participants:: Amaia Anabitarte, Andrew Lyons, CiBoT, Janelle Barcega, Jun Pataleta, Luca Bösch, Paul Holden, Rajesh Taneja

Component watchers:: Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)

Estimated:

Remaining:

Logged:

3h 5m