Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.1.7, 2.2.4
    • Component/s: Administration
    • Labels:
      None
    • Testing Instructions:
      Hide
      1. Log in as Admin
      2. Open XMLDB editor (Settings -> Site administration -> Development -> XMLDB editor)
      3. Edit any database (By clicking on load and then edit link)
      4. Click "Edit" on table list (Shown under tables)
      5. Edit primary key (Click "Edit" on any key visible in Keys table)
      6. Click "Change" and you should not see any error.

      Note: Make sure to test this on 2.1 as well.

      Show
      Log in as Admin Open XMLDB editor (Settings -> Site administration -> Development -> XMLDB editor) Edit any database (By clicking on load and then edit link) Click "Edit" on table list (Shown under tables) Edit primary key (Click "Edit" on any key visible in Keys table) Click "Change" and you should not see any error. Note: Make sure to test this on 2.1 as well.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33090-missing-xmldb-strings

      Description

      Seen these when adding a new index to a table:

      Invalid get_string() identifier: 'keynameempty' or component 'tool_xmldb'. Perhaps you are missing $string['keynameempty'] = ''; in /home/nicols/git/software/moodle/admin/tool/xmldb/lang/en/tool_xmldb.php?
      line 6518 of /lib/moodlelib.php: call to debugging()
      line 7142 of /lib/moodlelib.php: call to core_string_manager->get_string()
      line 132 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to get_string()
      line 61 of /admin/tool/xmldb/actions/edit_key_save/edit_key_save.class.php: call to XMLDBAction->loadStrings()
      line 61 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to edit_key_save->init()
      line 68 of /admin/tool/xmldb/index.php: call to XMLDBAction->__construct()
      Invalid get_string() identifier: 'incorrectkeyname' or component 'tool_xmldb'. Perhaps you are missing $string['incorrectkeyname'] = ''; in /home/nicols/git/software/moodle/admin/tool/xmldb/lang/en/tool_xmldb.php?
      line 6518 of /lib/moodlelib.php: call to debugging()
      line 7142 of /lib/moodlelib.php: call to core_string_manager->get_string()
      line 132 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to get_string()
      line 61 of /admin/tool/xmldb/actions/edit_key_save/edit_key_save.class.php: call to XMLDBAction->loadStrings()
      line 61 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to edit_key_save->init()
      line 68 of /admin/tool/xmldb/index.php: call to XMLDBAction->__construct()
      Invalid get_string() identifier: 'nofieldsspecified' or component 'tool_xmldb'. Perhaps you are missing $string['nofieldsspecified'] = ''; in /home/nicols/git/software/moodle/admin/tool/xmldb/lang/en/tool_xmldb.php?
      line 6518 of /lib/moodlelib.php: call to debugging()
      line 7142 of /lib/moodlelib.php: call to core_string_manager->get_string()
      line 132 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to get_string()
      line 61 of /admin/tool/xmldb/actions/edit_key_save/edit_key_save.class.php: call to XMLDBAction->loadStrings()
      line 61 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to edit_key_save->init()
      line 68 of /admin/tool/xmldb/index.php: call to XMLDBAction->__construct()
      Invalid get_string() identifier: 'duplicatefieldsused' or component 'tool_xmldb'. Perhaps you are missing $string['duplicatefieldsused'] = ''; in /home/nicols/git/software/moodle/admin/tool/xmldb/lang/en/tool_xmldb.php?
      line 6518 of /lib/moodlelib.php: call to debugging()
      line 7142 of /lib/moodlelib.php: call to core_string_manager->get_string()
      line 132 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to get_string()
      line 61 of /admin/tool/xmldb/actions/edit_key_save/edit_key_save.class.php: call to XMLDBAction->loadStrings()
      line 61 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to edit_key_save->init()
      line 68 of /admin/tool/xmldb/index.php: call to XMLDBAction->__construct()
      Invalid get_string() identifier: 'fieldsusedinindex' or component 'tool_xmldb'. Perhaps you are missing $string['fieldsusedinindex'] = ''; in /home/nicols/git/software/moodle/admin/tool/xmldb/lang/en/tool_xmldb.php?
      line 6518 of /lib/moodlelib.php: call to debugging()
      line 7142 of /lib/moodlelib.php: call to core_string_manager->get_string()
      line 132 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to get_string()
      line 61 of /admin/tool/xmldb/actions/edit_key_save/edit_key_save.class.php: call to XMLDBAction->loadStrings()
      line 61 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to edit_key_save->init()
      line 68 of /admin/tool/xmldb/index.php: call to XMLDBAction->__construct()
      Invalid get_string() identifier: 'noreftablespecified' or component 'tool_xmldb'. Perhaps you are missing $string['noreftablespecified'] = ''; in /home/nicols/git/software/moodle/admin/tool/xmldb/lang/en/tool_xmldb.php?
      line 6518 of /lib/moodlelib.php: call to debugging()
      line 7142 of /lib/moodlelib.php: call to core_string_manager->get_string()
      line 132 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to get_string()
      line 61 of /admin/tool/xmldb/actions/edit_key_save/edit_key_save.class.php: call to XMLDBAction->loadStrings()
      line 61 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to edit_key_save->init()
      line 68 of /admin/tool/xmldb/index.php: call to XMLDBAction->__construct()
      Invalid get_string() identifier: 'wrongnumberofreffields' or component 'tool_xmldb'. Perhaps you are missing $string['wrongnumberofreffields'] = ''; in /home/nicols/git/software/moodle/admin/tool/xmldb/lang/en/tool_xmldb.php?
      line 6518 of /lib/moodlelib.php: call to debugging()
      line 7142 of /lib/moodlelib.php: call to core_string_manager->get_string()
      line 132 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to get_string()
      line 61 of /admin/tool/xmldb/actions/edit_key_save/edit_key_save.class.php: call to XMLDBAction->loadStrings()
      line 61 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to edit_key_save->init()
      line 68 of /admin/tool/xmldb/index.php: call to XMLDBAction->__construct()
      Invalid get_string() identifier: 'noreffieldsspecified' or component 'tool_xmldb'. Perhaps you are missing $string['noreffieldsspecified'] = ''; in /home/nicols/git/software/moodle/admin/tool/xmldb/lang/en/tool_xmldb.php?
      line 6518 of /lib/moodlelib.php: call to debugging()
      line 7142 of /lib/moodlelib.php: call to core_string_manager->get_string()
      line 132 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to get_string()
      line 61 of /admin/tool/xmldb/actions/edit_key_save/edit_key_save.class.php: call to XMLDBAction->loadStrings()
      line 61 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to edit_key_save->init()
      line 68 of /admin/tool/xmldb/index.php: call to XMLDBAction->__construct()
      Invalid get_string() identifier: 'primarykeyonlyallownotnullfields' or component 'tool_xmldb'. Perhaps you are missing $string['primarykeyonlyallownotnullfields'] = ''; in /home/nicols/git/software/moodle/admin/tool/xmldb/lang/en/tool_xmldb.php?
      line 6518 of /lib/moodlelib.php: call to debugging()
      line 7142 of /lib/moodlelib.php: call to core_string_manager->get_string()
      line 132 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to get_string()
      line 61 of /admin/tool/xmldb/actions/edit_key_save/edit_key_save.class.php: call to XMLDBAction->loadStrings()
      line 61 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to edit_key_save->init()
      line 68 of /admin/tool/xmldb/index.php: call to XMLDBAction->__construct()

        Gliffy Diagrams

          Activity

          Hide
          rex Rex Lorenzo added a comment -

          Also getting this in Moodle 2.2.2

          Show
          rex Rex Lorenzo added a comment - Also getting this in Moodle 2.2.2
          Show
          rex Rex Lorenzo added a comment - I cannot seem to edit the ticket to submit my patch, but here it is: Diff with 2.3: https://github.com/rlorenzo/moodle/compare/rlorenzo:master...rlorenzo:MDL-33090-missing-xmldb-strings Link to patch: https://github.com/rlorenzo/moodle/commit/ae11631886b248c8727f4bbaa8e45319a11b617a Diff with 2.2: https://github.com/rlorenzo/moodle/compare/rlorenzo:MOODLE_22_STABLE...rlorenzo:MDL-33090_22-missing-xmldb-strings Link to patch: https://github.com/rlorenzo/moodle/commit/c31149fa6714176cf1312094f502b50b48dab2f7
          Hide
          rajeshtaneja Rajesh Taneja added a comment -

          Thanks for the Patch Rex,
          I have added links and pushing it for peer-review.

          Show
          rajeshtaneja Rajesh Taneja added a comment - Thanks for the Patch Rex, I have added links and pushing it for peer-review.
          Hide
          andyjdavis Andrew Davis added a comment -

          Seems simple enough. Does this want to go into 2.1 as well?

          Show
          andyjdavis Andrew Davis added a comment - Seems simple enough. Does this want to go into 2.1 as well?
          Hide
          rajeshtaneja Rajesh Taneja added a comment -

          Thanks Andrew,

          Yes, it should have gone on 2.1 as well. I have created 2.1 branch and pushing it for integration review.

          Show
          rajeshtaneja Rajesh Taneja added a comment - Thanks Andrew, Yes, it should have gone on 2.1 as well. I have created 2.1 branch and pushing it for integration review.
          Hide
          poltawski Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          rajeshtaneja Rajesh Taneja added a comment -

          I have re-based 21 branch, Rex can you please re-base master and 22 branch.
          Thanks.

          Show
          rajeshtaneja Rajesh Taneja added a comment - I have re-based 21 branch, Rex can you please re-base master and 22 branch. Thanks.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks guys this has been integrated now

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks guys this has been integrated now
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Tested during integration review and passed

          Show
          samhemelryk Sam Hemelryk added a comment - Tested during integration review and passed
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3.

          Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish.

          Many thanks for your collaboration!

          Ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3. Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish. Many thanks for your collaboration! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jul/12