Moodle
  1. Moodle
  2. MDL-33094

improve stored file content validation

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Duplicate
    • Affects Version/s: 2.2
    • Fix Version/s: None
    • Component/s: Files API
    • Labels:
    • Affected Branches:
      MOODLE_22_STABLE

      Description

      At present we only compare sha1 hashes and files sizes, but we do not try to recover from content file corruption or other problems.

      We could probably do a lot more when we detect problem:
      1/ if we have new file content and detect problem we may try to fix current issue.
      2/ we may look into files table and lookup more information and validate existing content

      see http://moodle.org/mod/forum/discuss.php?d=202934 for related info

        Gliffy Diagrams

          Activity

          Petr Skoda created issue -
          Petr Skoda made changes -
          Field Original Value New Value
          Assignee moodle.com [ moodle.com ] Petr Škoda (skodak) [ skodak ]
          Petr Skoda made changes -
          Status Open [ 1 ] Development in progress [ 3 ]
          Petr Skoda made changes -
          Description At present we only compare sha1 hashes and files sizes, but we do not try to recover from content file corruption or other problems.

          We could probably do a lot more when we detect problem:
          1/ if we have new file content and detect problem we may try to fix current issue.
          2/ we may look into files table and lookup more information and validate existing content
          At present we only compare sha1 hashes and files sizes, but we do not try to recover from content file corruption or other problems.

          We could probably do a lot more when we detect problem:
          1/ if we have new file content and detect problem we may try to fix current issue.
          2/ we may look into files table and lookup more information and validate existing content

          see http://moodle.org/mod/forum/discuss.php?d=202934 for related info
          Petr Skoda made changes -
          Summary improve content file validation improve stored file content validation
          Michael de Raadt made changes -
          Fix Version/s DEV backlog [ 10464 ]
          Labels triaged
          Petr Skoda made changes -
          Status Development in progress [ 3 ] Open [ 1 ]
          Hide
          Petr Skoda added a comment -

          hmm, I just quickly looked into master branch and saw new issues that need fixing instead, postponing this, sorry...

          Show
          Petr Skoda added a comment - hmm, I just quickly looked into master branch and saw new issues that need fixing instead, postponing this, sorry...
          Petr Skoda made changes -
          Assignee Petr Škoda (skodak) [ skodak ] moodle.com [ moodle.com ]
          Hide
          Petr Skoda added a comment -

          this should be solved already, closing...

          Show
          Petr Skoda added a comment - this should be solved already, closing...
          Petr Skoda made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Assignee moodle.com [ moodle.com ] Petr Škoda [ skodak ]
          Fix Version/s DEV backlog [ 10464 ]
          Resolution Duplicate [ 3 ]

            People

            • Assignee:
              Petr Skoda
              Reporter:
              Petr Skoda
              Participants:
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: