Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33116

new media embedding seems incompatible with slasharguments off

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Blocker Blocker
    • 2.3
    • 2.3
    • Filters
    • MOODLE_23_STABLE
    • MOODLE_23_STABLE
    • MDL-33116-master
    • Hide

      0. To begin with, in admin settings, set/leave option 'slasharguments' to on.
      1. If necessary, restore the test course from MDL-29624.
      2. In the test course, click on 'Page (filter testing)'

      • Various items should display embedded.

      3. In admin settings, change slasharguments to off.
      4. Load the same page from test course again (e.g. in another tab) and compare the results.

      • The same items should be embedded.

      5. Run unit tests like 'phpunit x lib/tests/medialib_test.php' (or full tests).

      Actual behaviour before fixing bug: in step 4, only the YouTube item is now embeddded, everything else has degraded to a download link. The unit tests pass, but don't cover this situation.

      Show
      0. To begin with, in admin settings, set/leave option 'slasharguments' to on. 1. If necessary, restore the test course from MDL-29624 . 2. In the test course, click on 'Page (filter testing)' Various items should display embedded. 3. In admin settings, change slasharguments to off. 4. Load the same page from test course again (e.g. in another tab) and compare the results. The same items should be embedded. 5. Run unit tests like 'phpunit x lib/tests/medialib_test.php' (or full tests). Actual behaviour before fixing bug: in step 4, only the YouTube item is now embeddded, everything else has degraded to a download link. The unit tests pass, but don't cover this situation.

      If you disable slasharguments the media embedding stops working in most places.

      To integrators: This needs to be integrated before MDL-33145.

            quen Sam Marshall
            skodak Petr Skoda
            Dan Poltawski Dan Poltawski
            Dan Poltawski Dan Poltawski
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.