Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33116

new media embedding seems incompatible with slasharguments off

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 2.3
    • 2.3
    • Filters
    • MOODLE_23_STABLE
    • MOODLE_23_STABLE
    • MDL-33116-master
    • Hide

      0. To begin with, in admin settings, set/leave option 'slasharguments' to on.
      1. If necessary, restore the test course from MDL-29624.
      2. In the test course, click on 'Page (filter testing)'

      • Various items should display embedded.

      3. In admin settings, change slasharguments to off.
      4. Load the same page from test course again (e.g. in another tab) and compare the results.

      • The same items should be embedded.

      5. Run unit tests like 'phpunit x lib/tests/medialib_test.php' (or full tests).

      Actual behaviour before fixing bug: in step 4, only the YouTube item is now embeddded, everything else has degraded to a download link. The unit tests pass, but don't cover this situation.

      Show
      0. To begin with, in admin settings, set/leave option 'slasharguments' to on. 1. If necessary, restore the test course from MDL-29624 . 2. In the test course, click on 'Page (filter testing)' Various items should display embedded. 3. In admin settings, change slasharguments to off. 4. Load the same page from test course again (e.g. in another tab) and compare the results. The same items should be embedded. 5. Run unit tests like 'phpunit x lib/tests/medialib_test.php' (or full tests). Actual behaviour before fixing bug: in step 4, only the YouTube item is now embeddded, everything else has degraded to a download link. The unit tests pass, but don't cover this situation.

    Description

      If you disable slasharguments the media embedding stops working in most places.

      To integrators: This needs to be integrated before MDL-33145.

      Attachments

        Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33145 Media library should not use moodle_url

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-33114 import TinyMCE 3.5.1.1 and fix preview regressions

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          Testing discovered

          Improvement - An enhancement to an existing Moodle feature. MDL-29624 Media embedding should be consistent and customisable

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              quen Sam Marshall
              skodak Petr Skoda
              Dan Poltawski Dan Poltawski
              Dan Poltawski Dan Poltawski
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                25/Jun/12