Details

    • Database:
      MySQL
    • Testing Instructions:
      Hide

      For this test you will need a student and a teacher/admin. You'll also need two browsers. For example firefox and chrome.

      In advanced settings make sure that Enable conditional access is ticked.

      Go to the categories and items screen in the gradebook.
      You'll need a category containing a single activity. Create these if necessary.
      The activity and category should be visible.

      Edit the activity settings and add a condition under "Restrict access". Make it a condition that the student will not meet. I used requiring the user field "Yahoo ID" to be not empty.
      Make sure that "before activity can be accessed" is set to "hide activity entirely".

      As both the student and the teacher/admin go to the gradebook and go to the user report. One in each browser. Both users should be viewing the student's user report. The teacher/admin will need to select the specific student on the user report.
      Make sure that the formatting is ok. It should not be like the student view screenshot attached to this issue.

      As the student go enter the Yahoo ID or whatever they have to do to satisfy the condition.

      Reload the user report as both users. Check it still displays ok.

      As teacher/admin go to the categories and items screen and hide the activity.
      Reload the user report as both users. Check it still displays ok.

      Show
      For this test you will need a student and a teacher/admin. You'll also need two browsers. For example firefox and chrome. In advanced settings make sure that Enable conditional access is ticked. Go to the categories and items screen in the gradebook. You'll need a category containing a single activity. Create these if necessary. The activity and category should be visible. Edit the activity settings and add a condition under "Restrict access". Make it a condition that the student will not meet. I used requiring the user field "Yahoo ID" to be not empty. Make sure that "before activity can be accessed" is set to "hide activity entirely". As both the student and the teacher/admin go to the gradebook and go to the user report. One in each browser. Both users should be viewing the student's user report. The teacher/admin will need to select the specific student on the user report. Make sure that the formatting is ok. It should not be like the student view screenshot attached to this issue. As the student go enter the Yahoo ID or whatever they have to do to satisfy the condition. Reload the user report as both users. Check it still displays ok. As teacher/admin go to the categories and items screen and hide the activity. Reload the user report as both users. Check it still displays ok.
    • Workaround:
      Hide

      None found

      Show
      None found
    • Affected Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-33117_grade_display
    • Rank:
      40380

      Description

      Viewing individual user grades as a teacher (user grade report) is fine, but students' view is seriously broken.

      Please see attached screen captures from a real production site. First one (teacher_view)is user grades viewed as a teacher. This is nothing wrong with this view.
      Second attachment (student_view) shows user grades but viewed when logged in as a student. The generated HTML is clearly broken here.

      1. AndrewAfterFix.png
        113 kB
      2. AndrewBeforeFix.png
        112 kB
      3. AndrewCannotBreakUserReport.png
        93 kB
      4. groupings_-_student.png
        26 kB
      5. mark_admin_course_layout.png
        35 kB
      6. mark_admin_grade_layout.png
        44 kB
      7. mark_student_another_grade_layout.png
        15 kB
      8. mark_student_grade_layout.png
        23 kB
      9. student_view.png
        149 kB
      10. teacher_view.png
        186 kB
      11. thomash-haines-grade-report-after-patch.png
        61 kB
      12. thomash-haines-grade-report-before-patch.png
        69 kB

        Issue Links

          Activity

          Hide
          Iñigo Zendegi added a comment -

          Same problem here in Moodle 2.1.6 w/ Oracle

          Show
          Iñigo Zendegi added a comment - Same problem here in Moodle 2.1.6 w/ Oracle
          Hide
          Ewout ter Haar added a comment -

          Same here... We have not found yet any regularity. It seems to be some interaction between the visibility setting of the grade, of the activity and of the conditional availability system.

          One of our gradebooks started working again when we disabled the conditional availability system (a global setting, enableavailability, in advanced setting). But others continued having problems.

          Show
          Ewout ter Haar added a comment - Same here... We have not found yet any regularity. It seems to be some interaction between the visibility setting of the grade, of the activity and of the conditional availability system. One of our gradebooks started working again when we disabled the conditional availability system (a global setting, enableavailability, in advanced setting). But others continued having problems.
          Hide
          Ewout ter Haar added a comment -

          We have investigated more and found some regularities. This problem seems to occur when the following conditions hold:
          1. The activity is not accessible to students (this can be set in various ways: visibility, conditional access and in the case o mod/quiz, various other conditions).
          2. But in the gradebook, the gradeitem is set to visible.

          Normally, the 2 conditions do not occur together: activities change the gradeitem visibility when their own visibility changes. But apparently, there are some circumstances that can make it happen. and we are still investigating...

          In any case, the bug should be solved: either the html generation should be more robust or it should be impossible to the two conditions above to occur simultaneously, or both.

          Show
          Ewout ter Haar added a comment - We have investigated more and found some regularities. This problem seems to occur when the following conditions hold: 1. The activity is not accessible to students (this can be set in various ways: visibility, conditional access and in the case o mod/quiz, various other conditions). 2. But in the gradebook, the gradeitem is set to visible. Normally, the 2 conditions do not occur together: activities change the gradeitem visibility when their own visibility changes. But apparently, there are some circumstances that can make it happen. and we are still investigating... In any case, the bug should be solved: either the html generation should be more robust or it should be impossible to the two conditions above to occur simultaneously, or both.
          Hide
          Tõnis Tartes added a comment -

          For me it seems there is a problem with the rowspan property.
          I fixed it in my 2.3dev by editing the grade/report/user/lib.php @around line 222 where is the function inject_rowspans();

          foreach ($element['children'] as $key=>$child) {
              $count += $this->inject_rowspans($element['children'][$key]);
          }
          

          Changed to:

          foreach ($element['children'] as $key=>$child) {
              $grade_object = $child['object'];
              if ($grade_object->hidden != 1) {
                  if (!empty($grade_object->itemmodule) && !empty($grade_object->iteminstance)) {
                      $instances = $this->gtree->modinfo->get_instances();
                      if (!empty($instances[$grade_object->itemmodule][$grade_object->iteminstance])) {
                          $cm = $instances[$grade_object->itemmodule][$grade_object->iteminstance];
                          if (!$cm->uservisible) {  
                              continue;
                          }
                      }
                  }
              }
              $count += $this->inject_rowspans($element['children'][$key]);
          }
          

          Its probably not the best fix, but worked for me. Someone should review this.

          Show
          Tõnis Tartes added a comment - For me it seems there is a problem with the rowspan property. I fixed it in my 2.3dev by editing the grade/report/user/lib.php @around line 222 where is the function inject_rowspans(); foreach ($element['children'] as $key=>$child) { $count += $this->inject_rowspans($element['children'][$key]); } Changed to: foreach ($element['children'] as $key=>$child) { $grade_object = $child['object']; if ($grade_object->hidden != 1) { if (!empty($grade_object->itemmodule) && !empty($grade_object->iteminstance)) { $instances = $this->gtree->modinfo->get_instances(); if (!empty($instances[$grade_object->itemmodule][$grade_object->iteminstance])) { $cm = $instances[$grade_object->itemmodule][$grade_object->iteminstance]; if (!$cm->uservisible) { continue; } } } } $count += $this->inject_rowspans($element['children'][$key]); } Its probably not the best fix, but worked for me. Someone should review this.
          Hide
          Chris Follin added a comment -

          We have multiple clients experiencing this issue. Please review Tonis' suggested fix.

          Show
          Chris Follin added a comment - We have multiple clients experiencing this issue. Please review Tonis' suggested fix.
          Hide
          Michael de Raadt added a comment -

          I've just linked an issue that appears to be a duplicate. There is some more information in that issue that might be considered with this one.

          Show
          Michael de Raadt added a comment - I've just linked an issue that appears to be a duplicate. There is some more information in that issue that might be considered with this one.
          Hide
          Edwinna Lucyk added a comment -

          Also affects MOODLE 2.3.1

          Please check the linked issue MDL 34584. There are some different observations of problems with the grade report, (category and items view, activity report-grades (viewed by mentors) and user report) noted there.

          Show
          Edwinna Lucyk added a comment - Also affects MOODLE 2.3.1 Please check the linked issue MDL 34584. There are some different observations of problems with the grade report, (category and items view, activity report-grades (viewed by mentors) and user report) noted there.
          Hide
          David Leeding added a comment -

          I agree with Edwinna: this issue (MDL-33117) seems to be more about the Student View of the User Report, whereas MDL-34584 is about the Category and Items setup. As Edwinna noted in MDL-34584, that issue can be replicated by setting the Grade Type for the category to "None".

          (More screen shots re the Category & Items issue: http://moodle.org/mod/forum/discuss.php?d=207846)

          Show
          David Leeding added a comment - I agree with Edwinna: this issue ( MDL-33117 ) seems to be more about the Student View of the User Report, whereas MDL-34584 is about the Category and Items setup. As Edwinna noted in MDL-34584 , that issue can be replicated by setting the Grade Type for the category to "None". (More screen shots re the Category & Items issue: http://moodle.org/mod/forum/discuss.php?d=207846 )
          Hide
          Andrew Davis added a comment -

          I've started work on this. Currently I'm writing a set of unit tests for inject_rowspans() which seems to be the problem area. I'll put something up once I've been able to reproduce the bug within the unit tests. Once we have that we can have more confidence in the fix.

          Show
          Andrew Davis added a comment - I've started work on this. Currently I'm writing a set of unit tests for inject_rowspans() which seems to be the problem area. I'll put something up once I've been able to reproduce the bug within the unit tests. Once we have that we can have more confidence in the fix.
          Hide
          Edwinna Lucyk added a comment -

          Please test all 3 of the following:
          1. Category and Items view of grade report teacher sees
          2. User report student sees
          3. Activity report-grade report that mentor sees and accesses through student's profile.

          Show
          Edwinna Lucyk added a comment - Please test all 3 of the following: 1. Category and Items view of grade report teacher sees 2. User report student sees 3. Activity report-grade report that mentor sees and accesses through student's profile.
          Hide
          Michael Woods added a comment -

          Agree with David Leeding. MDL-34584 discusses the Categories and Items issue, whereas this ticket doesn't. However, I've just found MDL-29327 and MDL-30550 which both exactly describe the Categories and Items alignment issue where categories are set to Grade Type = None.

          Show
          Michael Woods added a comment - Agree with David Leeding. MDL-34584 discusses the Categories and Items issue, whereas this ticket doesn't. However, I've just found MDL-29327 and MDL-30550 which both exactly describe the Categories and Items alignment issue where categories are set to Grade Type = None.
          Hide
          Michael de Raadt added a comment -

          Carrying over to the next sprint.

          Show
          Michael de Raadt added a comment - Carrying over to the next sprint.
          Hide
          Andrew Davis added a comment -

          Its definitely conditional activity availability that is at fault here. I've filled out the testing instructions.

          Show
          Andrew Davis added a comment - Its definitely conditional activity availability that is at fault here. I've filled out the testing instructions.
          Hide
          Andrew Davis added a comment -

          I'm adding a branch containing the proposed fix. I'm splitting out the addition of unit tests into a separate issue. MDL-34883. They are growing in size and complexity and I feel like I'm holding this fix up unnecessarily. I've bashed on the fix pretty well so I'm confident in it.

          Show
          Andrew Davis added a comment - I'm adding a branch containing the proposed fix. I'm splitting out the addition of unit tests into a separate issue. MDL-34883 . They are growing in size and complexity and I feel like I'm holding this fix up unnecessarily. I've bashed on the fix pretty well so I'm confident in it.
          Hide
          Adrian Greeve added a comment -

          Hi Andrew,

          I had a look at the code and it seems to make sense to me.
          I tested it out and it works fine.
          The only thing is that you have a bit of white space at the end of line 237.

          Thanks.

          Show
          Adrian Greeve added a comment - Hi Andrew, I had a look at the code and it seems to make sense to me. I tested it out and it works fine. The only thing is that you have a bit of white space at the end of line 237. Thanks.
          Hide
          Andrew Davis added a comment -

          I've fixed up the white space and have created branches. Submitting for integration.

          Show
          Andrew Davis added a comment - I've fixed up the white space and have created branches. Submitting for integration.
          Hide
          Lawrence N added a comment - - edited

          Hello,

          Found a big problem and trying to apply the fix suggested (tried it on 2.2.2+ - 07192012) ... https://github.com/andyjdavis/moodle/compare/MOODLE_22_STABLE...MDL-33117_grade_display_22

          Grade info are now missing/incomplete after fix/patch

          I tried to implement the fix ourselves and at first glance it looks like the formatting is fixed, which it was but a bigger problem has occurred ... it has missing grades.

          ".. After looking more closely at the grade book I have found one other small problem, the formatting is now correct as the tiling has been eliminated, but there are now grades missing from the report.

          Again the problem is only in the student view, not an instructor/admin view.

          Show
          Lawrence N added a comment - - edited Hello, Found a big problem and trying to apply the fix suggested (tried it on 2.2.2+ - 07192012) ... https://github.com/andyjdavis/moodle/compare/MOODLE_22_STABLE...MDL-33117_grade_display_22 Grade info are now missing/incomplete after fix/patch I tried to implement the fix ourselves and at first glance it looks like the formatting is fixed, which it was but a bigger problem has occurred ... it has missing grades. ".. After looking more closely at the grade book I have found one other small problem, the formatting is now correct as the tiling has been eliminated, but there are now grades missing from the report. Again the problem is only in the student view, not an instructor/admin view.
          Hide
          Marc Phillips added a comment -

          I am a Moodle admin but not a developer so forgive my elementary question and I hope I am being clear: I noticed that this occurs with the adaptive release. I also noted that it show/hides with the adaptive release. What happens if we set the gradebook up to not hyperlink and be tied with the show/hide on the adaptive release? In other words, when a student goes to the gradebook he or she sees the grades but they are not linked to the activity. Not to talk about competition, but in eCollege and Blackboard the student only sees the assessment name and it is not linked back to the activity. Would this solve the issue? I hope this makes sense. It is only a thought to try and expedite this as this issue is the ONLY problem I have found with Moodle 2.

          Show
          Marc Phillips added a comment - I am a Moodle admin but not a developer so forgive my elementary question and I hope I am being clear: I noticed that this occurs with the adaptive release. I also noted that it show/hides with the adaptive release. What happens if we set the gradebook up to not hyperlink and be tied with the show/hide on the adaptive release? In other words, when a student goes to the gradebook he or she sees the grades but they are not linked to the activity. Not to talk about competition, but in eCollege and Blackboard the student only sees the assessment name and it is not linked back to the activity. Would this solve the issue? I hope this makes sense. It is only a thought to try and expedite this as this issue is the ONLY problem I have found with Moodle 2.
          Hide
          Dan Poltawski added a comment -

          I've consulted with Andrew and i'm reopening so that he can investigate Christopher's comments.

          Show
          Dan Poltawski added a comment - I've consulted with Andrew and i'm reopening so that he can investigate Christopher's comments.
          Hide
          CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          Chris Follin added a comment -

          I tested the fix on a copy of a production site. I do not see any missing grades as reported by Christopher. All the same grades that appeared before the fix are still appearing after the fix. The only difference is that they are now formatted correctly.

          Show
          Chris Follin added a comment - I tested the fix on a copy of a production site. I do not see any missing grades as reported by Christopher. All the same grades that appeared before the fix are still appearing after the fix. The only difference is that they are now formatted correctly.
          Hide
          Michael de Raadt added a comment -

          Hi, Christopher.

          Could you provide more details of how we could replicate the problem you observed?

          Show
          Michael de Raadt added a comment - Hi, Christopher. Could you provide more details of how we could replicate the problem you observed?
          Hide
          Andrew Davis added a comment -

          Hello Christopher. Are the grades missing in the student view conditional availability activities? Are you sure the student should be able to see them? Any additional information you can provide would be greatly appreciated.

          Show
          Andrew Davis added a comment - Hello Christopher. Are the grades missing in the student view conditional availability activities? Are you sure the student should be able to see them? Any additional information you can provide would be greatly appreciated.
          Hide
          Janet Smith added a comment -

          I tested the code and the User Report does display with normal formatting now. Wonderful!

          However, with Restricted Access for activities enabled, it still only displays in the User Report those activities where the Restricted Access allows the student to view the activity at the moment. Those activities that are no longer viewable to the student don't appear on the User Report. It seems to me that Restricted Access to view or complete an activity from the course page should have no bearing on a student's ability to see their grade for that item in the User Report? Even though they can't complete the activity any longer, shouldn't they be able to see their grade for it? I've tried making changes to the Course Grade Settings User Report section to the "Show Hidden Items" and "Hide Totals if they contain hidden items" settings but they make no difference. Am I missing something?

          Show
          Janet Smith added a comment - I tested the code and the User Report does display with normal formatting now. Wonderful! However, with Restricted Access for activities enabled, it still only displays in the User Report those activities where the Restricted Access allows the student to view the activity at the moment. Those activities that are no longer viewable to the student don't appear on the User Report. It seems to me that Restricted Access to view or complete an activity from the course page should have no bearing on a student's ability to see their grade for that item in the User Report? Even though they can't complete the activity any longer, shouldn't they be able to see their grade for it? I've tried making changes to the Course Grade Settings User Report section to the "Show Hidden Items" and "Hide Totals if they contain hidden items" settings but they make no difference. Am I missing something?
          Hide
          Lawrence N added a comment - - edited

          Sorry.. correction... I did make the changes with the revisions and now our instructor notices that it's working properly whereas before he reported it as missing...

          strange...

          Show
          Lawrence N added a comment - - edited Sorry.. correction... I did make the changes with the revisions and now our instructor notices that it's working properly whereas before he reported it as missing... strange...
          Hide
          Andrew Davis added a comment -

          Hi Janet. Currently I don't think we have any ability to allow students to see previously completed activities in the gradebook that they currently are not allowed to see in the course view. Students can essentially either see it or not. Can I ask why you're doing that? It's something we could possibly accommodate it in the future if the need is there.

          I'm putting this up for integration again. While there's still work to be done in this area this is certainly a step in the right direction. Thankyou for your help everyone

          Show
          Andrew Davis added a comment - Hi Janet. Currently I don't think we have any ability to allow students to see previously completed activities in the gradebook that they currently are not allowed to see in the course view. Students can essentially either see it or not. Can I ask why you're doing that? It's something we could possibly accommodate it in the future if the need is there. I'm putting this up for integration again. While there's still work to be done in this area this is certainly a step in the right direction. Thankyou for your help everyone
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Thomas Haines added a comment -

          I have run into this problem, and applied the patch at https://github.com/andyjdavis/moodle/compare/MOODLE_22_STABLE...MDL-33117_grade_display_22 to test.

          It has improved the issue, but I am still seeing problems. I have attached two screen shots to illustrate the before-patch and after-patch behavior

          Show
          Thomas Haines added a comment - I have run into this problem, and applied the patch at https://github.com/andyjdavis/moodle/compare/MOODLE_22_STABLE...MDL-33117_grade_display_22 to test. It has improved the issue, but I am still seeing problems. I have attached two screen shots to illustrate the before-patch and after-patch behavior
          Hide
          Elena Ivanova added a comment -

          I want to add that this happens not only when conditional activities are used, but also when the instructor is using groupings.
          Thus, once the assignment is limited to a sub-set of group in some grouping, the User Report for a student is also broken.

          Show
          Elena Ivanova added a comment - I want to add that this happens not only when conditional activities are used, but also when the instructor is using groupings. Thus, once the assignment is limited to a sub-set of group in some grouping, the User Report for a student is also broken.
          Hide
          Mike Churchward added a comment -

          Will this problem be fixed in Moodle 2.2 as well?

          Show
          Mike Churchward added a comment - Will this problem be fixed in Moodle 2.2 as well?
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

          This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

          This is a bulk-automated message, so if you want to blame some-body/thing/where, don't do it here (use git instead) :-D :-P

          Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame some-body/thing/where, don't do it here (use git instead) :-D :-P Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Aparup Banerjee added a comment -

          Hi Andrew,
          Have you had a look at the more recent comments here from Thomas and Elena?

          imo it would be good to go ahead and integrate this fix as it does improve the issue. We can cater to the related issues via linked MDLs. or better yet, perhaps moving this under a META issue.

          so,in order to get this in(tegrated), i just need to know that these other issues aren't regressions from the patch here and are separate and existing issues.

          Show
          Aparup Banerjee added a comment - Hi Andrew, Have you had a look at the more recent comments here from Thomas and Elena? imo it would be good to go ahead and integrate this fix as it does improve the issue. We can cater to the related issues via linked MDLs. or better yet, perhaps moving this under a META issue. so,in order to get this in(tegrated), i just need to know that these other issues aren't regressions from the patch here and are separate and existing issues.
          Hide
          Aparup Banerjee added a comment -

          it seems Andrew is away for a few weeks. will reopen to wait for his feedback/view.

          Show
          Aparup Banerjee added a comment - it seems Andrew is away for a few weeks. will reopen to wait for his feedback/view.
          Hide
          CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          Kenton Smith added a comment -

          Related to this, has anyone noticed that if Allow access until is enabled within Restrict access, then the activity completely disappears from the student's user report? This occurs with any graded activity (e.g. Assignments, Forums, TurnitIn Assignments, etc.) in Moodle 2.3.1. Once allow access until is disabled, then the grade reappears in the student user report.

          Show
          Kenton Smith added a comment - Related to this, has anyone noticed that if Allow access until is enabled within Restrict access, then the activity completely disappears from the student's user report? This occurs with any graded activity (e.g. Assignments, Forums, TurnitIn Assignments, etc.) in Moodle 2.3.1. Once allow access until is disabled, then the grade reappears in the student user report.
          Hide
          Elizabeth Dalton added a comment -

          We are seeing this as well, and can confirm that setting all items in the course to visible fixes the broken student User Report in the Gradebook (even in a course using Groups). That's a helpful workaround, for those experiencing the bug while waiting for a patch. We have just added the Collapsed Topics plugin, which should remove one of the primary reasons our instructors hide items.

          Show
          Elizabeth Dalton added a comment - We are seeing this as well, and can confirm that setting all items in the course to visible fixes the broken student User Report in the Gradebook (even in a course using Groups). That's a helpful workaround, for those experiencing the bug while waiting for a patch. We have just added the Collapsed Topics plugin, which should remove one of the primary reasons our instructors hide items.
          Hide
          Andrew Davis added a comment -

          Just a quick note to let you know that I am back and am looking at this.

          Show
          Andrew Davis added a comment - Just a quick note to let you know that I am back and am looking at this.
          Hide
          Andrew Davis added a comment -

          Im having trouble reproducing the grouping problem. Can someone who is experiencing it provide some more data on the required activity settings? What are the full set of settings under "Common module settings"? Is there anything under "restrict access"? Anything else that seems to be involved?

          Show
          Andrew Davis added a comment - Im having trouble reproducing the grouping problem. Can someone who is experiencing it provide some more data on the required activity settings? What are the full set of settings under "Common module settings"? Is there anything under "restrict access"? Anything else that seems to be involved?
          Hide
          Elena Ivanova added a comment -

          Hi Andrew,
          Groupings issue happens when:

          • Enable group members only feature is activated, and applied to graded activities in a groupings mode (so activity needs to have a hidden flag)
          • Gradebook has at least sub-category where those grades are put.
            I will attach a sample backup
          Show
          Elena Ivanova added a comment - Hi Andrew, Groupings issue happens when: Enable group members only feature is activated, and applied to graded activities in a groupings mode (so activity needs to have a hidden flag) Gradebook has at least sub-category where those grades are put. I will attach a sample backup
          Hide
          Elena Ivanova added a comment -

          Just to confirm that in order to replicate, one needs to enable "Enable group members only" for an installation.
          And then create activities in a grouping mode and check "Available for group members only".

          Show
          Elena Ivanova added a comment - Just to confirm that in order to replicate, one needs to enable "Enable group members only" for an installation. And then create activities in a grouping mode and check "Available for group members only".
          Hide
          Andrew Davis added a comment - - edited

          Ok, something very odd is going on because even with that backup I dont seem to be able to get anything bad to happen. Maybe I'm misunderstanding something.

          I restored that backup into a new course, edited the DB to alter a restored user's passport so I could log in as one of the students then went and viewed the user report. It looks ok to me. I'll attach a screenshot in case Im just misunderstanding what I'm looking for.

          "enablegroupmembersonly" is definitely turned on.

          I've tried a handful of the built in themes and they don't seem to make any difference. I don't see how the theme could be significant here but I'm just trying to definitively eliminate the theme as a factor.

          I couldn't make anything bad happen in master and have switched to 2.2 as that seems to be the branch others are using that are reporting problems. Still no luck.

          I've rebased MDL-33117_grade_display_22. It would be worth deleting your local copy of that branch and refetching it from github or whatever you need to do to make sure that we're running exactly the same version of the code.

          Show
          Andrew Davis added a comment - - edited Ok, something very odd is going on because even with that backup I dont seem to be able to get anything bad to happen. Maybe I'm misunderstanding something. I restored that backup into a new course, edited the DB to alter a restored user's passport so I could log in as one of the students then went and viewed the user report. It looks ok to me. I'll attach a screenshot in case Im just misunderstanding what I'm looking for. "enablegroupmembersonly" is definitely turned on. I've tried a handful of the built in themes and they don't seem to make any difference. I don't see how the theme could be significant here but I'm just trying to definitively eliminate the theme as a factor. I couldn't make anything bad happen in master and have switched to 2.2 as that seems to be the branch others are using that are reporting problems. Still no luck. I've rebased MDL-33117 _grade_display_22. It would be worth deleting your local copy of that branch and refetching it from github or whatever you need to do to make sure that we're running exactly the same version of the code.
          Hide
          Andrew Davis added a comment - - edited

          Here is a screenshot. Is this report incorrect in some way I'm not noticing?

          https://tracker.moodle.org/secure/attachment/29511/AndrewCannotBreakUserReport.png

          Show
          Andrew Davis added a comment - - edited Here is a screenshot. Is this report incorrect in some way I'm not noticing? https://tracker.moodle.org/secure/attachment/29511/AndrewCannotBreakUserReport.png
          Hide
          Elena Ivanova added a comment - - edited

          I put it on demo and qa site and it can be replicated there (with original course done in 2.2.4)
          The sites are getting wiped out though
          Can I add it somewhere else to show?

          I have attached a screenshot - you are correct, theme does not make a difference http://tracker.moodle.org/secure/attachment/29515/groupings_-_student.png

          Sorry, I cannot do the code replace - it is out of my set of skills. But I would be happy to test/replicate somewhere.

          Show
          Elena Ivanova added a comment - - edited I put it on demo and qa site and it can be replicated there (with original course done in 2.2.4) The sites are getting wiped out though Can I add it somewhere else to show? I have attached a screenshot - you are correct, theme does not make a difference http://tracker.moodle.org/secure/attachment/29515/groupings_-_student.png Sorry, I cannot do the code replace - it is out of my set of skills. But I would be happy to test/replicate somewhere.
          Hide
          Andrew Davis added a comment -

          Are you sure you're running the fix? Here is what my user report looks like before applying the fix (it looks the same as your screenshot). https://tracker.moodle.org/secure/attachment/29529/AndrewBeforeFix.png

          After applying the fix the user report looks like this. https://tracker.moodle.org/secure/attachment/29530/AndrewAfterFix.png

          Show
          Andrew Davis added a comment - Are you sure you're running the fix? Here is what my user report looks like before applying the fix (it looks the same as your screenshot). https://tracker.moodle.org/secure/attachment/29529/AndrewBeforeFix.png After applying the fix the user report looks like this. https://tracker.moodle.org/secure/attachment/29530/AndrewAfterFix.png
          Hide
          Elena Ivanova added a comment -

          oh, I think I misunderstood you. I thought that you cannot reproduce the groupings issue on the not-yet-fixed Moodle.
          It does looks like it is fixed now based on the screenshot.

          Show
          Elena Ivanova added a comment - oh, I think I misunderstood you. I thought that you cannot reproduce the groupings issue on the not-yet-fixed Moodle. It does looks like it is fixed now based on the screenshot.
          Hide
          Andrew Davis added a comment -

          Excellent Requesting peer review now.

          Show
          Andrew Davis added a comment - Excellent Requesting peer review now.
          Hide
          Enrico de Pano added a comment -

          same here v 2.1.7. Students User report gradebook

          Show
          Enrico de Pano added a comment - same here v 2.1.7. Students User report gradebook
          Hide
          Adrian Greeve added a comment -

          [N] Syntax - The code is a bunch of nested if statements which takes a bit of time to work through and understand. Some comments might make it easier to read.
          [Y] Output
          [Y] Whitespace
          [N/A] Language
          [N/A] Databases
          [Y] Testing - I'm not sure, but I think that there was instructions for creating a category in the grade book which was really creating issues with the formatting. Perhaps they could be put back in and tested.
          [N/A] Security
          [N/A] Documentation
          [Y] Git
          [Y] Sanity check

          I couldn't break the formatting and I put a few nested categories in and hid the assessments and had other visible assessments present. It seems to be working fine.

          Show
          Adrian Greeve added a comment - [N] Syntax - The code is a bunch of nested if statements which takes a bit of time to work through and understand. Some comments might make it easier to read. [Y] Output [Y] Whitespace [N/A] Language [N/A] Databases [Y] Testing - I'm not sure, but I think that there was instructions for creating a category in the grade book which was really creating issues with the formatting. Perhaps they could be put back in and tested. [N/A] Security [N/A] Documentation [Y] Git [Y] Sanity check I couldn't break the formatting and I put a few nested categories in and hid the assessments and had other visible assessments present. It seems to be working fine.
          Hide
          Andrew Davis added a comment -

          Ive added some white space and explanatory comments.

          Pushing for integration.

          Show
          Andrew Davis added a comment - Ive added some white space and explanatory comments. Pushing for integration.
          Hide
          Dan Poltawski added a comment -

          Thanks Andrew, i've integrated this now.

          Thanks also Adrian for your comments, I think the introduction of comments have made this change much clearer

          Show
          Dan Poltawski added a comment - Thanks Andrew, i've integrated this now. Thanks also Adrian for your comments, I think the introduction of comments have made this change much clearer
          Hide
          Mark Nelson added a comment - - edited

          Why are the fixed branches only 2.2 and 2.3 stable, shouldn't this also be integrated into master? The testing instructions refer to 'Yahoo ID' as the conditional setting, but restrictions via user fields was only introduced in 2.4.

          Show
          Mark Nelson added a comment - - edited Why are the fixed branches only 2.2 and 2.3 stable, shouldn't this also be integrated into master? The testing instructions refer to 'Yahoo ID' as the conditional setting, but restrictions via user fields was only introduced in 2.4.
          Hide
          Dan Poltawski added a comment -

          (sorry for the noise, Mark wanted this un-passed)

          Show
          Dan Poltawski added a comment - (sorry for the noise, Mark wanted this un-passed)
          Hide
          Dan Poltawski added a comment -

          Mark: as dicussed IRL, we do not set the fix version to master when an issue is fixed in 2.4. Briefly this is about making the release notes make the most sense.

          Show
          Dan Poltawski added a comment - Mark: as dicussed IRL, we do not set the fix version to master when an issue is fixed in 2.4. Briefly this is about making the release notes make the most sense.
          Hide
          Mark Nelson added a comment -

          Failing this. The layout does not work if one of the assignment conditions is not met. Please see attached screenshots.

          Show
          Mark Nelson added a comment - Failing this. The layout does not work if one of the assignment conditions is not met. Please see attached screenshots.
          Hide
          Mark Nelson added a comment -

          This is only an issue in 2.3 and master. I believe it has something to do with the fact in 2.2 I can not 'show' a restricted activity, which is a bug in itself.

          Show
          Mark Nelson added a comment - This is only an issue in 2.3 and master. I believe it has something to do with the fact in 2.2 I can not 'show' a restricted activity, which is a bug in itself.
          Hide
          Dan Poltawski added a comment -

          Hi Andrew,

          What is your take on this?

          Show
          Dan Poltawski added a comment - Hi Andrew, What is your take on this?
          Hide
          Andrew Davis added a comment -

          Mark, thanks for those detailed screenshots. I think I've pretty much duplicated your set up.

          Show
          Andrew Davis added a comment - Mark, thanks for those detailed screenshots. I think I've pretty much duplicated your set up.
          Hide
          Dan Poltawski added a comment -

          Hi Guys, we're getting late on a friday for this.

          I'm going to need to revert this if we can't get a solution soon.

          Show
          Dan Poltawski added a comment - Hi Guys, we're getting late on a friday for this. I'm going to need to revert this if we can't get a solution soon.
          Hide
          Andrew Davis added a comment -

          Sigh, I think we might have to revert this again. I can't replicate the behaviour Mark Nelson is reporting however if I have an activity greyed out due to a "restrict access" condition it's now not appearing on the student's user report at all.

          Show
          Andrew Davis added a comment - Sigh, I think we might have to revert this again. I can't replicate the behaviour Mark Nelson is reporting however if I have an activity greyed out due to a "restrict access" condition it's now not appearing on the student's user report at all.
          Hide
          Marc Phillips added a comment -

          Is there ANYTHING we can do as of now to fix the issue at all? I sort of lost track in all of this.

          Show
          Marc Phillips added a comment - Is there ANYTHING we can do as of now to fix the issue at all? I sort of lost track in all of this.
          Hide
          Andrew Davis added a comment -

          Mark, looking here https://tracker.moodle.org/secure/attachment/29608/mark_admin_course_layout.png it looks like the student shouldnt be able to see the second assignment at all but yet here it is https://tracker.moodle.org/secure/attachment/29610/mark_student_grade_layout.png

          I've been unable to figure out what you've done to get into this state. Are you able to provide some more steps? What am I doing wrong?

          Show
          Andrew Davis added a comment - Mark, looking here https://tracker.moodle.org/secure/attachment/29608/mark_admin_course_layout.png it looks like the student shouldnt be able to see the second assignment at all but yet here it is https://tracker.moodle.org/secure/attachment/29610/mark_student_grade_layout.png I've been unable to figure out what you've done to get into this state. Are you able to provide some more steps? What am I doing wrong?
          Hide
          Mark Nelson added a comment - - edited

          Restricted activities still show in the gradebook to students, regardless if they can access it or not. I lodged another bug regarding this, see MDL-35762, so what you described is currently standard behaviour. I went through to replicate the issue from scratch and was able to, here are the steps to take.

          1. Log in as an administrator.
          2. Create a course.
          3. Create three assignments in the same topic, named Assignment 1, Assignment 2 and Assignment 3.
          4. Edit Assignment 2 so that it is restricted to only users who have a grade of 90% for the course total and set before activity can be accessed to 'Show activity greyed-out, with restriction information'.
          5. Go to the grades page and enter the 'Simple View' report.
          6. Create two categories, Category 1 and Category 2.
          7. Move Assignment 1 to the course.
          8. Move Assignment 2 to Category 1.
          9. Move Assignment 3 to Category 2.
          10. Log in as a student and visit that course, ensure the student has not achieved a grade of 90% or above.
          11. Click on the 'Grades' link to view the user report.

          Note. If I change the restriction settings for Assignment 2 to nothing, then the layout looks fine. It also looks fine if the student meets the criteria.

          Show
          Mark Nelson added a comment - - edited Restricted activities still show in the gradebook to students, regardless if they can access it or not. I lodged another bug regarding this, see MDL-35762 , so what you described is currently standard behaviour. I went through to replicate the issue from scratch and was able to, here are the steps to take. 1. Log in as an administrator. 2. Create a course. 3. Create three assignments in the same topic, named Assignment 1, Assignment 2 and Assignment 3. 4. Edit Assignment 2 so that it is restricted to only users who have a grade of 90% for the course total and set before activity can be accessed to 'Show activity greyed-out, with restriction information'. 5. Go to the grades page and enter the 'Simple View' report. 6. Create two categories, Category 1 and Category 2. 7. Move Assignment 1 to the course. 8. Move Assignment 2 to Category 1. 9. Move Assignment 3 to Category 2. 10. Log in as a student and visit that course, ensure the student has not achieved a grade of 90% or above. 11. Click on the 'Grades' link to view the user report. Note. If I change the restriction settings for Assignment 2 to nothing, then the layout looks fine. It also looks fine if the student meets the criteria.
          Hide
          Andrew Davis added a comment -

          "Edit Assignment 2 so that it is restricted to only users who have a grade of 90%."

          We talked in chat. This is 90% for course total and set the assignment to "show greyed out" if the condition isnt met.

          Show
          Andrew Davis added a comment - "Edit Assignment 2 so that it is restricted to only users who have a grade of 90%." We talked in chat. This is 90% for course total and set the assignment to "show greyed out" if the condition isnt met.
          Hide
          Dan Poltawski added a comment -

          Reverted these changes now, reopening.

          Show
          Dan Poltawski added a comment - Reverted these changes now, reopening.
          Hide
          Andrew Davis added a comment -

          See my previous comment (https://tracker.moodle.org/browse/MDL-33117?focusedCommentId=181861&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-181861)

          I'm still stuck here. I'm sure how you're managing to get the greyed out activity to appear on the student's user report. For me it doesn't appear at all. I've commented in MDL-35762 about that.

          If I view the user report as the admin I can see the activity and all is well.

          Show
          Andrew Davis added a comment - See my previous comment ( https://tracker.moodle.org/browse/MDL-33117?focusedCommentId=181861&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-181861 ) I'm still stuck here. I'm sure how you're managing to get the greyed out activity to appear on the student's user report. For me it doesn't appear at all. I've commented in MDL-35762 about that. If I view the user report as the admin I can see the activity and all is well.
          Hide
          CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          U P S T R E A M I Z E D !

          Many thanks, this is now available in all the repos (git & cvs).

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks, this is now available in all the repos (git & cvs). Closing, ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Doh,

          somehow this issue was closed incorrectly when processing all the integrated issues this week. (sort of most voted and current in integration filters mix). Apologies for the confusion, reseting to previous status!

          Ciao, Eloy

          Show
          Eloy Lafuente (stronk7) added a comment - Doh, somehow this issue was closed incorrectly when processing all the integrated issues this week. (sort of most voted and current in integration filters mix). Apologies for the confusion, reseting to previous status! Ciao, Eloy
          Hide
          Mark Nelson added a comment -

          Ok, this issue does not happen now in the latest integration master. Following the instructions I listed above does not lead to a broken user report screen, it looks fine.

          Show
          Mark Nelson added a comment - Ok, this issue does not happen now in the latest integration master. Following the instructions I listed above does not lead to a broken user report screen, it looks fine.
          Hide
          Marc Phillips added a comment -

          We just upgraded to: Moodle 2.2.5+ (Build: 20121005) THE GRADEBOOK ISSUE IS FIXED IN THIS BUILD. Sorry for the caps. I wanted you all to see this.

          Show
          Marc Phillips added a comment - We just upgraded to: Moodle 2.2.5+ (Build: 20121005) THE GRADEBOOK ISSUE IS FIXED IN THIS BUILD. Sorry for the caps. I wanted you all to see this.
          Hide
          Andrew Davis added a comment -

          It is indeed most likely all fixed. I'm currently getting MDL-35762 and MDL-34883 through the HQ development process. Once they're done I will do more testing and make absolutely sure that everything is working as it should.

          Show
          Andrew Davis added a comment - It is indeed most likely all fixed. I'm currently getting MDL-35762 and MDL-34883 through the HQ development process. Once they're done I will do more testing and make absolutely sure that everything is working as it should.
          Hide
          Andrew Davis added a comment - - edited

          Ok, I'm confident that we've dealt with this. MDL-34646 remains but is an edge case that will be rarely encountered. That said, I'm still intending on getting onto it as soon as possible.

          I'm closing this issue. The problems reported in this issue were actually fixed in a series of other MDLs. Its a bit of a spiders web of MDLs unfortunately. See the linked issues if you are interested in the details.

          Thankyou everyone for your assistance and your patience.

          Show
          Andrew Davis added a comment - - edited Ok, I'm confident that we've dealt with this. MDL-34646 remains but is an edge case that will be rarely encountered. That said, I'm still intending on getting onto it as soon as possible. I'm closing this issue. The problems reported in this issue were actually fixed in a series of other MDLs. Its a bit of a spiders web of MDLs unfortunately. See the linked issues if you are interested in the details. Thankyou everyone for your assistance and your patience.
          Hide
          Daniel Nelson added a comment - - edited

          We are on 2.2.5+ and problem still occurs for us when a sub-category is hidden.

          Show
          Daniel Nelson added a comment - - edited We are on 2.2.5+ and problem still occurs for us when a sub-category is hidden.

            People

            • Votes:
              61 Vote for this issue
              Watchers:
              42 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: