Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33117

Broken students grades display

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Duplicate
    • 2.2.3
    • None
    • Gradebook
    • MySQL
    • MOODLE_22_STABLE
    • MDL-33117_grade_display
    • Hide

      None found

      Show
      None found
    • Hide

      For this test you will need a student and a teacher/admin. You'll also need two browsers. For example firefox and chrome.

      In advanced settings make sure that Enable conditional access is ticked.

      Go to the categories and items screen in the gradebook.
      You'll need a category containing a single activity. Create these if necessary.
      The activity and category should be visible.

      Edit the activity settings and add a condition under "Restrict access". Make it a condition that the student will not meet. I used requiring the user field "Yahoo ID" to be not empty.
      Make sure that "before activity can be accessed" is set to "hide activity entirely".

      As both the student and the teacher/admin go to the gradebook and go to the user report. One in each browser. Both users should be viewing the student's user report. The teacher/admin will need to select the specific student on the user report.
      Make sure that the formatting is ok. It should not be like the student view screenshot attached to this issue.

      As the student go enter the Yahoo ID or whatever they have to do to satisfy the condition.

      Reload the user report as both users. Check it still displays ok.

      As teacher/admin go to the categories and items screen and hide the activity.
      Reload the user report as both users. Check it still displays ok.

      Show
      For this test you will need a student and a teacher/admin. You'll also need two browsers. For example firefox and chrome. In advanced settings make sure that Enable conditional access is ticked. Go to the categories and items screen in the gradebook. You'll need a category containing a single activity. Create these if necessary. The activity and category should be visible. Edit the activity settings and add a condition under "Restrict access". Make it a condition that the student will not meet. I used requiring the user field "Yahoo ID" to be not empty. Make sure that "before activity can be accessed" is set to "hide activity entirely". As both the student and the teacher/admin go to the gradebook and go to the user report. One in each browser. Both users should be viewing the student's user report. The teacher/admin will need to select the specific student on the user report. Make sure that the formatting is ok. It should not be like the student view screenshot attached to this issue. As the student go enter the Yahoo ID or whatever they have to do to satisfy the condition. Reload the user report as both users. Check it still displays ok. As teacher/admin go to the categories and items screen and hide the activity. Reload the user report as both users. Check it still displays ok.

    Description

      Viewing individual user grades as a teacher (user grade report) is fine, but students' view is seriously broken.

      Please see attached screen captures from a real production site. First one (teacher_view)is user grades viewed as a teacher. This is nothing wrong with this view.
      Second attachment (student_view) shows user grades but viewed when logged in as a student. The generated HTML is clearly broken here.

      Attachments

        1. AndrewAfterFix.png
          113 kB
          Andrew Davis
        2. AndrewBeforeFix.png
          112 kB
          Andrew Davis
        3. AndrewCannotBreakUserReport.png
          93 kB
          Andrew Davis
        4. backup-moodle2-course-grades_-_groupings-20120921-0910-an.mbz
          30 kB
          Elena Ivanova
        5. groupings_-_student.png
          26 kB
          Elena Ivanova
        6. mark_admin_course_layout.png
          35 kB
          Mark Nelson
        7. mark_admin_grade_layout.png
          44 kB
          Mark Nelson
        8. mark_student_another_grade_layout.png
          15 kB
          Mark Nelson
        9. mark_student_grade_layout.png
          23 kB
          Mark Nelson
        10. student_view.png
          149 kB
          Orestes Mas
        11. teacher_view.png
          186 kB
          Orestes Mas
        12. thomash-haines-grade-report-after-patch.png
          61 kB
          Thomas Haines
        13. thomash-haines-grade-report-before-patch.png
          69 kB
          Thomas Haines

        Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35762 Grade items show up in the gradebook for students who do not meet conditions for a conditional activity.

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35766 Restricted activity does not change from hidden.

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35765 Grade categories not distinct in conditional drop down.

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-34883 Write unit tests for the user report function inject_rowspans()

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34931 Students can not see unhidden grades for hidden activities in the User report

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34592 Grader Report rows do not align between usernames and their grades when editing is on or off. IE8, FF, Safari.

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34646 Category with "Grade Type: None" causes input boxes in the Grader Report to shift one column to the left

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34584 Grade items in the gradebook are misaligned when there are multiple levels of category nesting or when the category grade type is NONE, rendering the user report in some cases essentially unreadable for student/parents/teachers.

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34998 Restricted Access Activities cause problems with Gradebook User Report display

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              andyjdavis Andrew Davis
              orestes Orestes Mas
              Adrian Greeve Adrian Greeve
              Dan Poltawski Dan Poltawski
              Mark Nelson Mark Nelson
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              61 Vote for this issue
              Watchers:
              40 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: