Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33118

Change MAIN_CONTENT_TOKEN to new format in theme/mymobile/layout/embedded.php

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2.4
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      With 'MyMobile' selected as the prefered theme for "Mobile" device, TEST on an appropriate mobile phone (iPhone, Android etc) to access any embedded file such as a PDF.

      Show
      With 'MyMobile' selected as the prefered theme for "Mobile" device, TEST on an appropriate mobile phone (iPhone, Android etc) to access any embedded file such as a PDF.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:

      Description

      Discovered while testing, it appears that theme/mymobile/layout/embedded.php contains

       <?php echo core_renderer::MAIN_CONTENT_TOKEN ?>

      instead of

       <?php echo $OUTPUT->main_content() ?>

      as can be seen here...
      https://github.com/lazydaisy/moodle/blob/master/theme/mymobile/layout/embedded.php

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            samhemelryk Sam Hemelryk added a comment -

            Good spotting and thanks for fixing Mary, this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Good spotting and thanks for fixing Mary, this has been integrated now.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Tested during integration review

            Show
            samhemelryk Sam Hemelryk added a comment - Tested during integration review
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

            Thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jul/12