Moodle

Complete report error - quiz section

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1, 2.2, 2.3
  • Fix Version/s: 2.1.7, 2.2.4
  • Component/s: Quiz, Reports
  • Labels:
    None
  • Testing Instructions:
    Hide

    Preques
    1. Attempt a quiz in a course as a student.

    2. Go to that user's complete report for the course. ( Participants > StudentX > Activity Reports > Complete report )

    3. Verify that everything looks OK.

    Show
    Preques 1. Attempt a quiz in a course as a student. 2. Go to that user's complete report for the course. ( Participants > StudentX > Activity Reports > Complete report ) 3. Verify that everything looks OK.
  • Affected Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

in Moodle 2.1.x, 2.2.x and 2.3 Beta.

When inside the complete report for a student, under the quiz section you will see something like this

Quiz: New Quiz - The Attempt - Whether correct - Marks - Specific feedback - General feedback
Grade: 5.00 / 10.00
Attempt {$a} 1: 1.00/2.00 - Monday, 20 February 2012, 02:38 PM

I have highlighted the error. Inside the file /mod/quiz/lang/en/quiz.php contains this line:

$string['attempt'] = 'Attempt {$a}';

which indicates the 'string contains a placeholder' Which is fine but I cannot work out whether it was deliberate or a legacy issue.
This is easily edited with Language Customisation so that 'mod_quiz' 'attempt' instead of being 'Attempt {$a}' is now 'Attempt'

Am I missing anything else as I cannot see where else this is impacted?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

Thanks Cam. You have to be careful editing that string, because it is used in a few different places, where the placeholder is required.

Correct fix submitted for integration.

Show
Tim Hunt added a comment - Thanks Cam. You have to be careful editing that string, because it is used in a few different places, where the placeholder is required. Correct fix submitted for integration.
Hide
Permalink
Dan Poltawski added a comment -

Hmm. Your branch includes an AMOS automatic installer langfile change in 2.1 branch.

Show
Dan Poltawski added a comment - Hmm. Your branch includes an AMOS automatic installer langfile change in 2.1 branch.
Hide
Permalink
Tim Hunt added a comment -

That's weird. Can you fix it by cherry-picking, or do you insist that I do it?

(I think that the original problem was me screwing up with the cherry-picking. That is what I get for trying to fix bugs during Helen's keynote )

Show
Tim Hunt added a comment - That's weird. Can you fix it by cherry-picking, or do you insist that I do it? (I think that the original problem was me screwing up with the cherry-picking. That is what I get for trying to fix bugs during Helen's keynote )
Hide
Permalink
Dan Poltawski added a comment -

I'm happy to do it, just checking it isn't the symptom of a wider issue

Show
Dan Poltawski added a comment - I'm happy to do it, just checking it isn't the symptom of a wider issue
Hide
Permalink
Dan Poltawski added a comment -

Integrated this, thanks

Show
Dan Poltawski added a comment - Integrated this, thanks
Hide
Permalink
Dan Poltawski added a comment -

Just a note that I spend a long time working out how to test this issue because I didn't know how to get to the complete report (nothing to do with course completion..)

Show
Dan Poltawski added a comment - Just a note that I spend a long time working out how to test this issue because I didn't know how to get to the complete report (nothing to do with course completion..)
Hide
Permalink
Dan Poltawski added a comment -

Tested on 2.1, 2.2 and master, thanks.

Show
Dan Poltawski added a comment - Tested on 2.1, 2.2 and master, thanks.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3.

Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish.

Many thanks for your collaboration!

Ciao

Show
Eloy Lafuente (stronk7) added a comment - We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3. Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish. Many thanks for your collaboration! Ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: