Moodle
  1. Moodle
  2. MDL-33122

Enable more repositories by default on new installs

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: Repositories
    • Labels:
    • Testing Instructions:
      Hide
      1. Run a fresh install of Moodle.
      2. Make sure there are no errors/warnings during the install.
      3. Open filepicker from anywhere and make sure you can see "url", "wikimedia" and "youtube" repositories.
      4. Make sure these repositories work as expected.
      5. goto http://mymoodle/moodle/admin/repository.php and make sure you can see the following repositories marked as "enabled and visible"
      • server files
      • Recent files
      • upload a file
      • url downloader
      • private file
      • wikimedia
      • youtube
      Show
      Run a fresh install of Moodle. Make sure there are no errors/warnings during the install. Open filepicker from anywhere and make sure you can see "url", "wikimedia" and "youtube" repositories. Make sure these repositories work as expected. goto http://mymoodle/moodle/admin/repository.php and make sure you can see the following repositories marked as "enabled and visible" server files Recent files upload a file url downloader private file wikimedia youtube
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-33122-master

      Description

      There is no reason not to enable the zero-config repositories by default on Moodle installs.

      1. It makes Moodle look cooler out of the box.
      2. It helps people realise the true usefulness of the file picker.
      3. It saves time for people
      4. There are no performance or UI disadvantages.

        Gliffy Diagrams

          Activity

          Hide
          Martin Dougiamas added a comment -

          All you need to do is create new instances via the db/install.php mechanism.

          See these for a model:

          /repository/local/db/install.php
          /repository/recent/db/install.php
          /repository/upload/db/install.php
          /repository/user/db/install.php

          And create new ones for Youtube, Google Docs, URL downloader and Wikimedia :

          /repository/googledocs/db/install.php
          /repository/url/db/install.php
          /repository/wikimedia/db/install.php
          /repository/youtube/db/install.php

          Show
          Martin Dougiamas added a comment - All you need to do is create new instances via the db/install.php mechanism. See these for a model: /repository/local/db/install.php /repository/recent/db/install.php /repository/upload/db/install.php /repository/user/db/install.php And create new ones for Youtube, Google Docs, URL downloader and Wikimedia : /repository/googledocs/db/install.php /repository/url/db/install.php /repository/wikimedia/db/install.php /repository/youtube/db/install.php
          Hide
          Dan Poltawski added a comment -

          googledocs is a bad candidate for this as google are depreciating authsub and we will need enforce configuration for setup of googledocs in the future. See MDL-29857

          Show
          Dan Poltawski added a comment - googledocs is a bad candidate for this as google are depreciating authsub and we will need enforce configuration for setup of googledocs in the future. See MDL-29857
          Hide
          Martin Dougiamas added a comment -

          Ah yes. Scrub that then.

          Show
          Martin Dougiamas added a comment - Ah yes. Scrub that then.
          Hide
          Martin Dougiamas added a comment -

          So it's just for

          /repository/url/db/install.php
          /repository/wikimedia/db/install.php
          /repository/youtube/db/install.php

          Show
          Martin Dougiamas added a comment - So it's just for /repository/url/db/install.php /repository/wikimedia/db/install.php /repository/youtube/db/install.php
          Hide
          Ankit Agarwal added a comment -

          @integrator
          Should be master only in my opinion, still its a clean cherry-pick if it needs to be ported.

          Show
          Ankit Agarwal added a comment - @integrator Should be master only in my opinion, still its a clean cherry-pick if it needs to be ported.
          Hide
          Dan Poltawski added a comment -

          Looks good to me Ankit (not great that this is the way we have to do it), also nitpicking no underscores in variables - but I can see you've just copied the existing style there

          Show
          Dan Poltawski added a comment - Looks good to me Ankit (not great that this is the way we have to do it), also nitpicking no underscores in variables - but I can see you've just copied the existing style there
          Hide
          Ankit Agarwal added a comment -

          Thanks for the review Dan,
          yeah I noticed the underscores as well, but left it that way so that it stays consistent.
          Sending for integration.
          Thanks

          Show
          Ankit Agarwal added a comment - Thanks for the review Dan, yeah I noticed the underscores as well, but left it that way so that it stays consistent. Sending for integration. Thanks
          Hide
          Ankit Agarwal added a comment -

          sorry about the noise. Assigned it to wrong Dan

          Show
          Ankit Agarwal added a comment - sorry about the noise. Assigned it to wrong Dan
          Hide
          Michael de Raadt added a comment -

          This will require a change in the documentation at http://docs.moodle.org/22/en/Repositories

          Show
          Michael de Raadt added a comment - This will require a change in the documentation at http://docs.moodle.org/22/en/Repositories
          Hide
          Ankit Agarwal added a comment -

          Thanks Michael for pointing that out. I will make the change, once the code is integrated.
          Thanks

          Show
          Ankit Agarwal added a comment - Thanks Michael for pointing that out. I will make the change, once the code is integrated. Thanks
          Hide
          Martin Dougiamas added a comment -

          Don't change the 22 version ... only change it in the 2.3 docs (they should be created very soon)

          Show
          Martin Dougiamas added a comment - Don't change the 22 version ... only change it in the 2.3 docs (they should be created very soon)
          Hide
          Sam Hemelryk added a comment -

          Thanks guys this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks guys this has been integrated now
          Hide
          Sam Hemelryk added a comment -

          Tested during integration and passed

          Show
          Sam Hemelryk added a comment - Tested during integration and passed
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

          Thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!
          Hide
          Ankit Agarwal added a comment -

          Updated http://docs.moodle.org/23/en/Repositories

          removed the docs label

          Thanks

          Show
          Ankit Agarwal added a comment - Updated http://docs.moodle.org/23/en/Repositories removed the docs label Thanks

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: