Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33128

List activities before resources in the Activity Chooser

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide
      • Open a course
      • Turn editing on
      • Open the Activity chooser
      • Confirm that activities are listed first
      • Select an activity and click 'Add'
        • Confirm that the correct module editing page was loaded
      • Select a resource and click 'Add'
        • Confirm that the correct module editing page was loaded
      Show
      Open a course Turn editing on Open the Activity chooser Confirm that activities are listed first Select an activity and click 'Add' Confirm that the correct module editing page was loaded Select a resource and click 'Add' Confirm that the correct module editing page was loaded
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33128-master-1

      Gliffy Diagrams

        Attachments

          Issue Links

            Activity

            Hide
            poltawski Dan Poltawski added a comment -

            Looks good

            Show
            poltawski Dan Poltawski added a comment - Looks good
            Hide
            rex Rex Lorenzo added a comment -

            I heard about this ticket from the Moodle.org developers meeting today and would vote for not having the resources listed after the activities for the following reasons:

            • The dropdown box has been listed before activities for the longest time. Rearranging the order now would be a dissonance for long time users.
            • There will generally be lesser number of resource types than activity types. By putting activities first, there is a chance that the resource types will be hidden "below the fold" and would require scrolling to even see that there are resource types that can be selected.
            Show
            rex Rex Lorenzo added a comment - I heard about this ticket from the Moodle.org developers meeting today and would vote for not having the resources listed after the activities for the following reasons: The dropdown box has been listed before activities for the longest time. Rearranging the order now would be a dissonance for long time users. There will generally be lesser number of resource types than activity types. By putting activities first, there is a chance that the resource types will be hidden "below the fold" and would require scrolling to even see that there are resource types that can be selected.
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            Adding to Rex...
            Teacher uses Resources more then Activities on 80% of the Moodle systems I administrate (state wide statistics!)

            Show
            nadavkav Nadav Kavalerchik added a comment - Adding to Rex... Teacher uses Resources more then Activities on 80% of the Moodle systems I administrate (state wide statistics!)
            Hide
            poltawski Dan Poltawski added a comment -

            I'm taking this out of integration review for Martin to make the call on whether we do this.

            Please submit for integration when MD has made the call.

            Show
            poltawski Dan Poltawski added a comment - I'm taking this out of integration review for Martin to make the call on whether we do this. Please submit for integration when MD has made the call.
            Hide
            tsala Helen Foster added a comment -

            Rex and Nadav, thanks for your comments.

            Regarding the chance that the resource types will be hidden "below the fold", I tried upgrading assignments on my site (which I assume admins will quickly do when they upgrade to 2.3) and found that, when using a screensize of 1024x768, all activities and resources were displayed with no scrollbar at all (see attachment).

            I agree that teachers generally use resources a lot more than activities, but I think that listing activities first is a way of encouraging / highlighting the use of activities. As the chooser is to be called the 'activity chooser' (not module chooser as stated in the title of this issue), surely it makes sense for activities to be listed first?

            I've added Martin as a watcher for his comments.

            Show
            tsala Helen Foster added a comment - Rex and Nadav, thanks for your comments. Regarding the chance that the resource types will be hidden "below the fold", I tried upgrading assignments on my site (which I assume admins will quickly do when they upgrade to 2.3) and found that, when using a screensize of 1024x768, all activities and resources were displayed with no scrollbar at all (see attachment). I agree that teachers generally use resources a lot more than activities, but I think that listing activities first is a way of encouraging / highlighting the use of activities. As the chooser is to be called the 'activity chooser' (not module chooser as stated in the title of this issue), surely it makes sense for activities to be listed first? I've added Martin as a watcher for his comments.
            Hide
            dougiamas Martin Dougiamas added a comment -

            I'm a little torn on this.

            Pros:

            • Activities need to be encouraged as they are not as obvious to new teachers
            • Resources can be "dragged in" now often bypassing this menu altogether.
            • There's not much difference in scrolling, I think, once old assignments is gone.
            • We can add custom sorting later, see

            Cons:

            • Yes, a perceived order has changed (actually the Activity menu was first on the right, and Resources was added later next to it!)
            • It's probable that there will generally be more activity types than resource types over time.

            On balance my +1 still goes towards integrating this, as long as we consider some custom sorting later (see MDL-30615 for discussion).

            Show
            dougiamas Martin Dougiamas added a comment - I'm a little torn on this. Pros: Activities need to be encouraged as they are not as obvious to new teachers Resources can be "dragged in" now often bypassing this menu altogether. There's not much difference in scrolling, I think, once old assignments is gone. We can add custom sorting later, see Cons: Yes, a perceived order has changed (actually the Activity menu was first on the right, and Resources was added later next to it!) It's probable that there will generally be more activity types than resource types over time. On balance my +1 still goes towards integrating this, as long as we consider some custom sorting later (see MDL-30615 for discussion).
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Andrew, this has been integrated now.
            I'll open a new feature issue immediately for sorting that list.

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now. I'll open a new feature issue immediately for sorting that list. Cheers Sam
            Hide
            abgreeve Adrian Greeve added a comment -
            • Confirmed that activities are listed before resourses.
            • Confirmed that the correct module editing page was loaded after selecting an activity.
            • Confirmed that the correct module editing page was loaded after selecting a resource.
              Test passed
            Show
            abgreeve Adrian Greeve added a comment - Confirmed that activities are listed before resourses. Confirmed that the correct module editing page was loaded after selecting an activity. Confirmed that the correct module editing page was loaded after selecting a resource. Test passed
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL Ciao

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12