Moodle
  1. Moodle
  2. MDL-33135

New 'Add module' dialog doesn't prevent multiple clicks

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide
      • Open the course page
      • Turn editing on
      • Open the Activity Chooser
      • Select an activity and ensure that the help text is shown
      • Select another activity and ensure that it's help text is shown
      • Double-click on another activity
      • Ensure that before the page loads:
        • The 'Add' button is disabled and greyed out
        • The options are disabled
      • Ensure that the module editing page is for the correct module
      • Navigate back to the previous page
      • Open the Activity Chooser
      • Select an activity and ensure that the help text is shown
      • Select another activity and ensure that it's help text is shown
      • Click the add button
      • Ensure that before the page loads:
        • The 'Add' button is disabled and greyed out
        • The options are disabled
      • Ensure that the module editing page is for the correct module
      • Navigate back to the previous page
      • Open the Activity Chooser
      • Select an activity and ensure that the help text is shown
      • Select another activity and ensure that it's help text is shown
      • Click the add button
      • Quickly hit escape - this should close the chooser and cancel the page navigation
      • Open the Activity Chooser again
      • Select a fourth (different) activity
      • Click the add button again
      • Ensure that before the page loads:
        • The 'Add' button is disabled and greyed out
        • The options are disabled
      • Ensure that the module editing page is for the correct module
      Show
      Open the course page Turn editing on Open the Activity Chooser Select an activity and ensure that the help text is shown Select another activity and ensure that it's help text is shown Double-click on another activity Ensure that before the page loads: The 'Add' button is disabled and greyed out The options are disabled Ensure that the module editing page is for the correct module Navigate back to the previous page Open the Activity Chooser Select an activity and ensure that the help text is shown Select another activity and ensure that it's help text is shown Click the add button Ensure that before the page loads: The 'Add' button is disabled and greyed out The options are disabled Ensure that the module editing page is for the correct module Navigate back to the previous page Open the Activity Chooser Select an activity and ensure that the help text is shown Select another activity and ensure that it's help text is shown Click the add button Quickly hit escape - this should close the chooser and cancel the page navigation Open the Activity Chooser again Select a fourth (different) activity Click the add button again Ensure that before the page loads: The 'Add' button is disabled and greyed out The options are disabled Ensure that the module editing page is for the correct module
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33135-master-3
    • Rank:
      40996

      Description

      When using Firefox, the 'Add module' dialog lets you click the 'Add' button lots of times, which basically just makes it slower to eventually load an add page.

        Activity

        Hide
        Sam Marshall added a comment -

        +1 from me - approach seems complex but probably necessary, and I was wondering if you'd also fixed it for double-click. Earlier I also thought double-click didn't work, because I clicked it lots of times but nothing happened, until I eventually stopped clicking it and it worked

        Minor issues:

        // Enusre that the options are shown

        Typo. Plus code style trivia:

        1) A few instances of missing full stop at end of comment.
        2) Missing blank line above/below function.

        Show
        Sam Marshall added a comment - +1 from me - approach seems complex but probably necessary, and I was wondering if you'd also fixed it for double-click. Earlier I also thought double-click didn't work, because I clicked it lots of times but nothing happened, until I eventually stopped clicking it and it worked Minor issues: // Enusre that the options are shown Typo. Plus code style trivia: 1) A few instances of missing full stop at end of comment. 2) Missing blank line above/below function.
        Hide
        Dan Poltawski added a comment -

        Integrated, thanks.

        (Also seems complex to me, so I hope all the complexity there is worth it )

        Show
        Dan Poltawski added a comment - Integrated, thanks. (Also seems complex to me, so I hope all the complexity there is worth it )
        Hide
        Dan Poltawski added a comment -

        All works for me. Neat.

        However, i'd love to know why that page takes SO LONG to load!

        Show
        Dan Poltawski added a comment - All works for me. Neat. However, i'd love to know why that page takes SO LONG to load!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

        Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: