Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33135

New 'Add module' dialog doesn't prevent multiple clicks

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide
      • Open the course page
      • Turn editing on
      • Open the Activity Chooser
      • Select an activity and ensure that the help text is shown
      • Select another activity and ensure that it's help text is shown
      • Double-click on another activity
      • Ensure that before the page loads:
        • The 'Add' button is disabled and greyed out
        • The options are disabled
      • Ensure that the module editing page is for the correct module
      • Navigate back to the previous page
      • Open the Activity Chooser
      • Select an activity and ensure that the help text is shown
      • Select another activity and ensure that it's help text is shown
      • Click the add button
      • Ensure that before the page loads:
        • The 'Add' button is disabled and greyed out
        • The options are disabled
      • Ensure that the module editing page is for the correct module
      • Navigate back to the previous page
      • Open the Activity Chooser
      • Select an activity and ensure that the help text is shown
      • Select another activity and ensure that it's help text is shown
      • Click the add button
      • Quickly hit escape - this should close the chooser and cancel the page navigation
      • Open the Activity Chooser again
      • Select a fourth (different) activity
      • Click the add button again
      • Ensure that before the page loads:
        • The 'Add' button is disabled and greyed out
        • The options are disabled
      • Ensure that the module editing page is for the correct module
      Show
      Open the course page Turn editing on Open the Activity Chooser Select an activity and ensure that the help text is shown Select another activity and ensure that it's help text is shown Double-click on another activity Ensure that before the page loads: The 'Add' button is disabled and greyed out The options are disabled Ensure that the module editing page is for the correct module Navigate back to the previous page Open the Activity Chooser Select an activity and ensure that the help text is shown Select another activity and ensure that it's help text is shown Click the add button Ensure that before the page loads: The 'Add' button is disabled and greyed out The options are disabled Ensure that the module editing page is for the correct module Navigate back to the previous page Open the Activity Chooser Select an activity and ensure that the help text is shown Select another activity and ensure that it's help text is shown Click the add button Quickly hit escape - this should close the chooser and cancel the page navigation Open the Activity Chooser again Select a fourth (different) activity Click the add button again Ensure that before the page loads: The 'Add' button is disabled and greyed out The options are disabled Ensure that the module editing page is for the correct module
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33135-master-3

      Description

      When using Firefox, the 'Add module' dialog lets you click the 'Add' button lots of times, which basically just makes it slower to eventually load an add page.

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            quen Sam Marshall
            Integrator:
            Dan Poltawski
            Tester:
            Dan Poltawski
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              25/Jun/12