Moodle
  1. Moodle
  2. MDL-33137

Add activity popup Add/Cancel button UI

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Course
    • Labels:

      Description

      I noticed two minor UI problems with the Add/Cancel buttons:

      1. They are in the order 'Cancel, Add'. This seems to me to be wrong, as in different to typical Moodle confirm boxes etc. Could the order be reversed?

      2. Should there be a little space between the buttons? Also, the Add button is much smaller than Cancel - I know this depends on language but how about adding some non-breaking spaces around to make it a similar size?

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Andrew Nicols added a comment -

            Added CSS for those buttons. They now have a fixed width and some padding between.

            Not fixing the button order as this was requested in the original issue.

            Show
            Andrew Nicols added a comment - Added CSS for those buttons. They now have a fixed width and some padding between. Not fixing the button order as this was requested in the original issue.
            Hide
            Sam Marshall added a comment -

            +1 except you probably should use min-width rather than just width, in case somebody has their browser set to large fonts and it starts chopping it off...

            Show
            Sam Marshall added a comment - +1 except you probably should use min-width rather than just width, in case somebody has their browser set to large fonts and it starts chopping it off...
            Hide
            Andrew Nicols added a comment -

            Changed to use min-width. Good catch

            Show
            Andrew Nicols added a comment - Changed to use min-width. Good catch
            Hide
            Sam Hemelryk added a comment -

            Thanks Andrew + Sam, a nice improvement has been integrated now.

            Show
            Sam Hemelryk added a comment - Thanks Andrew + Sam, a nice improvement has been integrated now.
            Hide
            Sam Hemelryk added a comment -

            Tested during integration + passed

            Show
            Sam Hemelryk added a comment - Tested during integration + passed
            Hide
            Eloy Lafuente (stronk7) added a comment -

            This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

            Thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: