Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33139

Misleading message when editing someone else's forum post

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide

      1. Create a forum with some posts.
      2. As a teacher edit a student post.
      3. When saving, verify that the student's name appears (e.g. Student A's post was updated).
      4. Edit your own post.
      5. When saving, verify that you see the original message (Your post was updated).

      Show
      1. Create a forum with some posts. 2. As a teacher edit a student post. 3. When saving, verify that the student's name appears (e.g. Student A's post was updated). 4. Edit your own post. 5. When saving, verify that you see the original message (Your post was updated).
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33139-master

      Description

      When you edit a forum post, whether originally your own or someone else's (e.g. as a teacher) you receive the message "Your post was updated" and you're then redirected. It would be better to say "X's post was updated."

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              samhemelryk Sam Hemelryk added a comment -

              Changes look good thanks Charles.
              The only thing I noted was that there appears to be an indentation issue, things don't quite line up.
              Otherwise looks 100% spot on.

              Cheers
              Sam

              Show
              samhemelryk Sam Hemelryk added a comment - Changes look good thanks Charles. The only thing I noted was that there appears to be an indentation issue, things don't quite line up. Otherwise looks 100% spot on. Cheers Sam
              Hide
              cfulton Charles Fulton added a comment -

              Thanks Sam, fixed.

              Show
              cfulton Charles Fulton added a comment - Thanks Sam, fixed.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks Charles, looks spot on so I have put this up for integration now.

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks Charles, looks spot on so I have put this up for integration now.
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks Charles, i've integrated this now

              Show
              poltawski Dan Poltawski added a comment - Thanks Charles, i've integrated this now
              Hide
              poltawski Dan Poltawski added a comment -

              Worked as described, thanks!

              Show
              poltawski Dan Poltawski added a comment - Worked as described, thanks!
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

              Thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12