Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33145

Media library should not use moodle_url

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: Minor Minor
    • None
    • 2.3
    • Libraries

      This is not very clear from the documentation, but apparently moodle_url should not be used for representing URLs in general, only those which are created in code. There is a bit of warning about this but it's not that strong and I missed it...

      I used moodle_url in a bunch of places in media library, which it seems is not appropriate.

      Changes:

      1) Remove all use of moodle_url in media library.

      2) Change/add to phpdoc for moodle_url to explain that it must be used only for URLs created by code within moodle and must not be constructed from user-entered full url string.

      To integrators: This needs to be integrated after MDL-33116.

            Unassigned Unassigned
            quen Sam Marshall
            Dan Poltawski Dan Poltawski
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.