Moodle
  1. Moodle
  2. MDL-33146

Section drag and drop causes javascript error in weekly format

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Course
    • Labels:

      Description

      This is from MDLQA-2134

      Section drag and drop fails due to javascript error:

      Webpage error details
       
      User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)
      Timestamp: Mon, 21 May 2012 13:39:20 UTC
       
       
      Message: extend failed, verify dependencies
      Line: 43
      Char: 210
      Code: 0
      URI: http://qa.moodle.net/theme/yui_combo.php/3.5.1/build/yui/yui.js
       

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Michael de Raadt added a comment -

            We were able to find a JS error when shifting weeks. This appeared to happen across browsers. The error reported by Firebug was...

            sectionlist.item(node1).one("." + CSS.WEEKDATES) is null
            http://localhost/moodle_testing/course/format/weeks/format.js
            Line 50
            

            We're still following up on the original report.

            Show
            Michael de Raadt added a comment - We were able to find a JS error when shifting weeks. This appeared to happen across browsers. The error reported by Firebug was... sectionlist.item(node1).one("." + CSS.WEEKDATES) is null http://localhost/moodle_testing/course/format/weeks/format.js Line 50 We're still following up on the original report.
            Hide
            Rajesh Taneja added a comment - - edited
            Show
            Rajesh Taneja added a comment - - edited Seems to have broken because of shared renderer. http://git.moodle.org/gw?p=moodle.git;a=commitdiff;h=1804b7c1bc99667198d865b56a5af3158d532de5#patch6
            Hide
            Rajesh Taneja added a comment -

            This will be fixed properly by MDL-32824

            Show
            Rajesh Taneja added a comment - This will be fixed properly by MDL-32824
            Hide
            Michael de Raadt added a comment -

            The original error appears to have been caused by some over-zealous filtering.

            As people are working on MDL-32824, which will specifically resolve the section title issue, I believe this issue can be closed.

            Show
            Michael de Raadt added a comment - The original error appears to have been caused by some over-zealous filtering. As people are working on MDL-32824 , which will specifically resolve the section title issue, I believe this issue can be closed.
            Hide
            Michael de Raadt added a comment -

            It looks like we have a solution to this specific part of the problem. I am reopening this issue so we can push this through.

            Sorry for the miscommunication.

            Show
            Michael de Raadt added a comment - It looks like we have a solution to this specific part of the problem. I am reopening this issue so we can push this through. Sorry for the miscommunication.
            Hide
            Rajesh Taneja added a comment -

            Thanks Adrian,

            Looks good to me.

            Show
            Rajesh Taneja added a comment - Thanks Adrian, Looks good to me.
            Hide
            Dan Poltawski added a comment -

            Thanks for this - i've integrated it now

            Show
            Dan Poltawski added a comment - Thanks for this - i've integrated it now
            Hide
            Dan Poltawski added a comment -

            Passing test to be completed in QA

            Show
            Dan Poltawski added a comment - Passing test to be completed in QA
            Hide
            Eloy Lafuente (stronk7) added a comment -

            This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

            Thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: