Moodle
  1. Moodle
  2. MDL-32999 META: Files UI Stage 2 polishing in master
  3. MDL-33147

Need transaction support for some files operations

        Details

        • Type: Sub-task Sub-task
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.3
        • Fix Version/s: 2.3
        • Component/s: Files API
        • Labels:
          None
        • Testing Instructions:
          Hide

          This change should have no visible results (just introduction of transactions) as such we just need to test things still work correctly.

          1. Test normal file operations to ensure that they continue to work perfectly.
            • Test uploading a file
            • Test deleting a file from a resource
          2. Test file reference operations.
            • Test using a file by reference.
            • Test deleting a file used by reference.
          Show
          This change should have no visible results (just introduction of transactions) as such we just need to test things still work correctly. Test normal file operations to ensure that they continue to work perfectly. Test uploading a file Test deleting a file from a resource Test file reference operations. Test using a file by reference. Test deleting a file used by reference.
        • Affected Branches:
          MOODLE_23_STABLE
        • Fixed Branches:
          MOODLE_23_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          dev_MDL-33147_transaction
        • Pull Master Diff URL:
        • Rank:
          41009

          Description

          From Dan's review at MDL-33032:

          Transaction support is required in some of the file functions

          Particularly now we are dealing with two tables, e.g. create_file_from_reference delete_reference2.3

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Martin Dougiamas added a comment -

            Dongsheng?

            Show
            Martin Dougiamas added a comment - Dongsheng?
            Hide
            Permalink
            Sam Hemelryk added a comment -

            Thanks DS looks spot on and has been integrated now.

            Show
            Sam Hemelryk added a comment - Thanks DS looks spot on and has been integrated now.
            Hide
            Permalink
            Adrian Greeve added a comment -

            1)

            • Testing of uploading a file - OK
            • Testing of deleting a file from a resourse - OK

            2)

            • Testing of using a file by reference - OK
            • Testing of deleting a file used by reference - OK

            No problems encountered.
            Test passed

            Show
            Adrian Greeve added a comment - 1) Testing of uploading a file - OK Testing of deleting a file from a resourse - OK 2) Testing of using a file by reference - OK Testing of deleting a file used by reference - OK No problems encountered. Test passed
            Hide
            Permalink
            Dan Poltawski added a comment -

            Congratulations!

            Your work has made into the latest Moodle release!

            You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

            Show
            Dan Poltawski added a comment - Congratulations! Your work has made into the latest Moodle release! You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: