[MDL-33159] module security broken for new courses - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Go to Site administration > Security > Module security

Switch 'Restrict modules for..' to 'all course'

Tick 'Restrict modules by default'

Select a few modules in the list and save

Navigate to Site admin > Courses > Add/edit courses

Click "Add a new course"

Scroll down to the "Restrict activity modules?" (why does this end in an ?) section

Expected result: The restricted modules list should appear to have the same set of modules set as the global setting.
Show
Go to Site administration > Security > Module security Switch 'Restrict modules for..' to 'all course' Tick 'Restrict modules by default' Select a few modules in the list and save Navigate to Site admin > Courses > Add/edit courses Click "Add a new course" Scroll down to the "Restrict activity modules?" (why does this end in an ?) section Expected result: The restricted modules list should appear to have the same set of modules set as the global setting.
Affected Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/rajeshtaneja/moodle.git

To reproduce

Got to Site administration > Security > Module security
Switch on 'Restrict modules for..' to 'all course'
Tick 'Restrict modules by default'
Select a few modules in the list and save
Create a new course
The restricted modules list appears in the course settings and is enabled but no modules are selected. The requested ones (in the admin page) should be selected.

I confirmed this in 2.2.3+ (Build: 20120519) and in the latest 2.0 branch. Not tried in 2.1 or master

Participants:: Aparup Banerjee, Dan Poltawski, Frédéric Massart, Howard Miller, Michael de Raadt, Rajesh Taneja, Rossiani Wijaya

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)