Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33166

Add forum capability "mod/forum:allowforcesubscribe" or restore "mod/forum:initialsubscriptions"

    Details

    • Testing Instructions:
      Hide
      Test 1
      1. Create a course and don't enroll users
      2. Create forum with subscription mode = "Auto subscription"
      3. Enrol 1 teacher and 1 student to this course
      4. Make sure both are subscribed to forum (Settings -> Forum administration -> Show/edit current subscribers)
      5. Post a discussion and run cron, make sure both teacher and student get notification
      6. Enrol Manager in the same course and make sure forum subscribers doesn't have this Manager and no mail is sent to Manager
      Test 2
      1. Create a course and don't enroll users
      2. Create forum with subscription mode = "Force subscription"
      3. Enrol 1 teacher and 1 student to this course
      4. Make sure both are subscribed to forum (Settings -> Forum administration -> Show/edit current subscribers)
      5. Post a discussion and run cron, make sure both teacher and student get notification
      6. Enrol Manager in the same course and make sure forum subscribers doesn't have this Manager and no mail is sent to Manager
      Show
      Test 1 Create a course and don't enroll users Create forum with subscription mode = "Auto subscription" Enrol 1 teacher and 1 student to this course Make sure both are subscribed to forum (Settings -> Forum administration -> Show/edit current subscribers) Post a discussion and run cron, make sure both teacher and student get notification Enrol Manager in the same course and make sure forum subscribers doesn't have this Manager and no mail is sent to Manager Test 2 Create a course and don't enroll users Create forum with subscription mode = "Force subscription" Enrol 1 teacher and 1 student to this course Make sure both are subscribed to forum (Settings -> Forum administration -> Show/edit current subscribers) Post a discussion and run cron, make sure both teacher and student get notification Enrol Manager in the same course and make sure forum subscribers doesn't have this Manager and no mail is sent to Manager
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      wip-mdl-33166

      Description

      In Moodle 2.2 the capability "mod/forum:initialsubscriptions" was removed to resolve this issue: MDL-30151

      However, that causes problems, because people relied on that capability to prevent certain roles from receiving emails from auto-subscribed forums (MDL-31481 and MDL-33050).

      Add this capability so user who don't have this capability should not be auto-subscribed to forum. (Both for force subscribe or auto subscribe.)

      original description.

      I resolve these problems I have created a new capability called mod/forum:receivemail. It acts similar to the other email specified capabilities such as:

      • mod/quiz:emailconfirmsubmission
      • mod/quiz:emailnotifysubmission
      • mod/feedback:receivemail

      If a user does not have a role with that capability set to Allow, then they will:

      • Not be sent email (either digest or per post) if they are associated with a forum that sends out to subscribers
      • Not have "Subscribe me to this forum" link in the nav block

      However, there is an issue in which that user will appear in the list of subscribed users for auto-subscribed forums, because there isn't a clean way to filter them out. But I hope that isn't a big deal or if someone else can figure out how to do that cleanly.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  4 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Nov/12