Details
-
Type:
Task
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.3
-
Fix Version/s: 2.4
-
Component/s: Unit tests
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_23_STABLE
-
Fixed Branches:MOODLE_24_STABLE
-
Pull from Repository:
-
Pull Master Branch:w30_
MDL-33180_m24_simpletest -
Pull Master Diff URL:
-
Rank:41066
Description
- old unit test admin tool
- lib/simpletest*
- code coverage
- $PHPUNIT global
- docs
- etc.
Issue Links
- has a non-specific relationship to
-
MDL-31206
META: Collect together deprecated code changes for Moodle 2.4
-
- Closed
-
Activity
yes, starting
Show
Petr Škoda
added a comment - yes, starting
Changes look PERFECT thanks Petr, before this gets integrated I just want to double check with MD that he's happy with it. Assuming so it is as good as in!
Show
Sam Hemelryk
added a comment - Changes look PERFECT thanks Petr, before this gets integrated I just want to double check with MD that he's happy with it. Assuming so it is as good as in!
Confirmed with MD, this has now been eradicated from master. Thanks Petr!
Show
Sam Hemelryk
added a comment - Confirmed with MD, this has now been eradicated from master. Thanks Petr!
phpunit passes.
Thanks for fixing this Petr.
Show
Rajesh Taneja
added a comment - phpunit passes.
Thanks for fixing this Petr.
yay, it works! 
This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.
Thank you all for taking the time to get us here.
cheers!
Show
Aparup Banerjee
added a comment - yay, it works!
This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.
Thank you all for taking the time to get us here.
cheers!
Hi, Petr.
You mentioned your intention to work on this in a recent meeting.
Now is apparently the time to make this change if it is a deprecation. I'll leave it to you.