Moodle
  1. Moodle
  2. MDL-32999 META: Files UI Stage 2 polishing in master
  3. MDL-33184

Filemanager: string needs fixing "No files attached - drag and drop files here to upload them"

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Filepicker
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a new folder activity and make sure the filepicker displays: "You can drag and drop files here to add them."
      2. Add a file and save your changes, then visit the folder page and make sure the file has been uploaded.
      3. Go to Settings > My profile settings > Edit profile, make sure the filepicker to upload your avatar displays: "You can drag and drop files here to add them."
      4. Select a file as avatar, update your profile and go back to that page to see if the avatar has been updated.
      Show
      Create a new folder activity and make sure the filepicker displays: "You can drag and drop files here to add them." Add a file and save your changes, then visit the folder page and make sure the file has been uploaded. Go to Settings > My profile settings > Edit profile, make sure the filepicker to upload your avatar displays: "You can drag and drop files here to add them." Select a file as avatar, update your profile and go back to that page to see if the avatar has been updated.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33184-master
    • Rank:
      41070

      Description

      On an empty filearea we see the text "No files attached drag and drop files here to upload them".

      I would change that to:

      "You can drag and drop files here to add them."

        Issue Links

          Activity

          Hide
          Mary Cooch added a comment -

          +1 from me

          Show
          Mary Cooch added a comment - +1 from me
          Hide
          Helen Foster added a comment -

          Also in the drag and drop available help string I'd suggest removing the phrase 'Note: this may not work with other web browsers' as this is confusing for teachers and is something which can be mentioned in the docs.

          Show
          Helen Foster added a comment - Also in the drag and drop available help string I'd suggest removing the phrase 'Note: this may not work with other web browsers' as this is confusing for teachers and is something which can be mentioned in the docs.
          Hide
          Joseph Rézeau added a comment -

          Rephrasing approved by Joseph (another grammar freak).

          Show
          Joseph Rézeau added a comment - Rephrasing approved by Joseph (another grammar freak).
          Hide
          Andrew Davis added a comment -

          Looks good.

          Personally, I'd shorten "drag and drop files here to upload them" slightly to something like "drag and drop files to upload them" rather than extending it. If have some time and are curious as to why see http://www.joelonsoftware.com/uibook/chapters/fog0000000062.html

          Anyhow, it's personal opinion It's fine to go in as is.

          Extend the testing instructions to include actually uploading a file. Just to check that nothing somehow got broken along the way.

          Submit for integration when you're ready.

          Show
          Andrew Davis added a comment - Looks good. Personally, I'd shorten "drag and drop files here to upload them" slightly to something like "drag and drop files to upload them" rather than extending it. If have some time and are curious as to why see http://www.joelonsoftware.com/uibook/chapters/fog0000000062.html Anyhow, it's personal opinion It's fine to go in as is. Extend the testing instructions to include actually uploading a file. Just to check that nothing somehow got broken along the way. Submit for integration when you're ready.
          Hide
          Aparup Banerjee added a comment - - edited

          looks good. This worked for me. up for more testing. This has been integrated into master.

          ps: i was able to upload (drag) an avi file as my avatar in my profile - it did set me wondering how cool it would've been if it played the avi clip as my avatar lol.. a bug ?

          Show
          Aparup Banerjee added a comment - - edited looks good. This worked for me. up for more testing. This has been integrated into master. ps: i was able to upload (drag) an avi file as my avatar in my profile - it did set me wondering how cool it would've been if it played the avi clip as my avatar lol.. a bug ?
          Hide
          Marina Glancy added a comment -

          Apu, don't know anything about it. But I have just created myself an issue MDL-33425 to use the filemanager form element in user profile. So this element will be changed anyway.

          Show
          Marina Glancy added a comment - Apu, don't know anything about it. But I have just created myself an issue MDL-33425 to use the filemanager form element in user profile. So this element will be changed anyway.
          Hide
          Aparup Banerjee added a comment -

          this tested fine.

          Show
          Aparup Banerjee added a comment - this tested fine.
          Hide
          Dan Poltawski added a comment -

          Congratulations!

          Your work has made into the latest Moodle release!

          You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

          Show
          Dan Poltawski added a comment - Congratulations! Your work has made into the latest Moodle release! You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: