Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33186

comment.js attempts to act on textarea when it's not there

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.6, 2.3
    • Fix Version/s: 2.3
    • Component/s: Comments
    • Labels:

      Description

      Create a new comments block in a public location
      Log off
      Refresh the page with a JS console open:

      Uncaught TypeError: Cannot call method 'get' of null
      proto.erroryui.js:1147
      proto._notifyyui.js:838
      proto._use.handleLoaderyui.js:971
      Y.Loader._finishyui.js:7411
      Y.Loader._onSuccessyui.js:7456
      Y.Loader._insert.completeyui.js:7653
      Y.Loader._insert.Y.Get.js.onSuccessyui.js:7715
      Transaction._finishyui.js:4624
      Transaction._nextyui.js:4806
      Transaction._progressyui.js:4913
      onLoad

      Looks like toggle_textarea tries to act upon the comment's textarea even if it doesn't exist

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              samhemelryk Sam Hemelryk added a comment -

              Changes look spot on thanks Andrew, putting this up for integration straight away!

              Show
              samhemelryk Sam Hemelryk added a comment - Changes look spot on thanks Andrew, putting this up for integration straight away!
              Hide
              poltawski Dan Poltawski added a comment -

              Does this affect other branches?

              Show
              poltawski Dan Poltawski added a comment - Does this affect other branches?
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Thanks for catching that Dan. I think this affects all stable branches. Just confirming

              Show
              dobedobedoh Andrew Nicols added a comment - Thanks for catching that Dan. I think this affects all stable branches. Just confirming
              Hide
              dobedobedoh Andrew Nicols added a comment -

              This will cherry-pick cleanly to all stable branches

              Show
              dobedobedoh Andrew Nicols added a comment - This will cherry-pick cleanly to all stable branches
              Hide
              poltawski Dan Poltawski added a comment -

              Integrated, thanks

              Show
              poltawski Dan Poltawski added a comment - Integrated, thanks
              Hide
              phalacee Jason Fowler added a comment -

              Clean and clear of errors

              Show
              phalacee Jason Fowler added a comment - Clean and clear of errors
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

              Thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12