Moodle

comment.js attempts to act on textarea when it's not there

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1.6, 2.3
  • Fix Version/s: 2.3
  • Component/s: Commenting
  • Labels:

Description

Create a new comments block in a public location
Log off
Refresh the page with a JS console open:

Uncaught TypeError: Cannot call method 'get' of null
proto.erroryui.js:1147
proto._notifyyui.js:838
proto._use.handleLoaderyui.js:971
Y.Loader._finishyui.js:7411
Y.Loader._onSuccessyui.js:7456
Y.Loader._insert.completeyui.js:7653
Y.Loader._insert.Y.Get.js.onSuccessyui.js:7715
Transaction._finishyui.js:4624
Transaction._nextyui.js:4806
Transaction._progressyui.js:4913
onLoad

Looks like toggle_textarea tries to act upon the comment's textarea even if it doesn't exist

Issue Links

is duplicated by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33213 Comments block causes JS error for unauthenticated user

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sam Hemelryk added a comment -

Changes look spot on thanks Andrew, putting this up for integration straight away!

Show
Sam Hemelryk added a comment - Changes look spot on thanks Andrew, putting this up for integration straight away!
Hide
Permalink
Dan Poltawski added a comment -

Does this affect other branches?

Show
Dan Poltawski added a comment - Does this affect other branches?
Hide
Permalink
Andrew Nicols added a comment -

Thanks for catching that Dan. I think this affects all stable branches. Just confirming

Show
Andrew Nicols added a comment - Thanks for catching that Dan. I think this affects all stable branches. Just confirming
Hide
Permalink
Andrew Nicols added a comment -

This will cherry-pick cleanly to all stable branches

Show
Andrew Nicols added a comment - This will cherry-pick cleanly to all stable branches
Hide
Permalink
Dan Poltawski added a comment -

Integrated, thanks

Show
Dan Poltawski added a comment - Integrated, thanks
Hide
Permalink
Jason Fowler added a comment -

Clean and clear of errors

Show
Jason Fowler added a comment - Clean and clear of errors
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

Thanks!

Show
Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: