Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.1.6, 2.3
-
Fix Version/s: 2.3
-
Component/s: Comments
-
Testing Instructions:
- Add a new comments block to the site homepage
- Log off
- Open the JS console
- Refresh the Site Homepage
- Confirm that there are no errors about get
-
Affected Branches:MOODLE_21_STABLE, MOODLE_23_STABLE
-
Fixed Branches:MOODLE_23_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-33186-master-1 -
Pull Master Diff URL:
Description
Create a new comments block in a public location
Log off
Refresh the page with a JS console open:
Uncaught TypeError: Cannot call method 'get' of null
|
proto.erroryui.js:1147
|
proto._notifyyui.js:838
|
proto._use.handleLoaderyui.js:971
|
Y.Loader._finishyui.js:7411
|
Y.Loader._onSuccessyui.js:7456
|
Y.Loader._insert.completeyui.js:7653
|
Y.Loader._insert.Y.Get.js.onSuccessyui.js:7715
|
Transaction._finishyui.js:4624
|
Transaction._nextyui.js:4806
|
Transaction._progressyui.js:4913
|
onLoad
|
Looks like toggle_textarea tries to act upon the comment's textarea even if it doesn't exist
Gliffy Diagrams
Attachments
Issue Links
- is duplicated by
-
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Does this affect other branches?
Thanks for catching that Dan. I think this affects all stable branches. Just confirming
This will cherry-pick cleanly to all stable branches
Integrated, thanks
Clean and clear of errors
This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).
Thanks!
Changes look spot on thanks Andrew, putting this up for integration straight away!