Moodle
  1. Moodle
  2. MDL-33196

Unable to choose recent file with JS turned off

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Filepicker
    • Labels:
    • Environment:
      qa.moodle.net with Opera browser
    • Testing Instructions:
      Hide

      Be sure to have JS turned off at browser and site/user level

      1. Go to course and add "resource > file"
      2. In "Select files" section choose "Add", then "Recent files"
      3. Choose a file listed and click "Select"

      Make sure there's no error display.

      Show
      Be sure to have JS turned off at browser and site/user level Go to course and add "resource > file" In "Select files" section choose "Add", then "Recent files" Choose a file listed and click "Select" Make sure there's no error display.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      1. Be sure to have JS turned off at browser and site/user level
      2. Go to course and add "resource > file"
      3. In "Select files" section choose "Add", then "Recent files"
      4. Choose a file listed and click "Select"
      5. Get error message "Fatal error: Call to undefined method moodle_page::url() in /html/repository/filepicker.php on line 319"

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Michael de Raadt added a comment -

            Thanks for reporting this, Rex.

            We'll get onto this and hopefully resolve this for a retest soon.

            Show
            Michael de Raadt added a comment - Thanks for reporting this, Rex. We'll get onto this and hopefully resolve this for a retest soon.
            Hide
            Rossiani Wijaya added a comment -

            Created patch to fixed the error. However, found another error on the next step to downloading the file. I created new issue to fix the downloading file (MDL-33322).

            Submitting for peer review.

            Show
            Rossiani Wijaya added a comment - Created patch to fixed the error. However, found another error on the next step to downloading the file. I created new issue to fix the downloading file ( MDL-33322 ). Submitting for peer review.
            Hide
            Ankit Agarwal added a comment -

            +1 to integrate
            Looks good.
            Thanks

            Show
            Ankit Agarwal added a comment - +1 to integrate Looks good. Thanks
            Hide
            Rossiani Wijaya added a comment -

            Thanks Ankit,

            Submitting for integration review.

            Show
            Rossiani Wijaya added a comment - Thanks Ankit, Submitting for integration review.
            Hide
            Aparup Banerjee added a comment -

            ah, the patch works, so after that i selected the file, then i hit download and boom!
            Notice: Undefined property: stdClass::$contextid in /home/aparup/mcode/integration/lib/filestorage/file_storage.php on line 953

            Show
            Aparup Banerjee added a comment - ah, the patch works, so after that i selected the file, then i hit download and boom! Notice: Undefined property: stdClass::$contextid in /home/aparup/mcode/integration/lib/filestorage/file_storage.php on line 953
            Hide
            Rossiani Wijaya added a comment -

            Yes Apu, the "boom" will be fixed in MDL-33322

            Show
            Rossiani Wijaya added a comment - Yes Apu, the "boom" will be fixed in MDL-33322
            Hide
            Aparup Banerjee added a comment -

            Ah cool, it is the same. Thanks, this has been integrated into master. (i've checked this isn't needed in 22)

            Show
            Aparup Banerjee added a comment - Ah cool, it is the same. Thanks, this has been integrated into master. (i've checked this isn't needed in 22)
            Hide
            Frédéric Massart added a comment -

            Test passed, although while MDL-33322 is not fixed this feature is not usable.

            Show
            Frédéric Massart added a comment - Test passed, although while MDL-33322 is not fixed this feature is not usable.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

            Thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: