Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33212

Activity Completion and Restrict Access fails to hide

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      NOTE: When describing this test I avoided using the eye icons. That's because these have never worked quite correctly in AJAX mode, and I didn't want to confuse this issue with that.

      The second half of this test checks the previous (not changed) behaviour to make sure it still works when they aren't hidden.

      1. You must have the conditional availability options enabled in server settings.

      2. In a course, create a Label with these settings:

      • Name = 'Test'
      • Visible = Hide
      • Available from = Enabled; select future date

      3. While still logged in as a manager/admin/teacher, turn editing off, and look at the label on the course page.

      • It should display as:

      Test <-- greyed-out

      4. Using another browser, log in as a student. The label should not display at all.

      5. Back as manager, turn editing on, edit the label settings and change 'Visible' to 'Show', then turn editing off again.

      • Label should now look like

      Test <-- still greyed-out

      Available from 23 May 2016.

      6. As student, reload the page.

      • Label should now look the same as it does for manager. (Note: setting labels to be unavailable but visible is kind of silly, but that doesn't matter from the purpose of this test.)
      Show
      NOTE: When describing this test I avoided using the eye icons. That's because these have never worked quite correctly in AJAX mode, and I didn't want to confuse this issue with that. The second half of this test checks the previous (not changed) behaviour to make sure it still works when they aren't hidden. 1. You must have the conditional availability options enabled in server settings. 2. In a course, create a Label with these settings: Name = 'Test' Visible = Hide Available from = Enabled; select future date 3. While still logged in as a manager/admin/teacher, turn editing off, and look at the label on the course page. It should display as: Test <-- greyed-out 4. Using another browser, log in as a student. The label should not display at all. 5. Back as manager, turn editing on, edit the label settings and change 'Visible' to 'Show', then turn editing off again. Label should now look like Test <-- still greyed-out Available from 23 May 2016. 6. As student, reload the page. Label should now look the same as it does for manager. (Note: setting labels to be unavailable but visible is kind of silly, but that doesn't matter from the purpose of this test.)
    • Workaround:
      Hide

      Set 'Before activity can be accessed' option to 'Hide completely' at the same time as setting the visible option to 'Hide'.

      Show
      Set 'Before activity can be accessed' option to 'Hide completely' at the same time as setting the visible option to 'Hide'.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-33212-master

      Description

      Working with activity completion and restrict access functions. Created resources that have access dependent on previous resources being viewed, as well as an activity dependent on all resources being viewed. First resource is set as shown, subsequent resources and activity hidden, but are still visible to student.

      RECREATION STEPS:

      1)Add a Resource - URL: test1
      A)Set visibility to "Show"
      B)Activity completion - "Show activity as complete when conditions are met" and "Student must view this activity to complete it" activated
      2)Add a Resource - URL: test 2
      A)Set visibility to "Hide"
      B) Activity Completion - "Show activity as complete when conditions are met" and "Student must view this activity to complete it" activated
      3)Add an activity - Quiz: test 3
      A) set visibility to hide

      At this point everything is at it should be. The first resource is available, and the subsequent resource and activity are hidden as per settings.

      4)Edit settings test 2
      A) Restrict Access - Set Activity completion condition to "Test 1" and "Must be marked as complete"
      5)Edit settings test 3
      A) Restrict Access - Set Activity completion condition to "Test 2" and "Must be marked as complete"

      Now the items "test 2" and "test 3", which were previously hidden from students are visible to students with the message "Not available until the activity ' ' is marked complete." Student is unable to access, view, even click on the items, but are nonetheless able to see that the item is there, and what access to that item is contingent upon.

      If the entire week/topic is hidden then the items do not appear as that week/section is unavailable.

      Need to have the functionality to hide these items from students if that is what the teacher wants.

        Attachments

          Activity

            People

            • Assignee:
              quen Sam Marshall
              Reporter:
              sandadam Adam Sanders
              Peer reviewer:
              Sam Hemelryk
              Integrator:
              Dan Poltawski
              Tester:
              Rossiani Wijaya
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Sam Marshall, Jake Dallimore, Jun Pataleta, Ryan Wyllie, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jul/12